From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A906C00140 for ; Fri, 12 Aug 2022 07:01:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235319AbiHLHBP (ORCPT ); Fri, 12 Aug 2022 03:01:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbiHLHBO (ORCPT ); Fri, 12 Aug 2022 03:01:14 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76B94760D0; Fri, 12 Aug 2022 00:01:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DE659B82368; Fri, 12 Aug 2022 07:01:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92C8FC433D6; Fri, 12 Aug 2022 07:01:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660287670; bh=Yc1UoNzkUPCSb683h7ID5Q9aOBKqG/sOvwNmagMqBVA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SiAo4Xf6Eo7bB9rMLk6IW7F4K+UBJvghm8SYitZcHv6eIOppFWlW/oDyTdpM3Zsh1 Fhglla4429SZ6MA9UR+fFoYwScSk/Br9xgxvCL0TxiwuWxwg+v/CM7Lmv0XLNwl0tz 64dSiw4/3xlnIdAviBWU1yWI0qXaF3cETFlye/HpGU9RAx3JZPgQoClV/fHLN6mB/K wPzi1fDwTwTsbup35YqRKCGltFVyR5HJMYlBwKimlPfS3wMopfA5r+FpGdbDVh1QRH yWP/ad9tZzBqj1InsH+4nON2U+gbDeTh/4wJkTXzQQqQBqyaGQd0ZIgsXy573MvzAX r7AsM2iZLu0FQ== Date: Fri, 12 Aug 2022 08:01:04 +0100 From: Lee Jones To: Matt Ranostay Cc: nm@ti.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/6] MFD: TPS6594x: Add new PMIC device driver for TPS6594x chips Message-ID: References: <20220812032242.564026-1-mranostay@ti.com> <20220812032242.564026-3-mranostay@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220812032242.564026-3-mranostay@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Thu, 11 Aug 2022, Matt Ranostay wrote: > From: Keerthy > > The TPS6594x chip is a PMIC, and contains the following components: > > - Regulators > - GPIO controller > - RTC > > However initially only RTC is supported. > > Signed-off-by: Keerthy > Signed-off-by: Matt Ranostay > --- > drivers/mfd/Kconfig | 14 ++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/tps6594x.c | 121 +++++++++++++++++++++++++++++++++++ > include/linux/mfd/tps6594x.h | 84 ++++++++++++++++++++++++ > 4 files changed, 220 insertions(+) > create mode 100644 drivers/mfd/tps6594x.c > create mode 100644 include/linux/mfd/tps6594x.h > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index abb58ab1a1a4..4845683ae1d0 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1547,6 +1547,20 @@ config MFD_TI_LP873X > This driver can also be built as a module. If so, the module > will be called lp873x. > > +config MFD_TPS6594X > + tristate "TI TPS6594X Power Management IC" > + depends on I2C && OF > + select MFD_CORE > + select REGMAP_I2C > + help > + If you say yes here then you get support for the TPS6594X series of > + Power Management Integrated Circuits (PMIC). > + These include voltage regulators, RTS, configurable > + General Purpose Outputs (GPO) that are used in portable devices. > + > + This driver can also be built as a module. If so, the module > + will be called tps6594x. > + > config MFD_TI_LP87565 > tristate "TI LP87565 Power Management IC" > depends on I2C && OF > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index 858cacf659d6..7ff6a8a57d55 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -105,6 +105,7 @@ obj-$(CONFIG_MFD_TPS65910) += tps65910.o > obj-$(CONFIG_MFD_TPS65912) += tps65912-core.o > obj-$(CONFIG_MFD_TPS65912_I2C) += tps65912-i2c.o > obj-$(CONFIG_MFD_TPS65912_SPI) += tps65912-spi.o > +obj-$(CONFIG_MFD_TPS6594X) += tps6594x.o > obj-$(CONFIG_MENELAUS) += menelaus.o > > obj-$(CONFIG_TWL4030_CORE) += twl-core.o twl4030-irq.o twl6030-irq.o > diff --git a/drivers/mfd/tps6594x.c b/drivers/mfd/tps6594x.c > new file mode 100644 > index 000000000000..ff265b91db3e > --- /dev/null > +++ b/drivers/mfd/tps6594x.c > @@ -0,0 +1,121 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Driver for tps6594x PMIC chips > + * > + * Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com/ > + * Author: Keerthy > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +static const struct regmap_config tps6594x_regmap_config = { > + .reg_bits = 8, > + .val_bits = 8, > + .max_register = TPS6594X_REG_MAX, > +}; > + > +static const struct mfd_cell tps6594x_cells[] = { > + { .name = "tps6594x-gpio" }, > + { .name = "tps6594x-regulator" }, > + { .name = "tps6594x-rtc" }, > +}; Where are the device drivers for these? -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2F26C00140 for ; Fri, 12 Aug 2022 07:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8xyMBjD0xmx0uk0LmRIH+zsw+sJHx6qvAQauxeFYDB4=; b=FwOdFfvjg5Jv+B na9hcF/KXVgDIkTzLvK9whI/eJS0HRwtbEnvAMJyQaghhfYVqtgxYZAeNFucy+d2q4hqAIVBMXUg2 P37zvdoZKpmtStnZnajXeQ/ioMq/LfrvuKZIU+gGIilSQLG+Sxk8TzrpK31Vcvxo8U6eHgVD7gY0d mV2G9nbP3+4h0t41n2lhNP5RsDTF1Dmu/rFV1E67vqTLXBo9BonVvSlVvmdOH3MMfeF4Y5PO2Xc8R zANnoui8CgNo89Wm2P3Mv/gTBWQY8w82knK2au2PxT4cRLMTuLB17RB0sPjY21/eZRYxstSX6tj/a 7mW7elKtT3wuBFfUrFfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMOfW-000TlD-4t; Fri, 12 Aug 2022 07:01:18 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMOfR-000TZ0-V6 for linux-arm-kernel@lists.infradead.org; Fri, 12 Aug 2022 07:01:15 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C21A2B8224C; Fri, 12 Aug 2022 07:01:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92C8FC433D6; Fri, 12 Aug 2022 07:01:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660287670; bh=Yc1UoNzkUPCSb683h7ID5Q9aOBKqG/sOvwNmagMqBVA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SiAo4Xf6Eo7bB9rMLk6IW7F4K+UBJvghm8SYitZcHv6eIOppFWlW/oDyTdpM3Zsh1 Fhglla4429SZ6MA9UR+fFoYwScSk/Br9xgxvCL0TxiwuWxwg+v/CM7Lmv0XLNwl0tz 64dSiw4/3xlnIdAviBWU1yWI0qXaF3cETFlye/HpGU9RAx3JZPgQoClV/fHLN6mB/K wPzi1fDwTwTsbup35YqRKCGltFVyR5HJMYlBwKimlPfS3wMopfA5r+FpGdbDVh1QRH yWP/ad9tZzBqj1InsH+4nON2U+gbDeTh/4wJkTXzQQqQBqyaGQd0ZIgsXy573MvzAX r7AsM2iZLu0FQ== Date: Fri, 12 Aug 2022 08:01:04 +0100 From: Lee Jones To: Matt Ranostay Cc: nm@ti.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/6] MFD: TPS6594x: Add new PMIC device driver for TPS6594x chips Message-ID: References: <20220812032242.564026-1-mranostay@ti.com> <20220812032242.564026-3-mranostay@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220812032242.564026-3-mranostay@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220812_000114_302647_6D931F6F X-CRM114-Status: GOOD ( 26.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAxMSBBdWcgMjAyMiwgTWF0dCBSYW5vc3RheSB3cm90ZToKCj4gRnJvbTogS2VlcnRo eSA8ai1rZWVydGh5QHRpLmNvbT4KPiAKPiBUaGUgVFBTNjU5NHggY2hpcCBpcyBhIFBNSUMsIGFu ZCBjb250YWlucyB0aGUgZm9sbG93aW5nIGNvbXBvbmVudHM6Cj4gCj4gLSBSZWd1bGF0b3JzCj4g LSBHUElPIGNvbnRyb2xsZXIKPiAtIFJUQwo+IAo+IEhvd2V2ZXIgaW5pdGlhbGx5IG9ubHkgUlRD IGlzIHN1cHBvcnRlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBLZWVydGh5IDxqLWtlZXJ0aHlAdGku Y29tPgo+IFNpZ25lZC1vZmYtYnk6IE1hdHQgUmFub3N0YXkgPG1yYW5vc3RheUB0aS5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvbWZkL0tjb25maWcgICAgICAgICAgfCAgMTQgKysrKwo+ICBkcml2ZXJz L21mZC9NYWtlZmlsZSAgICAgICAgIHwgICAxICsKPiAgZHJpdmVycy9tZmQvdHBzNjU5NHguYyAg ICAgICB8IDEyMSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRl L2xpbnV4L21mZC90cHM2NTk0eC5oIHwgIDg0ICsrKysrKysrKysrKysrKysrKysrKysrKwo+ICA0 IGZpbGVzIGNoYW5nZWQsIDIyMCBpbnNlcnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBk cml2ZXJzL21mZC90cHM2NTk0eC5jCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL2xpbnV4 L21mZC90cHM2NTk0eC5oCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL0tjb25maWcgYi9k cml2ZXJzL21mZC9LY29uZmlnCj4gaW5kZXggYWJiNThhYjFhMWE0Li40ODQ1NjgzYWUxZDAgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9tZmQvS2NvbmZpZwo+ICsrKyBiL2RyaXZlcnMvbWZkL0tjb25m aWcKPiBAQCAtMTU0Nyw2ICsxNTQ3LDIwIEBAIGNvbmZpZyBNRkRfVElfTFA4NzNYCj4gIAkgIFRo aXMgZHJpdmVyIGNhbiBhbHNvIGJlIGJ1aWx0IGFzIGEgbW9kdWxlLiBJZiBzbywgdGhlIG1vZHVs ZQo+ICAJICB3aWxsIGJlIGNhbGxlZCBscDg3M3guCj4gIAo+ICtjb25maWcgTUZEX1RQUzY1OTRY Cj4gKwl0cmlzdGF0ZSAiVEkgVFBTNjU5NFggUG93ZXIgTWFuYWdlbWVudCBJQyIKPiArCWRlcGVu ZHMgb24gSTJDICYmIE9GCj4gKwlzZWxlY3QgTUZEX0NPUkUKPiArCXNlbGVjdCBSRUdNQVBfSTJD Cj4gKwloZWxwCj4gKwkgIElmIHlvdSBzYXkgeWVzIGhlcmUgdGhlbiB5b3UgZ2V0IHN1cHBvcnQg Zm9yIHRoZSBUUFM2NTk0WCBzZXJpZXMgb2YKPiArCSAgUG93ZXIgTWFuYWdlbWVudCBJbnRlZ3Jh dGVkIENpcmN1aXRzIChQTUlDKS4KPiArCSAgVGhlc2UgaW5jbHVkZSB2b2x0YWdlIHJlZ3VsYXRv cnMsIFJUUywgY29uZmlndXJhYmxlCj4gKwkgIEdlbmVyYWwgUHVycG9zZSBPdXRwdXRzIChHUE8p IHRoYXQgYXJlIHVzZWQgaW4gcG9ydGFibGUgZGV2aWNlcy4KPiArCj4gKwkgIFRoaXMgZHJpdmVy IGNhbiBhbHNvIGJlIGJ1aWx0IGFzIGEgbW9kdWxlLiBJZiBzbywgdGhlIG1vZHVsZQo+ICsJICB3 aWxsIGJlIGNhbGxlZCB0cHM2NTk0eC4KPiArCj4gIGNvbmZpZyBNRkRfVElfTFA4NzU2NQo+ICAJ dHJpc3RhdGUgIlRJIExQODc1NjUgUG93ZXIgTWFuYWdlbWVudCBJQyIKPiAgCWRlcGVuZHMgb24g STJDICYmIE9GCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL01ha2VmaWxlIGIvZHJpdmVycy9t ZmQvTWFrZWZpbGUKPiBpbmRleCA4NThjYWNmNjU5ZDYuLjdmZjZhOGE1N2Q1NSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL21mZC9NYWtlZmlsZQo+ICsrKyBiL2RyaXZlcnMvbWZkL01ha2VmaWxlCj4g QEAgLTEwNSw2ICsxMDUsNyBAQCBvYmotJChDT05GSUdfTUZEX1RQUzY1OTEwKQkrPSB0cHM2NTkx MC5vCj4gIG9iai0kKENPTkZJR19NRkRfVFBTNjU5MTIpCSs9IHRwczY1OTEyLWNvcmUubwo+ICBv YmotJChDT05GSUdfTUZEX1RQUzY1OTEyX0kyQykJKz0gdHBzNjU5MTItaTJjLm8KPiAgb2JqLSQo Q09ORklHX01GRF9UUFM2NTkxMl9TUEkpICArPSB0cHM2NTkxMi1zcGkubwo+ICtvYmotJChDT05G SUdfTUZEX1RQUzY1OTRYKQkrPSB0cHM2NTk0eC5vCj4gIG9iai0kKENPTkZJR19NRU5FTEFVUykJ CSs9IG1lbmVsYXVzLm8KPiAgCj4gIG9iai0kKENPTkZJR19UV0w0MDMwX0NPUkUpCSs9IHR3bC1j b3JlLm8gdHdsNDAzMC1pcnEubyB0d2w2MDMwLWlycS5vCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv bWZkL3RwczY1OTR4LmMgYi9kcml2ZXJzL21mZC90cHM2NTk0eC5jCj4gbmV3IGZpbGUgbW9kZSAx MDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAuLmZmMjY1YjkxZGIzZQo+IC0tLSAvZGV2L251bGwK PiArKysgYi9kcml2ZXJzL21mZC90cHM2NTk0eC5jCj4gQEAgLTAsMCArMSwxMjEgQEAKPiArLy8g U1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAtb3ItbGF0ZXIKPiArLyoKPiArICogRHJp dmVyIGZvciB0cHM2NTk0eCBQTUlDIGNoaXBzCj4gKyAqCj4gKyAqIENvcHlyaWdodCAoQykgMjAy MiBUZXhhcyBJbnN0cnVtZW50cyBJbmNvcnBvcmF0ZWQgLSBodHRwczovL3d3dy50aS5jb20vCj4g KyAqIEF1dGhvcjogS2VlcnRoeSA8ai1rZWVydGh5QHRpLmNvbT4KPiArICovCj4gKwo+ICsjaW5j bHVkZSA8bGludXgvb2YuaD4KPiArI2luY2x1ZGUgPGxpbnV4L29mX2RldmljZS5oPgo+ICsjaW5j bHVkZSA8bGludXgvbWZkL2NvcmUuaD4KPiArI2luY2x1ZGUgPGxpbnV4L21mZC90cHM2NTk0eC5o Pgo+ICsjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9pMmMuaD4K PiArI2luY2x1ZGUgPGxpbnV4L3JlZ21hcC5oPgo+ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBy ZWdtYXBfY29uZmlnIHRwczY1OTR4X3JlZ21hcF9jb25maWcgPSB7Cj4gKwkucmVnX2JpdHMgPSA4 LAo+ICsJLnZhbF9iaXRzID0gOCwKPiArCS5tYXhfcmVnaXN0ZXIgPSBUUFM2NTk0WF9SRUdfTUFY LAo+ICt9Owo+ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBtZmRfY2VsbCB0cHM2NTk0eF9jZWxs c1tdID0gewo+ICsJeyAubmFtZSA9ICJ0cHM2NTk0eC1ncGlvIiB9LAo+ICsJeyAubmFtZSA9ICJ0 cHM2NTk0eC1yZWd1bGF0b3IiIH0sCj4gKwl7IC5uYW1lID0gInRwczY1OTR4LXJ0YyIgfSwKPiAr fTsKCldoZXJlIGFyZSB0aGUgZGV2aWNlIGRyaXZlcnMgZm9yIHRoZXNlPwoKLS0gCkxlZSBKb25l cyBb5p2O55C85pavXQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=