All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Martin Liška" <mliska@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf: fix coding style in build-id.c
Date: Fri, 12 Aug 2022 10:23:25 -0300	[thread overview]
Message-ID: <YvZUTbEjvSLbUJQQ@kernel.org> (raw)
In-Reply-To: <2983e2e0-6850-ad59-79d8-efe83b22cffe@suse.cz>

Em Fri, Aug 12, 2022 at 01:42:56PM +0200, Martin Liška escreveu:
> Use tabs instead of 8 spaces for the indentation.

Thanks, applied.

- Arnaldo


> Signed-off-by: Martin Liska <mliska@suse.cz>
> ---
>  tools/perf/util/build-id.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c
> index 9e176146eb10..0cc68cdd84c8 100644
> --- a/tools/perf/util/build-id.c
> +++ b/tools/perf/util/build-id.c
> @@ -652,17 +652,17 @@ static char *build_id_cache__find_debug(const char *sbuild_id,
>  	nsinfo__mountns_exit(&nsc);
>  
>  #ifdef HAVE_DEBUGINFOD_SUPPORT
> -        if (realname == NULL) {
> -                debuginfod_client* c = debuginfod_begin();
> -                if (c != NULL) {
> -                        int fd = debuginfod_find_debuginfo(c,
> -                                                           (const unsigned char*)sbuild_id, 0,
> -                                                           &realname);
> -                        if (fd >= 0)
> -                                close(fd); /* retaining reference by realname */
> -                        debuginfod_end(c);
> -                }
> -        }
> +	if (realname == NULL) {
> +		debuginfod_client* c = debuginfod_begin();
> +		if (c != NULL) {
> +			int fd = debuginfod_find_debuginfo(c,
> +					(const unsigned char*)sbuild_id, 0,
> +					&realname);
> +			if (fd >= 0)
> +				close(fd); /* retaining reference by realname */
> +			debuginfod_end(c);
> +		}
> +	}
>  #endif
>  
>  out:
> -- 
> 2.37.1

-- 

- Arnaldo

      parent reply	other threads:[~2022-08-12 13:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12 11:42 [PATCH] perf: fix coding style in build-id.c Martin Liška
2022-08-12 11:43 ` [PATCH] perf: Print debuginfod queries if -v option is used Martin Liška
2022-08-12 13:24   ` Arnaldo Carvalho de Melo
2022-08-12 13:23 ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvZUTbEjvSLbUJQQ@kernel.org \
    --to=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.