From: Eric Biggers <ebiggers@kernel.org>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, jlayton@kernel.org, tytso@mit.edu,
linux-fsdevel@vger.kernel.org, Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH v2 2/3] fs: record I_DIRTY_TIME even if inode already has I_DIRTY_INODE
Date: Fri, 12 Aug 2022 11:20:36 -0700 [thread overview]
Message-ID: <YvaZ9Jwq5Awu9tl3@sol.localdomain> (raw)
In-Reply-To: <20220805122306.anavrrmt6lqwd2yt@fedora>
On Fri, Aug 05, 2022 at 02:23:06PM +0200, Lukas Czerner wrote:
> >
> > Also what is the precise meaning of the flags argument to ->dirty_inode now?
> >
> > sb->s_op->dirty_inode(inode,
> > flags & (I_DIRTY_INODE | I_DIRTY_TIME));
> >
> > Note that dirty_inode is documented in Documentation/filesystems/vfs.rst.
>
> Don't know. It alredy don't mention I_DIRTY_SYNC that can be there as
> well.
Well, it didn't really need to because there were only two possibilities:
datasync and not datasync. This patch changes that.
> Additionaly it can have I_DIRTY_TIME to inform the fs we have a
> dirty timestamp as well (in case of lazytime).
This is introduced by this patch.
- Eric
next prev parent reply other threads:[~2022-08-12 18:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 10:53 [PATCH v2 1/3] ext4: don't increase iversion counter for ea_inodes Lukas Czerner
2022-08-03 10:53 ` [PATCH v2 2/3] fs: record I_DIRTY_TIME even if inode already has I_DIRTY_INODE Lukas Czerner
2022-08-05 8:05 ` Eric Biggers
2022-08-05 12:23 ` Lukas Czerner
2022-08-12 18:20 ` Eric Biggers [this message]
2022-08-07 23:08 ` Dave Chinner
2022-08-08 10:26 ` Lukas Czerner
2022-08-03 10:53 ` [PATCH v3 3/3] ext4: unconditionally enable the i_version counter Lukas Czerner
2022-08-03 13:04 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvaZ9Jwq5Awu9tl3@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.