From: "Theodore Ts'o" <tytso@mit.edu>
To: zhanchengbin <zhanchengbin1@huawei.com>
Cc: linux-ext4@vger.kernel.org, linfeilong <linfeilong@huawei.com>,
liuzhiqiang26@huawei.com, liangyun2@huawei.com,
Alexey Lyahkov <alexey.lyashkov@gmail.com>
Subject: Re: [PATCH] tune2fs: do not change j_tail_sequence in journal superblock
Date: Fri, 12 Aug 2022 21:12:36 -0400 [thread overview]
Message-ID: <Yvb6hPI1tinxoEgW@mit.edu> (raw)
In-Reply-To: <3f55f3ad-ba78-e590-65b7-07ff95c78ed1@huawei.com>
On Thu, Aug 04, 2022 at 06:33:39PM +0800, zhanchengbin wrote:
> The function recover_ext3_journal in debugfs/journal.c, if the log replay is
> over,
> the j_tail_sequence in journal superblock is not changed to the value of the
> last
> transaction sequence, this will cause subsequent log commitids to count from
> the
> commitid in last time.
> After tune2fs -e, the log commitid is counted from the commitid in last
> time, if
> the log ID of the current operation overlaps with that of the last
> operation, this
> will cause logs that were previously replayed by tune2fs to be replayed
> here.
>
> Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> Signed-off-by: liangyun <liangyun2@huawei.com>
Applied, thanks!
- Ted
prev parent reply other threads:[~2022-08-13 1:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 11:23 [BUG] Tune2fs and fuse2fs do not change j_tail_sequence in journal superblock zhanchengbin
2022-08-03 4:52 ` Alexey Lyahkov
2022-08-04 8:30 ` zhanchengbin
2022-08-04 10:33 ` [PATCH] tune2fs: " zhanchengbin
2022-08-09 1:31 ` zhanchengbin
2022-08-13 1:12 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yvb6hPI1tinxoEgW@mit.edu \
--to=tytso@mit.edu \
--cc=alexey.lyashkov@gmail.com \
--cc=liangyun2@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=zhanchengbin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.