From: Greg KH <greg@kroah.com>
To: Adverg Ebashinskii <ebashinskii@yandex.ru>
Cc: "kernelnewbies@kernelnewbies.org" <kernelnewbies@kernelnewbies.org>
Subject: Re: How to resubmit patches in the right way after review fixes?
Date: Sat, 13 Aug 2022 09:06:09 +0200 [thread overview]
Message-ID: <YvdNYdx/9D56UscW@kroah.com> (raw)
In-Reply-To: <86521660342820@mail.yandex.ru>
On Sat, Aug 13, 2022 at 01:39:45AM +0300, Adverg Ebashinskii wrote:
> In case I have submitted a patch and some mistakes were pointed what is the
> right way of submitting a corrected version?
> I basically have 2 questions related to patch re-submit.
>
> 1. Is it appropriate to submit a new patch starting a new thread or it's
> required to reply
> to one of the message in the old patch's thread to preserve a reference to
> the old one?
New thread is usually fine, but if you want you can do it in the old
thread, your choice.
> 2. In case the discussion of the patch ended up in patch redesign is it
> required to put a version when resubmitting?
Yes.
> For example the initial patch was [PATCH] sub/sys: summary. Should v2 be placed
> in the description of the new patch like
> [PATCH v2] sub/sys: completely different summary due to redesign?
Yes. And properly document your changes below the --- line as the
documentation asks for.
hope this helps,
greg k-h
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
prev parent reply other threads:[~2022-08-13 7:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 22:39 How to resubmit patches in the right way after review fixes? Adverg Ebashinskii
2022-08-13 7:06 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvdNYdx/9D56UscW@kroah.com \
--to=greg@kroah.com \
--cc=ebashinskii@yandex.ru \
--cc=kernelnewbies@kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.