From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Alexey Romanov <avromanov@sberdevices.ru>
Cc: minchan@kernel.org, senozhatsky@chromium.org, ngupta@vflare.org,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel@sberdevices.ru
Subject: Re: [PATCH v1 1/2] zsmalloc: zs_object_copy: add clarifying comment
Date: Mon, 15 Aug 2022 11:52:47 +0900 [thread overview]
Message-ID: <Yvm0//iPcvbW1M55@google.com> (raw)
In-Reply-To: <20220811153755.16102-2-avromanov@sberdevices.ru>
On (22/08/11 18:37), Alexey Romanov wrote:
> @@ -1564,6 +1564,12 @@ static void zs_object_copy(struct size_class *class, unsigned long dst,
> d_off += size;
> d_size -= size;
>
> + /* Calling kunmap_atomic(d_addr) is necessary. kunmap_atomic() calls
> + * must occurs in reverse order of calls to kmap_atomic().
> + * So, to call kunmap_atomic(s_addr) we should first call kunmap_atomic(d_addr).
> + * For more details see:
> + * https://lore.kernel.org/linux-mm/5512421D.4000603@samsung.com/
> + */
I'd drop the link part, Emails are not documentation, kmap_atomic
is documented in Documentation/mm/highmem
next prev parent reply other threads:[~2022-08-15 2:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 15:37 [PATCH v1 0/2] tidy up zsmalloc implementation Alexey Romanov
2022-08-11 15:37 ` [PATCH v1 1/2] zsmalloc: zs_object_copy: add clarifying comment Alexey Romanov
2022-08-15 2:52 ` Sergey Senozhatsky [this message]
2022-08-15 12:32 ` Aleksey Romanov
2022-08-11 15:37 ` [PATCH v1 2/2] zsmalloc: remove unnecessary size_class NULL check Alexey Romanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yvm0//iPcvbW1M55@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=avromanov@sberdevices.ru \
--cc=kernel@sberdevices.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.