Re: [PATCH 4.19 1/4] selftests/bpf: add selftest part of "bpf: Fix the off-by-two error in range markings"

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Aug 14, 2022 at 06:08:26PM +0300, Ovidiu Panait wrote:
> 
> On 8/14/22 17:44, Greg KH wrote:
> > [Please note: This e-mail is from an EXTERNAL e-mail address]
> > 
> > On Sun, Aug 14, 2022 at 04:58:56PM +0300, Ovidiu Panait wrote:
> > > Hi Greg,
> > > 
> > > On 8/13/22 16:10, Greg KH wrote:
> > > > [Please note: This e-mail is from an EXTERNAL e-mail address]
> > > > 
> > > > On Tue, Aug 09, 2022 at 10:39:44AM +0300, Ovidiu Panait wrote:
> > > > > From: Maxim Mikityanskiy <maximmi@nvidia.com>
> > > > > 
> > > > > The 4.19 backport of upstream commit 2fa7d94afc1a ("bpf: Fix the off-by-two
> > > > > error in range markings") did not include the selftest changes, so currently
> > > > > there are 8 verifier selftests that are failing:
> > > > >    # root@intel-x86-64:~# ./test_verifier
> > > > >    ...
> > > > >    #495/p XDP pkt read, pkt_end > pkt_data', bad access 1 FAIL
> > > > >    #498/p XDP pkt read, pkt_data' < pkt_end, bad access 1 FAIL
> > > > >    #504/p XDP pkt read, pkt_data' >= pkt_end, bad access 1 FAIL
> > > > >    #513/p XDP pkt read, pkt_end <= pkt_data', bad access 1 FAIL
> > > > >    #519/p XDP pkt read, pkt_data > pkt_meta', bad access 1 FAIL
> > > > >    #522/p XDP pkt read, pkt_meta' < pkt_data, bad access 1 FAIL
> > > > >    #528/p XDP pkt read, pkt_meta' >= pkt_data, bad access 1 FAIL
> > > > >    #537/p XDP pkt read, pkt_data <= pkt_meta', bad access 1 FAIL
> > > > >    Summary: 924 PASSED, 0 SKIPPED, 8 FAILED
> > > > > 
> > > > > Cherry-pick the selftest changes to fix these.
> > > > What specific "selftest changes" are you cherry-picking here?  I can't
> > > > take this commit without that reference.
> > > This patch includes the selftest part of upstream commit:
> > > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2fa7d94afc1a
> > > 
> > > 
> > > The 4.19 backport of the above commit did not include the selftest updates:
> > > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=c315bd962528
> > I still do not understand, what commit is this coming from that matches
> > it up with what is in Linus's tree?
> The changes come from commit 2fa7d94afc1a ("bpf: Fix the off-by-two error in
> range markings") in Linus's tree.

Then can you please reword the text here to make it obvious what is
happening and resubmit?

thanks,

gre gk-h