From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B989C3F6B0 for ; Mon, 15 Aug 2022 08:17:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229589AbiHOIRe (ORCPT ); Mon, 15 Aug 2022 04:17:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231558AbiHOIQG (ORCPT ); Mon, 15 Aug 2022 04:16:06 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6817BBCA7 for ; Mon, 15 Aug 2022 01:16:04 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id ay39-20020a05600c1e2700b003a5503a80cfso3568994wmb.2 for ; Mon, 15 Aug 2022 01:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=2EXJc+W0WiUMq6IfoG1+NtWZXhyvP3kHwdxs6Qb3+pI=; b=lesTjrSSeDPkH8yf41Y3AxvP2AQWHSlFR2nZLz0HLlk0Iy/HCk1CAwtRsXGnaysNLb tAPLT55tzSp6Q00NGkh8fjsx3iauwjBUM8O3v0CAlAT+6AldoCZ/EbIXAkMg+QM0X3Gp vIpw0FhvUXYktjK+CfSyatCMeNnGJfZlQUqKFVLrfaDV+zvmcYJRE1R4wylzSrDMmy93 8pDQD3zsL0CVnv00HRDyQz/AYIazyi2KrBYDq5LPJJOZS4eGqjMO2ATAGtrdSCEXhFVW 610Xz9+r+sXk+hpO/EICxAbe/080Sdr6GvdrOFlhu/aJCAxusPgrTy20zVQQCuiegM24 eV8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=2EXJc+W0WiUMq6IfoG1+NtWZXhyvP3kHwdxs6Qb3+pI=; b=S+o+DGIbKFm+ekYI9cexvKRYE8NxsFrMoBbrAgLT+wb+AyXN3UmZe9+q2IRx4Y5pYg EyzGbJZ9SY7Xh+cyVPJEFrHknSD9abhtWfbXLcXyzPhq5v8B0pmZIOZ76t+5PlEQOvzr oLtT+SO+sHQb5EMMF1n3VeBENASEef30iotcYX13nEFzk36EYhsQKOsQBAni6GGj7m9U oKuuvf0R1pgvkeE6b9YWSKubm797brw64qTmqRbp55F8Nv4yqKdC4CFnM6q44MOp1Uvl 7QHtAcrDBy+euUbSSUyhEK9CBa8OByGiHuiw0ykiPndlH/b7RbonOMrnpT1coV5XZIor ruNA== X-Gm-Message-State: ACgBeo1i7AYItw2n1inQQxnpiiVU6dtAE/5enFmC9YfLlYwmUObI7azx vqe0hB2YL0yoK1H/jtgm1EAiWg== X-Google-Smtp-Source: AA6agR7lE2pSrkUcP1I5mNHTVfwLSlcuX0/RK/cHwHELEIlPhh1ah5PsBhdugYuvVyleRs9OniBZng== X-Received: by 2002:a05:600c:3492:b0:3a5:e1a0:24c9 with SMTP id a18-20020a05600c349200b003a5e1a024c9mr5265215wmq.177.1660551362921; Mon, 15 Aug 2022 01:16:02 -0700 (PDT) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id i5-20020adff305000000b0021ef34124ebsm6602680wro.11.2022.08.15.01.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 01:16:02 -0700 (PDT) Date: Mon, 15 Aug 2022 11:16:00 +0300 From: Abel Vesa To: "Peng Fan (OSS)" , Stephen Boyd Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Peng Fan , kernel test robot Subject: Re: [PATCH V2 2/8] clk: imx93: guard imx93_clk_of_match with CONFIG_OF Message-ID: References: <20220815013039.474970-1-peng.fan@oss.nxp.com> <20220815013039.474970-3-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220815013039.474970-3-peng.fan@oss.nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 22-08-15 09:30:33, Peng Fan (OSS) wrote: > From: Peng Fan > > There is build warning when CONFIG_OF is not selected. > >> drivers/clk/imx/clk-imx93.c:324:34: warning: 'imx93_clk_of_match' > >> defined but not used [-Wunused-const-variable=] > 324 | static const struct of_device_id imx93_clk_of_match[] = { > | ^~~~~~~~~~~~~~~~~~ > > Use CONFIG_OF to guard imx93_clk_of_match to avoid build warning. > > Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk") > Reported-by: kernel test robot > Signed-off-by: Peng Fan > --- > drivers/clk/imx/clk-imx93.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c > index f5c9fa40491c..5099048b7916 100644 > --- a/drivers/clk/imx/clk-imx93.c > +++ b/drivers/clk/imx/clk-imx93.c > @@ -321,11 +321,13 @@ static int imx93_clocks_probe(struct platform_device *pdev) > return ret; > } > > +#ifdef CONFIG_OF Hmm, I'm not sure if we should do this or rather should we make this driver depend somehow on CONFIG_OF in Kconfig. Looking at the other i.MX clock drivers, it would seem we need this for all them too. I fairly OK with this, but maybe Stephen suggests something different. Reviewed-by: Abel Vesa > static const struct of_device_id imx93_clk_of_match[] = { > { .compatible = "fsl,imx93-ccm" }, > { /* Sentinel */ }, > }; > MODULE_DEVICE_TABLE(of, imx93_clk_of_match); > +#endif > > static struct platform_driver imx93_clk_driver = { > .probe = imx93_clocks_probe, > -- > 2.37.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA3BCC00140 for ; Mon, 15 Aug 2022 08:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6tG09L8XBTxVGl2znihdBSPctZG7D6mLNiEW2q3fl50=; b=VwT3g73z2LSe5N FmZAG831ry/h4Y2eRV8JglNT8dEzBuF9UCG5QeTS6SMiI6dS8pQ6Tb/H3CsoJlEdrnraUIbXZpxYm HiSh1Xo6DWtbfh2kC1PtMFM47YisFcCaqbnmm9BfDE7tGfRGcoZO/R4gEIeiVObwjjK3FJBCbwAht +Bx6L5WxN4rKO51CJZEw2IsPXRfJloSF87WGeV0DCG10B58thnKcEMKt4qq7TNNXSPUHtZUJN1XBB lBdhdL3pe9deUIHQN5+cvD+tS3/5YQf6IwBWlo1b5Ao10vk5m5pM5h0ZhRgfuEEApSz3Kp51t1iPs OqKZ5dzLuKiliN16Gz2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNVGi-00D2Mf-QC; Mon, 15 Aug 2022 08:16:17 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNVGY-00D2HO-LQ for linux-arm-kernel@lists.infradead.org; Mon, 15 Aug 2022 08:16:15 +0000 Received: by mail-wm1-x32e.google.com with SMTP id r83-20020a1c4456000000b003a5cb389944so3583489wma.4 for ; Mon, 15 Aug 2022 01:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=2EXJc+W0WiUMq6IfoG1+NtWZXhyvP3kHwdxs6Qb3+pI=; b=lesTjrSSeDPkH8yf41Y3AxvP2AQWHSlFR2nZLz0HLlk0Iy/HCk1CAwtRsXGnaysNLb tAPLT55tzSp6Q00NGkh8fjsx3iauwjBUM8O3v0CAlAT+6AldoCZ/EbIXAkMg+QM0X3Gp vIpw0FhvUXYktjK+CfSyatCMeNnGJfZlQUqKFVLrfaDV+zvmcYJRE1R4wylzSrDMmy93 8pDQD3zsL0CVnv00HRDyQz/AYIazyi2KrBYDq5LPJJOZS4eGqjMO2ATAGtrdSCEXhFVW 610Xz9+r+sXk+hpO/EICxAbe/080Sdr6GvdrOFlhu/aJCAxusPgrTy20zVQQCuiegM24 eV8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=2EXJc+W0WiUMq6IfoG1+NtWZXhyvP3kHwdxs6Qb3+pI=; b=yWPTVnlWmH1eMcQISgAXiA8tct0T8GunjrLpMvE9aNUQKWch4Knu5lhPihnEF0w2Mj 0+vNHlSmGjT41Yx1qdVXCQcEMg4YbdH/nBB0w0/N191JCkN0wuabnxVdL1Me+Itk/E5o GENZKCUTxQi2N3zV4mjIdfKlLfbhNGaYQ+q4FSURITYh+j7mD3084NMpf3Eg6DP9KL+r ML9KrPljmWbxdfTKWU+GF7Xu1jaujwAegXl+wJ4fKFEhfkc1KY2Wc0aN+/KkSdZ9YU8h gpB73XBXYt2lQ9xhm+EDRBFLQp4ZaDeAbzrSAFKMbm3hDbQyvrTSEZcqCvHm5QgQ8Ouc lKFg== X-Gm-Message-State: ACgBeo3vA4igsVEMwBsa0sGqSzmjl6aq3l/Bkvt03KfM++P3oG4FW8Eu C8uTtDF6um5GmcvTU+ZATx80dg== X-Google-Smtp-Source: AA6agR7lE2pSrkUcP1I5mNHTVfwLSlcuX0/RK/cHwHELEIlPhh1ah5PsBhdugYuvVyleRs9OniBZng== X-Received: by 2002:a05:600c:3492:b0:3a5:e1a0:24c9 with SMTP id a18-20020a05600c349200b003a5e1a024c9mr5265215wmq.177.1660551362921; Mon, 15 Aug 2022 01:16:02 -0700 (PDT) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id i5-20020adff305000000b0021ef34124ebsm6602680wro.11.2022.08.15.01.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 01:16:02 -0700 (PDT) Date: Mon, 15 Aug 2022 11:16:00 +0300 From: Abel Vesa To: "Peng Fan (OSS)" , Stephen Boyd Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Peng Fan , kernel test robot Subject: Re: [PATCH V2 2/8] clk: imx93: guard imx93_clk_of_match with CONFIG_OF Message-ID: References: <20220815013039.474970-1-peng.fan@oss.nxp.com> <20220815013039.474970-3-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220815013039.474970-3-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220815_011606_763775_535D0350 X-CRM114-Status: GOOD ( 22.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22-08-15 09:30:33, Peng Fan (OSS) wrote: > From: Peng Fan > > There is build warning when CONFIG_OF is not selected. > >> drivers/clk/imx/clk-imx93.c:324:34: warning: 'imx93_clk_of_match' > >> defined but not used [-Wunused-const-variable=] > 324 | static const struct of_device_id imx93_clk_of_match[] = { > | ^~~~~~~~~~~~~~~~~~ > > Use CONFIG_OF to guard imx93_clk_of_match to avoid build warning. > > Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk") > Reported-by: kernel test robot > Signed-off-by: Peng Fan > --- > drivers/clk/imx/clk-imx93.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c > index f5c9fa40491c..5099048b7916 100644 > --- a/drivers/clk/imx/clk-imx93.c > +++ b/drivers/clk/imx/clk-imx93.c > @@ -321,11 +321,13 @@ static int imx93_clocks_probe(struct platform_device *pdev) > return ret; > } > > +#ifdef CONFIG_OF Hmm, I'm not sure if we should do this or rather should we make this driver depend somehow on CONFIG_OF in Kconfig. Looking at the other i.MX clock drivers, it would seem we need this for all them too. I fairly OK with this, but maybe Stephen suggests something different. Reviewed-by: Abel Vesa > static const struct of_device_id imx93_clk_of_match[] = { > { .compatible = "fsl,imx93-ccm" }, > { /* Sentinel */ }, > }; > MODULE_DEVICE_TABLE(of, imx93_clk_of_match); > +#endif > > static struct platform_driver imx93_clk_driver = { > .probe = imx93_clocks_probe, > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel