From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B14C2C25B0E for ; Mon, 15 Aug 2022 08:24:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231465AbiHOIYC (ORCPT ); Mon, 15 Aug 2022 04:24:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231362AbiHOIYB (ORCPT ); Mon, 15 Aug 2022 04:24:01 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E019D1F620 for ; Mon, 15 Aug 2022 01:23:59 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id b4so5122958wrn.4 for ; Mon, 15 Aug 2022 01:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=ccR4jofJWS4WjddLtDejUK8NNWJJwrLYpOoeEAK37hk=; b=Z4OrasUxwxONGoGSbJZ7h5ZiVDJCbioDFPaHHgazEMdyqJJQyiku6tGWNWKTBxDDij 0XFLBmX+VKlhOW3GlHqttMscBJR/jHcG+2v12k6Saa+CiBcOnZdA3V1wyJLfs2NW9luD OI12bNtPzaSOi2q8S34U+cWSx6mFLjiXHMgGEyxjYoxR9ewN8DqFLFMGEaOLtkFCU7K6 uMw0JCmAI4mkcpndUwsHxNzg4EGDXfB1SNKIN6iinjKhq5AiHj8qzTYoZaIWD/5JRuWL LT68U7GpoBQsbC/iS1pWAanZb98vASc0qbmjpZsf2YHcQ/Bm6TdkViWsHUFj4DVL48Kn eXDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=ccR4jofJWS4WjddLtDejUK8NNWJJwrLYpOoeEAK37hk=; b=74hpc8tinNJNUudgCx6prQikKVH0Ui3laTRiyhNuIy9CsV7IZDebiTcwiG9jaiGvVL wl3P3GlgsB5mAZ3mQLNCxo1Ctdzvhc/n7uMIxvdeiuitZ7xnHJj0sR8zULqA6oL5u238 6s4IrRdNkr5X5DxoaG7A5/WGPG/PcCc8W99tLQqZUZSKLZOW7+slloPBQq3nXyvYeVks 0r/h95z4p1rQy28Fj2sWmnqQinPQMl9hWPY4pvdpDf3l7qAke0s4R+7CIj7seVbziAOJ yxu+BD6AS7sxJSNBkoGU8lT4a6U7/qOJpp4iyrlHgn2J5mSgdRn9gYvHRSOEzJTB84MX ZqtA== X-Gm-Message-State: ACgBeo1gGvlGHGj6WOgE2x16EOTAi+sWJYBx8UoLGl5ZluPRem5B6fpl 9SzDhfpSrBIv9tWmkqkiICHTDA== X-Google-Smtp-Source: AA6agR6vOZElDps4UHQbfw36ab2JeSARI3ajaEksSEKZIFJEVKaK27WUb3W9MKgJkVPPBd8kJfPTEQ== X-Received: by 2002:a5d:5b17:0:b0:220:7cec:2953 with SMTP id bx23-20020a5d5b17000000b002207cec2953mr8158320wrb.697.1660551838382; Mon, 15 Aug 2022 01:23:58 -0700 (PDT) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id q65-20020a1c4344000000b003a54d610e5fsm9033154wma.26.2022.08.15.01.23.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 01:23:57 -0700 (PDT) Date: Mon, 15 Aug 2022 11:23:56 +0300 From: Abel Vesa To: Peng Fan Cc: "Peng Fan (OSS)" , Stephen Boyd , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "abelvesa@kernel.org" , "mturquette@baylibre.com" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" , kernel test robot Subject: Re: [PATCH V2 2/8] clk: imx93: guard imx93_clk_of_match with CONFIG_OF Message-ID: References: <20220815013039.474970-1-peng.fan@oss.nxp.com> <20220815013039.474970-3-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 22-08-15 08:19:52, Peng Fan wrote: > > Subject: Re: [PATCH V2 2/8] clk: imx93: guard imx93_clk_of_match with > > CONFIG_OF > > > > On 22-08-15 09:30:33, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > > > There is build warning when CONFIG_OF is not selected. > > > >> drivers/clk/imx/clk-imx93.c:324:34: warning: 'imx93_clk_of_match' > > > >> defined but not used [-Wunused-const-variable=] > > > 324 | static const struct of_device_id imx93_clk_of_match[] = { > > > | ^~~~~~~~~~~~~~~~~~ > > > > > > Use CONFIG_OF to guard imx93_clk_of_match to avoid build warning. > > > > > > Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk") > > > Reported-by: kernel test robot > > > Signed-off-by: Peng Fan > > > --- > > > drivers/clk/imx/clk-imx93.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c > > > index f5c9fa40491c..5099048b7916 100644 > > > --- a/drivers/clk/imx/clk-imx93.c > > > +++ b/drivers/clk/imx/clk-imx93.c > > > @@ -321,11 +321,13 @@ static int imx93_clocks_probe(struct > > platform_device *pdev) > > > return ret; > > > } > > > > > > +#ifdef CONFIG_OF > > > > Hmm, I'm not sure if we should do this or rather should we make this driver > > depend somehow on CONFIG_OF in Kconfig. > > > > Looking at the other i.MX clock drivers, it would seem we need this for all > > them too. > > No. It is i.MX93 use of_match_ptr, I could drop it as i.MX8M. > > Thanks, > Peng. Right. Thanks for pointing that out. > > > > > I fairly OK with this, but maybe Stephen suggests something different. > > > > Reviewed-by: Abel Vesa > > Oups, wrong address here too. Reviewed-by: Abel Vesa > > > static const struct of_device_id imx93_clk_of_match[] = { > > > { .compatible = "fsl,imx93-ccm" }, > > > { /* Sentinel */ }, > > > }; > > > MODULE_DEVICE_TABLE(of, imx93_clk_of_match); > > > +#endif > > > > > > static struct platform_driver imx93_clk_driver = { > > > .probe = imx93_clocks_probe, > > > -- > > > 2.37.1 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5D55C25B0D for ; Mon, 15 Aug 2022 08:25:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jHlgTMuZLktg3sqT4u8roUs/Seq5YbeTdvv+tt8BIN4=; b=cj27FD8/7vZJx/ OP1gETtyOBqfNRgg0XBOnJWheEJoP2R6eWRd3msbbYIgO9gQaO5NRIMf7p8pqRhCFtmvbBscDztcZ Kt/ctsYZpLYD9sHQT/bOZKnzvvDEiOylhwN3qBKXapTJheul25EiNbxU4Gfs4L0aW96yOuxH9yti7 s2n9FjoTMAJu6c3lHpjsmjj2tMlljdSau7tHWPOIpjB3kc+Q7EmAU3VgPpVZgz/OryyndTXvDqvbJ 4xXcd+jRh3TmTbuYm5jpO2fr3PPJAEROyMhf+jJlh20rtzJvnt2my5/7Z5QatucnSwZPKDG2sIWuB YOrreWsEDsXGZ2sncj/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNVOL-00D81O-BE; Mon, 15 Aug 2022 08:24:09 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNVOC-00D7tc-LO for linux-arm-kernel@lists.infradead.org; Mon, 15 Aug 2022 08:24:06 +0000 Received: by mail-wr1-x432.google.com with SMTP id v3so8271901wrp.0 for ; Mon, 15 Aug 2022 01:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=ccR4jofJWS4WjddLtDejUK8NNWJJwrLYpOoeEAK37hk=; b=Z4OrasUxwxONGoGSbJZ7h5ZiVDJCbioDFPaHHgazEMdyqJJQyiku6tGWNWKTBxDDij 0XFLBmX+VKlhOW3GlHqttMscBJR/jHcG+2v12k6Saa+CiBcOnZdA3V1wyJLfs2NW9luD OI12bNtPzaSOi2q8S34U+cWSx6mFLjiXHMgGEyxjYoxR9ewN8DqFLFMGEaOLtkFCU7K6 uMw0JCmAI4mkcpndUwsHxNzg4EGDXfB1SNKIN6iinjKhq5AiHj8qzTYoZaIWD/5JRuWL LT68U7GpoBQsbC/iS1pWAanZb98vASc0qbmjpZsf2YHcQ/Bm6TdkViWsHUFj4DVL48Kn eXDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=ccR4jofJWS4WjddLtDejUK8NNWJJwrLYpOoeEAK37hk=; b=BKAVV7Xo6r3fWVxLQZI8uTCqlpTHFZnrVS2UcJEVX6LEBde9DO9yG3xb5LmGtE2VKb 5m9Qy0J39weJNiQgZJtytwZ5gIHOJgSAnioklXuSgmP+MOTaDl8MoD6YfZF8Tsn2L024 wjVfyiyTo67BGmhJIb587ofIqS4ECrixNwjA251B0FCkVzxyefFWlIwdlPGEHc5he+/z fEN109fGzq0787WP8bAmi6uPyjHBXEwkzduoniEFk/v8EQY5SoB0Crhq4UmdpQdvC3Qn K2hwpwhz3kI/MvMakj+hzpnDomATfi4fMNGn6zstDPIl/pQeHzy+P/ZW0twC5KYPz4Hw sGQw== X-Gm-Message-State: ACgBeo3MaJKr3Mvk0Aib7X8JgbqniLelRVTX2nGRBTQvyuV80c7I9Hie YnokK5i8/DmFJtE2lLtLDwhPxQ== X-Google-Smtp-Source: AA6agR6vOZElDps4UHQbfw36ab2JeSARI3ajaEksSEKZIFJEVKaK27WUb3W9MKgJkVPPBd8kJfPTEQ== X-Received: by 2002:a5d:5b17:0:b0:220:7cec:2953 with SMTP id bx23-20020a5d5b17000000b002207cec2953mr8158320wrb.697.1660551838382; Mon, 15 Aug 2022 01:23:58 -0700 (PDT) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id q65-20020a1c4344000000b003a54d610e5fsm9033154wma.26.2022.08.15.01.23.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 01:23:57 -0700 (PDT) Date: Mon, 15 Aug 2022 11:23:56 +0300 From: Abel Vesa To: Peng Fan Cc: "Peng Fan (OSS)" , Stephen Boyd , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "abelvesa@kernel.org" , "mturquette@baylibre.com" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" , kernel test robot Subject: Re: [PATCH V2 2/8] clk: imx93: guard imx93_clk_of_match with CONFIG_OF Message-ID: References: <20220815013039.474970-1-peng.fan@oss.nxp.com> <20220815013039.474970-3-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220815_012400_906626_FE1DCF5B X-CRM114-Status: GOOD ( 29.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22-08-15 08:19:52, Peng Fan wrote: > > Subject: Re: [PATCH V2 2/8] clk: imx93: guard imx93_clk_of_match with > > CONFIG_OF > > > > On 22-08-15 09:30:33, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > > > There is build warning when CONFIG_OF is not selected. > > > >> drivers/clk/imx/clk-imx93.c:324:34: warning: 'imx93_clk_of_match' > > > >> defined but not used [-Wunused-const-variable=] > > > 324 | static const struct of_device_id imx93_clk_of_match[] = { > > > | ^~~~~~~~~~~~~~~~~~ > > > > > > Use CONFIG_OF to guard imx93_clk_of_match to avoid build warning. > > > > > > Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk") > > > Reported-by: kernel test robot > > > Signed-off-by: Peng Fan > > > --- > > > drivers/clk/imx/clk-imx93.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c > > > index f5c9fa40491c..5099048b7916 100644 > > > --- a/drivers/clk/imx/clk-imx93.c > > > +++ b/drivers/clk/imx/clk-imx93.c > > > @@ -321,11 +321,13 @@ static int imx93_clocks_probe(struct > > platform_device *pdev) > > > return ret; > > > } > > > > > > +#ifdef CONFIG_OF > > > > Hmm, I'm not sure if we should do this or rather should we make this driver > > depend somehow on CONFIG_OF in Kconfig. > > > > Looking at the other i.MX clock drivers, it would seem we need this for all > > them too. > > No. It is i.MX93 use of_match_ptr, I could drop it as i.MX8M. > > Thanks, > Peng. Right. Thanks for pointing that out. > > > > > I fairly OK with this, but maybe Stephen suggests something different. > > > > Reviewed-by: Abel Vesa > > Oups, wrong address here too. Reviewed-by: Abel Vesa > > > static const struct of_device_id imx93_clk_of_match[] = { > > > { .compatible = "fsl,imx93-ccm" }, > > > { /* Sentinel */ }, > > > }; > > > MODULE_DEVICE_TABLE(of, imx93_clk_of_match); > > > +#endif > > > > > > static struct platform_driver imx93_clk_driver = { > > > .probe = imx93_clocks_probe, > > > -- > > > 2.37.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel