All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <olsajiri@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	bpf@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
	Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@chromium.org>,
	Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
	"Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Subject: Re: [PATCHv2 bpf-next 1/6] kprobes: Add new KPROBE_FLAG_ON_FUNC_ENTRY kprobe flag
Date: Mon, 15 Aug 2022 12:10:20 +0200	[thread overview]
Message-ID: <YvobjEIHV3XPSeez@krava> (raw)
In-Reply-To: <YvoYlCz0Ej7t9yDV@worktop.programming.kicks-ass.net>

On Mon, Aug 15, 2022 at 11:57:40AM +0200, Peter Zijlstra wrote:
> On Thu, Aug 11, 2022 at 11:15:21AM +0200, Jiri Olsa wrote:
> > Adding KPROBE_FLAG_ON_FUNC_ENTRY kprobe flag to indicate that
> > attach address is on function entry. This is used in following
> > changes in get_func_ip helper to return correct function address.
> 
> IIRC (and I've not digested patch) the intent was to have func+0 mean
> this. x86-IBT is not the only case where this applies, there are
> multiple architectures where function entry is not +0.

we can have kprobe created by user passing just the address

in this case _kprobe_addr still computes the address's offset
from the symbol but does not store it back to 'struct kprobe'

jirka

  reply	other threads:[~2022-08-15 10:10 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11  9:15 [PATCHv2 bpf-next 0/6] bpf: Fixes for CONFIG_X86_KERNEL_IBT Jiri Olsa
2022-08-11  9:15 ` [PATCHv2 bpf-next 1/6] kprobes: Add new KPROBE_FLAG_ON_FUNC_ENTRY kprobe flag Jiri Olsa
2022-08-15  9:57   ` Peter Zijlstra
2022-08-15 10:10     ` Jiri Olsa [this message]
2022-08-15 12:40       ` Peter Zijlstra
2022-08-16  7:01         ` Jiri Olsa
2022-08-30 15:08   ` Jiri Olsa
2022-09-08  8:26     ` Jiri Olsa
2022-09-08 12:01   ` Masami Hiramatsu
2022-08-11  9:15 ` [PATCHv2 bpf-next 2/6] ftrace: Keep the resolved addr in kallsyms_callback Jiri Olsa
2022-08-15 10:13   ` Peter Zijlstra
2022-08-15 10:30     ` Jiri Olsa
2022-08-15 12:45       ` Peter Zijlstra
2022-08-16  7:06         ` Jiri Olsa
2022-09-08 12:35   ` Masami Hiramatsu
2022-09-08 19:41     ` Jiri Olsa
2022-08-11  9:15 ` [PATCHv2 bpf-next 3/6] bpf: Use given function address for trampoline ip arg Jiri Olsa
2022-08-15 10:18   ` Peter Zijlstra
2022-08-15 10:57     ` Jiri Olsa
2022-08-15 12:51       ` Peter Zijlstra
2022-08-17 13:40         ` Jiri Olsa
2022-08-11  9:15 ` [PATCHv2 bpf-next 4/6] bpf: Adjust kprobe_multi entry_ip for CONFIG_X86_KERNEL_IBT Jiri Olsa
2022-08-11  9:15 ` [PATCHv2 bpf-next 5/6] bpf: Return value in kprobe get_func_ip only for entry address Jiri Olsa
2022-08-11  9:15 ` [PATCHv2 bpf-next 6/6] selftests/bpf: Fix get_func_ip offset test for CONFIG_X86_KERNEL_IBT Jiri Olsa
2022-08-16  3:25   ` Andrii Nakryiko
2022-08-16  7:00     ` Jiri Olsa
2022-08-16 10:18       ` Jiri Olsa
2022-08-16 17:28         ` Andrii Nakryiko
2022-08-16 17:19       ` Andrii Nakryiko
2022-08-16  3:27 ` [PATCHv2 bpf-next 0/6] bpf: Fixes " Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvobjEIHV3XPSeez@krava \
    --to=olsajiri@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@chromium.org \
    --cc=mhiramat@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sdf@google.com \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.