From: Peter Zijlstra <peterz@infradead.org>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
x86@kernel.org, Kostya Serebryany <kcc@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Alexander Potapenko <glider@google.com>,
Taras Madan <tarasmadan@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
"H . J . Lu" <hjl.tools@gmail.com>,
Andi Kleen <ak@linux.intel.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv6 04/11] x86/mm: Handle LAM on context switch
Date: Mon, 15 Aug 2022 15:33:27 +0200 [thread overview]
Message-ID: <YvpLJ3n0u5KmLPwg@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20220815041803.17954-5-kirill.shutemov@linux.intel.com>
On Mon, Aug 15, 2022 at 07:17:56AM +0300, Kirill A. Shutemov wrote:
> @@ -1071,8 +1082,10 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end)
> */
> unsigned long __get_current_cr3_fast(void)
> {
> - unsigned long cr3 = build_cr3(this_cpu_read(cpu_tlbstate.loaded_mm)->pgd,
> - this_cpu_read(cpu_tlbstate.loaded_mm_asid));
> + unsigned long cr3 =
> + build_cr3(this_cpu_read(cpu_tlbstate.loaded_mm)->pgd,
> + this_cpu_read(cpu_tlbstate.loaded_mm_asid),
> + tlbstate_lam_cr3_mask());
My editor auto indents this as:
unsigned long cr3 =
build_cr3(this_cpu_read(cpu_tlbstate.loaded_mm)->pgd,
this_cpu_read(cpu_tlbstate.loaded_mm_asid),
tlbstate_lam_cr3_mask());
which (to me) is *much* clearer.
next prev parent reply other threads:[~2022-08-15 13:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 4:17 [PATCHv6 00/11] Linear Address Masking enabling Kirill A. Shutemov
2022-08-15 4:17 ` [PATCHv6 01/11] x86/mm: Fix CR3_ADDR_MASK Kirill A. Shutemov
2022-08-15 4:17 ` [PATCHv6 02/11] x86: CPUID and CR3/CR4 flags for Linear Address Masking Kirill A. Shutemov
2022-08-15 4:17 ` [PATCHv6 03/11] mm: Pass down mm_struct to untagged_addr() Kirill A. Shutemov
2022-08-15 4:17 ` [PATCHv6 04/11] x86/mm: Handle LAM on context switch Kirill A. Shutemov
2022-08-15 13:33 ` Peter Zijlstra [this message]
2022-08-15 13:42 ` Peter Zijlstra
2022-08-15 17:37 ` Kirill A. Shutemov
2022-08-15 18:02 ` Peter Zijlstra
2022-08-16 0:07 ` [PATCHv6.1 " Kirill A. Shutemov
2022-08-15 4:17 ` [PATCHv6 05/11] x86/uaccess: Provide untagged_addr() and remove tags before address check Kirill A. Shutemov
2022-08-15 4:17 ` [PATCHv6 06/11] x86/mm: Provide arch_prctl() interface for LAM Kirill A. Shutemov
2022-08-15 13:37 ` Peter Zijlstra
2022-08-15 17:52 ` Kirill A. Shutemov
2022-08-16 0:10 ` [PATCHv6.1 " Kirill A. Shutemov
2022-08-22 9:32 ` [PATCHv6 " Alexander Potapenko
2022-08-23 13:16 ` Alexander Potapenko
2022-08-15 4:17 ` [PATCHv6 07/11] x86: Expose untagging mask in /proc/$PID/arch_status Kirill A. Shutemov
2022-08-15 4:18 ` [PATCHv6 08/11] selftests/x86/lam: Add malloc and tag-bits test cases for linear-address masking Kirill A. Shutemov
2022-08-19 5:17 ` Hu, Robert
2022-08-22 5:21 ` Zhang, Weihong
2022-08-15 4:18 ` [PATCHv6 09/11] selftests/x86/lam: Add mmap and SYSCALL " Kirill A. Shutemov
2022-08-19 8:15 ` Hu, Robert
2022-08-22 8:47 ` Zhang, Weihong
2022-08-15 4:18 ` [PATCHv6 10/11] selftests/x86/lam: Add io_uring " Kirill A. Shutemov
2022-08-15 4:18 ` [PATCHv6 11/11] selftests/x86/lam: Add inherit " Kirill A. Shutemov
2022-08-15 13:43 ` [PATCHv6 00/11] Linear Address Masking enabling Peter Zijlstra
2022-08-23 8:58 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvpLJ3n0u5KmLPwg@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=andreyknvl@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=hjl.tools@gmail.com \
--cc=kcc@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=ryabinin.a.a@gmail.com \
--cc=tarasmadan@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.