All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Eddie James <eajames@linux.ibm.com>,
	linux-input@vger.kernel.org, Wolfram Sang <wsa@kernel.org>
Subject: Re: linux-next: Tree for Aug 15 (input/misc/ibm-panel.c)
Date: Mon, 15 Aug 2022 21:16:10 -0700	[thread overview]
Message-ID: <YvsaCjnkucMeyj60@google.com> (raw)
In-Reply-To: <0d836243-6a02-e031-961e-1e334dfd167d@infradead.org>

On Mon, Aug 15, 2022 at 06:26:43PM -0700, Randy Dunlap wrote:
> 
> 
> On 8/14/22 19:29, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20220812:
> > 
> 
> on x86_64:
> 
> when CONFIG_I2C=m and CONFIG_I2C_SLAVE=y:
> 
> ld: drivers/input/misc/ibm-panel.o: in function `ibm_panel_remove':
> ibm-panel.c:(.text+0x16): undefined reference to `i2c_slave_unregister'
> ld: drivers/input/misc/ibm-panel.o: in function `ibm_panel_probe':
> ibm-panel.c:(.text+0x3e3): undefined reference to `i2c_slave_register'
> ld: drivers/input/misc/ibm-panel.o: in function `ibm_panel_driver_init':
> ibm-panel.c:(.init.text+0x18): undefined reference to `i2c_register_driver'
> ld: drivers/input/misc/ibm-panel.o: in function `ibm_panel_driver_exit':
> ibm-panel.c:(.exit.text+0x11): undefined reference to `i2c_del_driver'

It sounds like I need to adjust the depend statement to be:

	depends on I2C && I2C_SLAVE

Thanks.

-- 
Dmitry

  reply	other threads:[~2022-08-16  7:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15  2:29 linux-next: Tree for Aug 15 Stephen Rothwell
2022-08-16  1:26 ` linux-next: Tree for Aug 15 (input/misc/ibm-panel.c) Randy Dunlap
2022-08-16  4:16   ` Dmitry Torokhov [this message]
2022-08-16  6:03     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvsaCjnkucMeyj60@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=eajames@linux.ibm.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.