From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Prashant Malani <pmalani@chromium.org>
Cc: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
bleung@chromium.org, Daisuke Nojiri <dnojiri@chromium.org>,
"Dustin L. Howett" <dustin@howett.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Xiang wangx <wangxiang@cdjrlc.com>
Subject: Re: [PATCH v5 4/7] platform/chrome: cros_typec_switch: Add event check
Date: Tue, 16 Aug 2022 05:11:47 +0000 [thread overview]
Message-ID: <YvsnE55zGVGxGpPv@google.com> (raw)
In-Reply-To: <20220815063555.1384505-5-pmalani@chromium.org>
On Mon, Aug 15, 2022 at 06:34:24AM +0000, Prashant Malani wrote:
> The Chrome EC updates Type-C status events when mux set requests from
To be consistent to the series, I guess you would like to use ChromeOS
instead of Chrome?
> +static int cros_typec_send_clear_event(struct cros_typec_switch_data *sdata, int port_num,
> + u32 events_mask)
> +{
[...]
> + return cros_ec_cmd(sdata->ec, 0, EC_CMD_TYPEC_CONTROL, &req,
> + sizeof(req), NULL, 0);
The line can join to the previous line without exceeding col-100.
next prev parent reply other threads:[~2022-08-16 5:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 6:34 [PATCH v5 0/7] platform/chrome: Type-C switch driver Prashant Malani
2022-08-15 6:34 ` [PATCH v5 1/7] platform/chrome: Add Type-C mux set command definitions Prashant Malani
2022-08-16 5:08 ` Tzung-Bi Shih
2022-08-15 6:34 ` [PATCH v5 2/7] platform/chrome: cros_typec_switch: Add switch driver Prashant Malani
2022-08-16 5:11 ` Tzung-Bi Shih
2022-08-16 21:44 ` Prashant Malani
2022-08-15 6:34 ` [PATCH v5 3/7] platform/chrome: cros_typec_switch: Set EC retimer Prashant Malani
2022-08-16 5:11 ` Tzung-Bi Shih
2022-08-16 21:45 ` Prashant Malani
2022-08-15 6:34 ` [PATCH v5 4/7] platform/chrome: cros_typec_switch: Add event check Prashant Malani
2022-08-16 5:11 ` Tzung-Bi Shih [this message]
2022-08-16 21:45 ` Prashant Malani
2022-08-15 6:34 ` [PATCH v5 5/7] platform/chrome: cros_typec_switch: Register mode switches Prashant Malani
2022-08-16 5:12 ` Tzung-Bi Shih
2022-08-16 21:45 ` Prashant Malani
2022-08-15 6:34 ` [PATCH v5 6/7] platform/chrome: cros_ec_typec: Cleanup switch handle return paths Prashant Malani
2022-08-16 5:12 ` Tzung-Bi Shih
2022-08-15 6:34 ` [PATCH v5 7/7] platform/chrome: cros_ec_typec: Get retimer handle Prashant Malani
2022-08-16 5:13 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvsnE55zGVGxGpPv@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dnojiri@chromium.org \
--cc=dustin@howett.net \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=gustavoars@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=wangxiang@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.