From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
edumazet@google.com, pabeni@redhat.com, hawk@kernel.org,
john.fastabend@gmail.com
Subject: Re: [PATCH bpf-next] xdp: report rx queue index in xdp_frame
Date: Tue, 16 Aug 2022 11:56:02 +0200 [thread overview]
Message-ID: <Yvtpsqv7xv2g7I6N@lore-desk> (raw)
In-Reply-To: <4e717cbe-17a2-dbae-d557-0b29eaa28dae@iogearbox.net>
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
> On 8/16/22 11:45 AM, Lorenzo Bianconi wrote:
> > > Report rx queue index in xdp_frame according to the xdp_buff xdp_rxq_info
> > > pointer. xdp_frame queue_index is currently used in cpumap code to covert
> > > the xdp_frame into a xdp_buff.
> > > xdp_frame size is not increased adding queue_index since an alignment padding
> > > in the structure is used to insert queue_index field.
> > >
> > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > > ---
> > > include/net/xdp.h | 2 ++
> > > kernel/bpf/cpumap.c | 2 +-
> > > 2 files changed, 3 insertions(+), 1 deletion(-)
> >
> >
> > Hi Alexei and Daniel,
> >
> > this patch is marked as 'new, archived' in patchwork.
> > Do I need to rebase and repost it?
>
> Yes, please rebase and resend. Perhaps also improve the commit description
> a bit in terms of what it fixes, it's a bit terse to the reader above on
> what effect it has.
ack thx, will do.
Regards,
Lorenzo
>
> Thanks,
> Daniel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-08-16 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 10:56 [PATCH bpf-next] xdp: report rx queue index in xdp_frame Lorenzo Bianconi
2022-08-16 9:45 ` Lorenzo Bianconi
2022-08-16 9:54 ` Daniel Borkmann
2022-08-16 9:56 ` Lorenzo Bianconi [this message]
2022-08-17 11:17 ` Jesper Dangaard Brouer
2022-08-17 12:35 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yvtpsqv7xv2g7I6N@lore-desk \
--to=lorenzo@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.