From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36111C25B0E for ; Tue, 16 Aug 2022 11:57:17 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4M6V4r2Ktcz3bl0 for ; Tue, 16 Aug 2022 21:57:16 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=v8PP2Y7z; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=145.40.68.75; helo=ams.source.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=v8PP2Y7z; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4M6V4C0V5Hz3bbQ for ; Tue, 16 Aug 2022 21:56:41 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8D263B816AA; Tue, 16 Aug 2022 11:56:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AACE5C433D6; Tue, 16 Aug 2022 11:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660650995; bh=FVUSKZvyxeYHla7DAI1S7uQ9b45W1lFMmWt54ll5JlA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v8PP2Y7zNU+FVQizPga9MODb0WFzHKVad+1VohxTjTDc+95kRo6+FlTlwZiET+gOj rI3kpk1WipL/kLv/6gv0XXNK+NrFFcDJFwt2vngBa+mVLRX7m5i+DafP+blpINyKqM iF0Qnt+XnOywNTiwwOBU918gkxWz6UVgzOTVIBMA= Date: Tue, 16 Aug 2022 13:56:32 +0200 From: Greg Kroah-Hartman To: Alexander Atanasov Subject: Re: [PATCH v2 1/4] Make place for common balloon code Message-ID: References: <20220816094117.3144881-1-alexander.atanasov@virtuozzo.com> <20220816094117.3144881-2-alexander.atanasov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , "Michael S. Tsirkin" , VMware PV-Drivers Reviewers , Jason Wang , David Hildenbrand , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, Nadav Amit , Nicholas Piggin , kernel@openvz.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote: > Hello, > > On 16.08.22 12:49, Greg Kroah-Hartman wrote: > > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote: > > > > rename include/linux/{balloon_compaction.h => balloon_common.h} (99%) > > > > Why rename the .h file? It still handles the "balloon compaction" > > logic. > > File contains code that is common to balloon drivers, > compaction is only part of it. Series add more code to it. > Since it was suggested to use it for such common code. > I find that common becomes a better name for it so the rename. > I can drop the rename easy on next iteration if you suggest to. "balloon_common.h" is very vague, you should only need one balloon.h file in the include/linux/ directory, right, so of course it is "common" :) thanks, greg "naming is hard" k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6376C25B0E for ; Tue, 16 Aug 2022 11:56:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2775C827CA; Tue, 16 Aug 2022 11:56:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2775C827CA Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=v8PP2Y7z X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wIx9D02fYpRC; Tue, 16 Aug 2022 11:56:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9F4B9827A9; Tue, 16 Aug 2022 11:56:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9F4B9827A9 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7332BC0032; Tue, 16 Aug 2022 11:56:41 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id B2E40C002D for ; Tue, 16 Aug 2022 11:56:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7D4A9827A9 for ; Tue, 16 Aug 2022 11:56:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7D4A9827A9 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eX-8xHA6LNKT for ; Tue, 16 Aug 2022 11:56:40 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C47EE827CA Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id C47EE827CA for ; Tue, 16 Aug 2022 11:56:39 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8D263B816AA; Tue, 16 Aug 2022 11:56:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AACE5C433D6; Tue, 16 Aug 2022 11:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660650995; bh=FVUSKZvyxeYHla7DAI1S7uQ9b45W1lFMmWt54ll5JlA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v8PP2Y7zNU+FVQizPga9MODb0WFzHKVad+1VohxTjTDc+95kRo6+FlTlwZiET+gOj rI3kpk1WipL/kLv/6gv0XXNK+NrFFcDJFwt2vngBa+mVLRX7m5i+DafP+blpINyKqM iF0Qnt+XnOywNTiwwOBU918gkxWz6UVgzOTVIBMA= Date: Tue, 16 Aug 2022 13:56:32 +0200 From: Greg Kroah-Hartman To: Alexander Atanasov Subject: Re: [PATCH v2 1/4] Make place for common balloon code Message-ID: References: <20220816094117.3144881-1-alexander.atanasov@virtuozzo.com> <20220816094117.3144881-2-alexander.atanasov@virtuozzo.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Arnd Bergmann , "Michael S. Tsirkin" , VMware PV-Drivers Reviewers , Michael Ellerman , linux-kernel@vger.kernel.org, Christophe Leroy , virtualization@lists.linux-foundation.org, linux-mm@kvack.org, Nadav Amit , Nicholas Piggin , kernel@openvz.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote: > Hello, > > On 16.08.22 12:49, Greg Kroah-Hartman wrote: > > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote: > > > > rename include/linux/{balloon_compaction.h => balloon_common.h} (99%) > > > > Why rename the .h file? It still handles the "balloon compaction" > > logic. > > File contains code that is common to balloon drivers, > compaction is only part of it. Series add more code to it. > Since it was suggested to use it for such common code. > I find that common becomes a better name for it so the rename. > I can drop the rename easy on next iteration if you suggest to. "balloon_common.h" is very vague, you should only need one balloon.h file in the include/linux/ directory, right, so of course it is "common" :) thanks, greg "naming is hard" k-h _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FE6CC25B0E for ; Tue, 16 Aug 2022 11:56:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85AD28D0001; Tue, 16 Aug 2022 07:56:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E3786B0075; Tue, 16 Aug 2022 07:56:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65C9D8D0001; Tue, 16 Aug 2022 07:56:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 53C996B0073 for ; Tue, 16 Aug 2022 07:56:39 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F2081160EE6 for ; Tue, 16 Aug 2022 11:56:38 +0000 (UTC) X-FDA: 79805303676.31.B74B11B Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf27.hostedemail.com (Postfix) with ESMTP id 60EF4401CB for ; Tue, 16 Aug 2022 11:56:38 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8D263B816AA; Tue, 16 Aug 2022 11:56:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AACE5C433D6; Tue, 16 Aug 2022 11:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660650995; bh=FVUSKZvyxeYHla7DAI1S7uQ9b45W1lFMmWt54ll5JlA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v8PP2Y7zNU+FVQizPga9MODb0WFzHKVad+1VohxTjTDc+95kRo6+FlTlwZiET+gOj rI3kpk1WipL/kLv/6gv0XXNK+NrFFcDJFwt2vngBa+mVLRX7m5i+DafP+blpINyKqM iF0Qnt+XnOywNTiwwOBU918gkxWz6UVgzOTVIBMA= Date: Tue, 16 Aug 2022 13:56:32 +0200 From: Greg Kroah-Hartman To: Alexander Atanasov Cc: Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nadav Amit , VMware PV-Drivers Reviewers , Arnd Bergmann , "Michael S. Tsirkin" , David Hildenbrand , Jason Wang , Andrew Morton , kernel@openvz.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH v2 1/4] Make place for common balloon code Message-ID: References: <20220816094117.3144881-1-alexander.atanasov@virtuozzo.com> <20220816094117.3144881-2-alexander.atanasov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660650998; a=rsa-sha256; cv=none; b=HyXe87+nrlaQQCruffCO5f8gTN9QJ/dPGKwFDHL7tQmaRFzfPf0jP9ozZCdcOsV3R5OS4m PfTjLrOo0kwcjUC2MyFpz43AIltHuHNjlI33XK9i2O5hZVhPxzPqDMg0d4kPsBtHX4fHPH b4EZhj5rixN5t5EwB4ab9RUQSPqU/qk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=v8PP2Y7z; spf=pass (imf27.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660650998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jtTDOXQ08RJpQUt5MjfYCIbRo0dS2U7puA2Xq0RIGz4=; b=y2PS7331+TA+rOIX2j40CILJjuY8nRanJvy2xxk39pkXOYHEROKfG29zhvcb7p8D2eG1Qe 1DLMjh09Htg0J9caN6BMyKv9N5IjFVzZ/Prz8HPct5f+01mc9dbPNKVDdcHuBtAfrilEiV kJdPFLrr9JOBAvCTwLIeo4rl4eu+1eM= X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 60EF4401CB X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=v8PP2Y7z; spf=pass (imf27.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Stat-Signature: zfcha9m1t6efjod54o4fokz56omx7ot1 X-HE-Tag: 1660650998-864595 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote: > Hello, > > On 16.08.22 12:49, Greg Kroah-Hartman wrote: > > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote: > > > > rename include/linux/{balloon_compaction.h => balloon_common.h} (99%) > > > > Why rename the .h file? It still handles the "balloon compaction" > > logic. > > File contains code that is common to balloon drivers, > compaction is only part of it. Series add more code to it. > Since it was suggested to use it for such common code. > I find that common becomes a better name for it so the rename. > I can drop the rename easy on next iteration if you suggest to. "balloon_common.h" is very vague, you should only need one balloon.h file in the include/linux/ directory, right, so of course it is "common" :) thanks, greg "naming is hard" k-h