From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] tst_rod: Fail on directory change commands
Date: Tue, 16 Aug 2022 14:51:46 +0200 [thread overview]
Message-ID: <YvuS4nQkzi9oJzi/@pevik> (raw)
In-Reply-To: <Yuk66ELT2ugQFAlb@yuki>
> Hi!
> > Beware that this patch will cause a lot of broken shell tests to fail.
> > Another patchset fixing the incorrect ROD usage in shell tests is needed
> > before merging this patch.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
I also wonder if we should care for pushd/popd which are bashism and should not
be used in LTP tests which use new shell API.
So far they are used in testcases/realtime/run.sh testscripts/test_realtime.sh,
which does not use shell API (and realtime should be removed after porting
anything useful to rt-tests).
> The only broken test I've found is du01.sh that does
> "ROD_SILENT cd basedir" are there actually any other tests that does so?
Indeed it looks just du01.sh.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-08-16 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 11:42 [LTP] [PATCH 1/2] tst_rod: Use args[0] as the command name Martin Doucha
2022-07-28 11:42 ` [LTP] [PATCH 2/2] tst_rod: Fail on directory change commands Martin Doucha
2022-07-28 11:49 ` Martin Doucha
2022-08-02 14:55 ` Cyril Hrubis
2022-08-16 12:51 ` Petr Vorel [this message]
2022-08-02 14:53 ` Cyril Hrubis
2022-08-31 12:38 ` Cyril Hrubis
2022-08-02 14:49 ` [LTP] [PATCH 1/2] tst_rod: Use args[0] as the command name Cyril Hrubis
2022-08-16 12:40 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvuS4nQkzi9oJzi/@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.