Re: [PATCH v4] perf inject: Add a command line option to specify build ids.

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Mon, Aug 15, 2022 at 10:11:41PM -0700, Namhyung Kim escreveu:
> Hello,
> 
> On Mon, Aug 15, 2022 at 3:59 PM Raul Silvera <rsilvera@google.com> wrote:
> >
> > This commit adds the option --known-build-ids to perf inject.
> > It allows the user to explicitly specify the build id for a given
> > path, instead of retrieving it from the current system. This is
> > useful in cases where a perf.data file is processed on a different
> > system from where it was collected, or if some of the binaries are
> > no longer available.
> >
> > The build ids and paths are specified in pairs in the command line.
> > Using the file:// specifier, build ids can be loaded from a file
> > directly generated by perf buildid-list. This is convenient to copy
> > build ids from one perf.data file to another.
> >
> > ** Example: In this example we use perf record to create two
> > perf.data files, one with build ids and another without, and use
> > perf buildid-list and perf inject to copy the build ids from the
> > first file to the second.
> >
> >  $ perf record ls /tmp
> >  $ perf record --no-buildid -o perf.data.no-buildid ls /tmp
> >  $ perf buildid-list > build-ids.txt
> >  $ perf inject -b --known-build-ids='file://build-ids.txt' \
> >         -i perf.data.no-buildid -o perf.data.buildid
> >
> > Signed-off-by: Raul Silvera <rsilvera@google.com>
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applied to perf/core.

- Arnaldo