Re: [Buildroot] [PATCH 0/2] Add support for FDPIC binaries on ARM

[Ben Wolsieffer <ben.wolsieffer@hefring.com>]

On Sun, Aug 14, 2022 at 11:55:37PM +0200, Arnout Vandecappelle wrote:
> > 
> > I've been playing around with NPTL and FDPIC and it doesn't quite work
> > perfectly out of the box. Static libraries (linked into a dynamic
> > executable) crash when attempting to use TLS. In addition, the reason
> > static libraries are even being used is because libtool doesn't recognize
> > the target name and therefore thinks it can't build shared libaries.
> > 
> > There was a patch [1] submitted a few years ago to add the target to
> > libtool, but it looks like it was ignored. Unfortunately, we can't just
> > apply it in Buildroot, unless we want to run autoreconf on every
> > package. I'm working around this locally with a hacky hook to patch
> > configure scripts, but I'm not sure it is appropriate to upstream.
> 
>  This problem exists for a number of architectures. For that reason, we have
> a workaround: the LIBTOOL_PATCH_HOOK [1]. For any autotools package, we
> search for ltmain.sh files in the source, parse out the libtool version from
> it, and apply the appropriate patch from support/libtool/
> 
>  In other words, the solution is to extend the patches in support/libtool/
> with the missing architecture.
> 

In this case, the relevant file is libtool.m4, and this file gets
expanded into configure. Therefore, we either need a patch for configure
for each libtool version (like LIBTOOL_PATCH_HOOK), or use sed to patch
any matches against "linux*". I've been using the sed solution, which is
far simpler, but I'm not sure it is clean enough to be included upstream.

Ben

> 
>  Regards,
>  Arnout
> 
> [1] https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/pkg-autotools.mk#L60
> 
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot