From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Denis V. Lunev" <den@openvz.org>, "Peter Xu" <peterx@redhat.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Richard W.M. Jones" <rjones@redhat.com>,
qemu-block@nongnu.org, "John Snow" <jsnow@redhat.com>,
integration@gluster.org,
"Vladimir Sementsov-Ogievskiy" <v.sementsov-og@mail.ru>,
"David Hildenbrand" <david@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Raphael Norwitz" <raphael.norwitz@nutanix.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Fam Zheng" <fam@euphon.net>,
sgarzare@redhat.com, "Alberto Faria" <afaria@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Wen Congyang" <wencongyang2@huawei.com>,
"Eric Blake" <eblake@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Jeff Cody" <codyprime@gmail.com>,
"Xie Changlong" <xiechanglong.d@gmail.com>
Subject: Re: [RFC v4 00/11] blkio: add libblkio BlockDriver
Date: Wed, 31 Aug 2022 15:44:10 -0400 [thread overview]
Message-ID: <Yw+6CrmP7CKk1PZy@fedora> (raw)
In-Reply-To: <15ad1a46-00e5-ccc8-1c7e-f6061bc68c0c@yandex-team.ru>
[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]
On Tue, Aug 23, 2022 at 08:31:03PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 8/23/22 01:23, Stefan Hajnoczi wrote:
> > The remainder of the patch series reworks the existing QEMU bdrv_register_buf()
> > API so virtio-blk emulation efficiently map guest RAM for libblkio - some
> > libblkio drivers require that I/O buffer memory is pre-registered (think VFIO,
> > vhost, etc).
>
> Hi!
>
> So patches 01-11 are for performance optimization? Don't you have some performance measurements for it?
Hi Vladimir,
I ran the patches against qemu-storage-daemon's vhost-user-blk export
with iodepth=1 bs=512 to see the per-request overhead due to bounce
buffer allocation/mapping:
Name IOPS Error
bounce-buf 4373.81 ± 0.01%
registered-buf 13062.80 ± 0.67%
The BDRV_REQ_REGISTERED_BUF optimization version is about 3x faster.
Note that IOPS is low because the vhost-user-blk vq is not passed
through to the guest yet (Stefano is working on this). The guest is
also using interrupts, not polling (recent Linux virtio_blk.ko drivers
support poll queues).
I'll also include performance results in the next revision of the patch
series.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-08-31 19:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 22:23 [RFC v4 00/11] blkio: add libblkio BlockDriver Stefan Hajnoczi
2022-08-22 22:23 ` [RFC v4 01/11] blkio: add libblkio block driver Stefan Hajnoczi
2022-08-30 7:30 ` Markus Armbruster
2022-08-30 20:18 ` Stefan Hajnoczi
2022-08-22 22:23 ` [RFC v4 02/11] numa: call ->ram_block_removed() in ram_block_notifer_remove() Stefan Hajnoczi
2022-08-22 22:23 ` [RFC v4 03/11] block: pass size to bdrv_unregister_buf() Stefan Hajnoczi
2022-08-22 22:23 ` [RFC v4 04/11] block: use BdrvRequestFlags type for supported flag fields Stefan Hajnoczi
2022-08-22 22:23 ` [RFC v4 05/11] block: add BDRV_REQ_REGISTERED_BUF request flag Stefan Hajnoczi
2022-08-22 22:23 ` [RFC v4 06/11] block: return errors from bdrv_register_buf() Stefan Hajnoczi
2022-08-22 22:23 ` [RFC v4 07/11] block: add BlockRAMRegistrar Stefan Hajnoczi
2022-08-22 22:23 ` [RFC v4 08/11] exec/cpu-common: add qemu_ram_get_fd() Stefan Hajnoczi
2022-08-22 22:24 ` [RFC v4 09/11] stubs: add qemu_ram_block_from_host() and qemu_ram_get_fd() Stefan Hajnoczi
2022-08-22 22:24 ` [RFC v4 10/11] blkio: implement BDRV_REQ_REGISTERED_BUF optimization Stefan Hajnoczi
2022-08-22 22:24 ` [RFC v4 11/11] virtio-blk: use BDRV_REQ_REGISTERED_BUF optimization hint Stefan Hajnoczi
2022-08-23 8:01 ` David Hildenbrand
2022-08-23 19:22 ` Stefan Hajnoczi
2022-08-25 7:43 ` David Hildenbrand
2022-08-30 20:16 ` Stefan Hajnoczi
2022-09-02 8:06 ` David Hildenbrand
2022-09-05 20:50 ` Stefan Hajnoczi
2022-08-23 17:31 ` [RFC v4 00/11] blkio: add libblkio BlockDriver Vladimir Sementsov-Ogievskiy
2022-08-23 20:35 ` Stefan Hajnoczi
2022-08-31 19:44 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw+6CrmP7CKk1PZy@fedora \
--to=stefanha@redhat.com \
--cc=afaria@redhat.com \
--cc=armbru@redhat.com \
--cc=codyprime@gmail.com \
--cc=david@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=integration@gluster.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=richard.henderson@linaro.org \
--cc=rjones@redhat.com \
--cc=sgarzare@redhat.com \
--cc=thuth@redhat.com \
--cc=v.sementsov-og@mail.ru \
--cc=vsementsov@yandex-team.ru \
--cc=wangyanan55@huawei.com \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.