All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nate Yocom <nate@yocom.org>
To: Bastien Nocera <hadess@hadess.net>, dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	benjamin.tissoires@redhat.com
Subject: Re: [PATCH v5 2/4] Input: joystick: xpad: Add ABS_PROFILE axis value to uapi
Date: Mon, 29 Aug 2022 12:07:58 -0700	[thread overview]
Message-ID: <Yw0OjoVzKV3QOYah@ghaven-kernel> (raw)
In-Reply-To: <3e48ef8d13337ce1c3ec68baffc612fde4740b0e.camel@hadess.net>

On Sat, Aug 27, 2022 at 12:40:46PM +0200, Bastien Nocera wrote:
> On Thu, 2022-08-25 at 15:24 -0700, Nate Yocom wrote:
> > Add an ABS_PROFILE axis for input devices which need it, e.g. X-Box
> > Adaptive Controller and X-Box Elite 2.
> > ---
> >  include/uapi/linux/input-event-codes.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/uapi/linux/input-event-codes.h
> > b/include/uapi/linux/input-event-codes.h
> > index dff8e7f17074..7ad931a32970 100644
> > --- a/include/uapi/linux/input-event-codes.h
> > +++ b/include/uapi/linux/input-event-codes.h
> > @@ -862,6 +862,7 @@
> >  #define ABS_TOOL_WIDTH         0x1c
> >  
> >  #define ABS_VOLUME             0x20
> > +#define ABS_PROFILE            0x21
> >  
> >  #define ABS_MISC               0x28
> >  
> 
> 
> You probably also want to add it to the absolutes array in
> drivers/hid/hid-debug.c.

doh, roger.

> Again, you might want to wait for confirmation from Dmitry that this is
> the right way to do this for the profiles.

Makes sense.  Dmitry?


  reply	other threads:[~2022-08-29 19:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25 22:24 [PATCH v5 0/4] Input: joystick: xpad: Add X-Box Adaptive Controller support Nate Yocom
2022-08-25 22:24 ` [PATCH v5 1/4] " Nate Yocom
2022-08-25 22:24 ` [PATCH v5 2/4] Input: joystick: xpad: Add ABS_PROFILE axis value to uapi Nate Yocom
2022-08-27 10:40   ` Bastien Nocera
2022-08-29 19:07     ` Nate Yocom [this message]
2022-09-07 15:41       ` Bastien Nocera
2022-09-08  5:36         ` Dmitry Torokhov
2022-09-08  6:51           ` Benjamin Tissoires
2022-09-09  1:25             ` Peter Hutterer
2022-09-08 17:36           ` Nate Yocom
2022-08-25 22:24 ` [PATCH v5 3/4] Input: joystick: xpad: Add X-Box Adaptive Controller Profile button Nate Yocom
2022-08-25 22:24 ` [PATCH v5 4/4] Input: joystick: xpad: Add X-Box Adaptive Controller XBox button Nate Yocom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yw0OjoVzKV3QOYah@ghaven-kernel \
    --to=nate@yocom.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hadess@hadess.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.