All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH 1/2] lib/test_printf.c: Add ip6 tests
Date: Tue, 30 Aug 2022 10:47:21 +0900	[thread overview]
Message-ID: <Yw1sKTOEs1Nrdb2S@google.com> (raw)
In-Reply-To: <20220830003119.1793219-2-kent.overstreet@linux.dev>

On (22/08/29 20:31), Kent Overstreet wrote:
> diff --git a/lib/test_printf.c b/lib/test_printf.c
> index 4bd15a593f..6a56dbf076 100644
> --- a/lib/test_printf.c
> +++ b/lib/test_printf.c
> @@ -18,6 +18,7 @@
>  #include <linux/dcache.h>
>  #include <linux/socket.h>
>  #include <linux/in.h>
> +#include <linux/in6.h>
>  
>  #include <linux/gfp.h>
>  #include <linux/mm.h>
> @@ -61,6 +62,9 @@ do_test(int bufsize, const char *expect, int elen,
>  		pr_warn("vsnprintf(buf, %d, \"%s\", ...) returned %d, expected %d\n",
>  			bufsize, fmt, ret, elen);
>  		return 1;
> +		pr_warn("vsnprintf(buf, %d, \"%s\", ...) returned %d, expected %d (%s != %s)\n",
> +			bufsize, fmt, ret, elen, test_buffer, expect);
> +		return 1;
>  	}

I assume you intended to replace first pr_warn() with the second one?

  reply	other threads:[~2022-08-30  1:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30  0:31 ip6, escaped_string tests Kent Overstreet
2022-08-30  0:31 ` [PATCH 1/2] lib/test_printf.c: Add ip6 tests Kent Overstreet
2022-08-30  1:47   ` Sergey Senozhatsky [this message]
2022-08-30  7:32     ` Rasmus Villemoes
2022-08-30 16:34       ` Kent Overstreet
2022-08-30  0:31 ` [PATCH 2/2] lib/test_printf.c: Add escaped string tests Kent Overstreet
2022-08-30  7:51   ` Rasmus Villemoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yw1sKTOEs1Nrdb2S@google.com \
    --to=senozhatsky@chromium.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.