From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Tue, 30 Aug 2022 04:27:04 +0000 Subject: [PATCH v5 7/7] KVM: selftests: Add ucall pool based implementation In-Reply-To: <20220829163627.qbafyl4qz5cxxue5@kamzik> References: <20220825232522.3997340-1-seanjc@google.com> <20220825232522.3997340-8-seanjc@google.com> <20220829163627.qbafyl4qz5cxxue5@kamzik> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Aug 29, 2022, Andrew Jones wrote: > On Thu, Aug 25, 2022 at 11:25:22PM +0000, Sean Christopherson wrote: > > +static struct ucall *ucall_alloc(void) > > +{ > > + struct ucall *uc; > > + int i; > > + > > + GUEST_ASSERT(ucall_pool && ucall_pool->in_use); > > ucall_pool->in_use will never be null. > > > + > > + for (i = 0; i < KVM_MAX_VCPUS; ++i) { > > + if (!atomic_test_and_set_bit(i, ucall_pool->in_use)) { > > + uc = &ucall_pool->ucalls[i]; > > + memset(uc->args, 0, sizeof(uc->args)); > > + return uc; > > + } > > + } > > nit: blank line Got 'em. Thanks for the reviews, much appreciated! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94EF1ECAAD1 for ; Tue, 30 Aug 2022 04:27:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EBDDA4B916; Tue, 30 Aug 2022 00:27:13 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z8C3GGkyoinZ; Tue, 30 Aug 2022 00:27:12 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D3BDD4B907; Tue, 30 Aug 2022 00:27:12 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6696C4B8FD for ; Tue, 30 Aug 2022 00:27:11 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nx3kjzV+NImY for ; Tue, 30 Aug 2022 00:27:10 -0400 (EDT) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 168374B8D6 for ; Tue, 30 Aug 2022 00:27:10 -0400 (EDT) Received: by mail-pj1-f50.google.com with SMTP id n65-20020a17090a5ac700b001fbb4fad865so10651326pji.1 for ; Mon, 29 Aug 2022 21:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=tveQCNdrcl8zzZ90FYJSAQp/xoPHwNHO3f5B145IGDY=; b=jz5ryMUneNPtN7GgAbdob+y42sDrVxRuBlqA3QA9oeD1pieZtFXjP021CLo/r+B8bv MYbJ7ecSXA82j8N0LGSRSWGBEUhc3gl753fZP/eq9G6cgLilZiGUBe9U0WkOOEPuzjZF 1K3HPtO4P5guX5tEHivGDwt+5tsoSrBpSv2YMAohOLencXK9GT5KAEjxZPzgLhtXs8hu gQg912iU7/NlDTQXrg/CEmP/aR5c+40JbNsB0FzAY+4nR+pg565IYviyzm5c/PrLrHLt 42P316IO38WW173exoDa9F/uBYTC0uVc+zDhMVmIYiRyS2CFUFzmi4Iwz9ul83sq02Yi qJsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=tveQCNdrcl8zzZ90FYJSAQp/xoPHwNHO3f5B145IGDY=; b=luylcrp9i8dh03DqVG/TQHCPyYUR3dUh284uNZ705/uZuuxyaSonYU6ejIaoXS05NG eiejwjRFFjQUd1frEdBrFSYtWolp9yWenEobLTyTsDgmZSZzg+70CvRq2mY/3U4gNTGK yHa9TrrwUM2AqS8Jq+x5FjxbfDTVGwihwgf24Tj+fzkf7h9wjWOkCZ7fU4b1VidBbzTY jT1V031gBtn7kxT4Wb1aUvBIbTJldItzKIHN51p3LlmoobGI3OPmg0PYP7rpEUxQZZjH hHgjOBNxHlCZR6PIlC3tpPt2Mh9IrR1EH9tif/RXfK7by4427VIGxEqfIlgLJG7z3rw3 k/Tw== X-Gm-Message-State: ACgBeo0U4nXGTXHUynkqEK0BNudH1ZAZ975qKrc6mUI1nO5KkYAiTxBP W8hgyFUVqvsU1uF4AZiS3ExUKA== X-Google-Smtp-Source: AA6agR6j3CrMGk4TPMCPwBvaE51o8QHOWIUKsxAkxuonGlXOsZKabqIh/v6aYfhgn/tTEr+AwX2Jlw== X-Received: by 2002:a17:902:efca:b0:174:c901:aa8d with SMTP id ja10-20020a170902efca00b00174c901aa8dmr7736459plb.164.1661833628777; Mon, 29 Aug 2022 21:27:08 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id nm21-20020a17090b19d500b001eee8998f2esm7541792pjb.17.2022.08.29.21.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 21:27:08 -0700 (PDT) Date: Tue, 30 Aug 2022 04:27:04 +0000 From: Sean Christopherson To: Andrew Jones Subject: Re: [PATCH v5 7/7] KVM: selftests: Add ucall pool based implementation Message-ID: References: <20220825232522.3997340-1-seanjc@google.com> <20220825232522.3997340-8-seanjc@google.com> <20220829163627.qbafyl4qz5cxxue5@kamzik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220829163627.qbafyl4qz5cxxue5@kamzik> Cc: kvm@vger.kernel.org, David Hildenbrand , Tom Rix , Paul Walmsley , llvm@lists.linux.dev, Colton Lewis , linux-riscv@lists.infradead.org, Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, Janosch Frank , Marc Zyngier , Peter Gonda , Christian Borntraeger , Albert Ou , Nathan Chancellor , Atish Patra , linux-arm-kernel@lists.infradead.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Palmer Dabbelt , kvm-riscv@lists.infradead.org, Paolo Bonzini X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, Aug 29, 2022, Andrew Jones wrote: > On Thu, Aug 25, 2022 at 11:25:22PM +0000, Sean Christopherson wrote: > > +static struct ucall *ucall_alloc(void) > > +{ > > + struct ucall *uc; > > + int i; > > + > > + GUEST_ASSERT(ucall_pool && ucall_pool->in_use); > > ucall_pool->in_use will never be null. > > > + > > + for (i = 0; i < KVM_MAX_VCPUS; ++i) { > > + if (!atomic_test_and_set_bit(i, ucall_pool->in_use)) { > > + uc = &ucall_pool->ucalls[i]; > > + memset(uc->args, 0, sizeof(uc->args)); > > + return uc; > > + } > > + } > > nit: blank line Got 'em. Thanks for the reviews, much appreciated! _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F17EFECAAD1 for ; Tue, 30 Aug 2022 04:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NeAjiImhTYkzEtPNRS9DIuSF8zR8wTHZ39bYuvPB1PE=; b=mP/H5gWG5VUCkc MoZhf7O+1KihJc0jqhwIwqhrpnD+EPdtOy7+IOzYr7rc2GQJpLAvAaikBxdp9WOSNNonDWzHCEaaj DyiBL7crsTXvN/sjfCAQ2NAcws/ba18+bVlpijv61DfxA3M0pmH71JStafO8oHmYMk10XzrfalXNL go+4C4fs60ttIFGB2ZhfmNFiMjArnUMsrm/gS6NoJ4rNuDFc7o+OexWZocG5W9NpqZbHGQ9YhXPB5 xk4OC9PGY95/q6Hpn4qjCVe9hmazqFP7TNwOlLb2lXpnmrxrLPsIV5yzHGF34q2WHghvCkwM1ICht BtQLQcgksLt5iU3Ee51A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSsqH-00Dzkv-1M; Tue, 30 Aug 2022 04:27:13 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSsqD-00Dzif-Vg for linux-riscv@lists.infradead.org; Tue, 30 Aug 2022 04:27:11 +0000 Received: by mail-pj1-x1030.google.com with SMTP id n65-20020a17090a5ac700b001fbb4fad865so10651321pji.1 for ; Mon, 29 Aug 2022 21:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=tveQCNdrcl8zzZ90FYJSAQp/xoPHwNHO3f5B145IGDY=; b=jz5ryMUneNPtN7GgAbdob+y42sDrVxRuBlqA3QA9oeD1pieZtFXjP021CLo/r+B8bv MYbJ7ecSXA82j8N0LGSRSWGBEUhc3gl753fZP/eq9G6cgLilZiGUBe9U0WkOOEPuzjZF 1K3HPtO4P5guX5tEHivGDwt+5tsoSrBpSv2YMAohOLencXK9GT5KAEjxZPzgLhtXs8hu gQg912iU7/NlDTQXrg/CEmP/aR5c+40JbNsB0FzAY+4nR+pg565IYviyzm5c/PrLrHLt 42P316IO38WW173exoDa9F/uBYTC0uVc+zDhMVmIYiRyS2CFUFzmi4Iwz9ul83sq02Yi qJsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=tveQCNdrcl8zzZ90FYJSAQp/xoPHwNHO3f5B145IGDY=; b=v4XzsZ5wcw+9PSoATksfxUniOGmCdpgMiGs/+0zPJMscbxsLSUihx5fU1NHO1FmmxV vp4WdiSFSWIoX5pd+hliaLeRP/Tbi4ga4q/QKlGx+wuIFaLotwQ0U4iTivxgqnyDJbRZ YZDrRlhRO2GJPlo9f0YiV6O5lMuAojwt8XEIR3v2c4b5n7OVpBPEPi5z39P9iSy/mIe0 SDzNtx/ZTrdqoFcdhCGV4Q2sMHRbw2yerlhgEvDfplZrJZhh4Y1n/CN/6V9sHdQp8yEn GJz389e1Z5oLtnzuUurT+JWcCc48Rmmy4YACmt6aSSdvRDo7zHgzTF0DL5wAbzfX+uhi EYCg== X-Gm-Message-State: ACgBeo2tPapLLPfBAptggw3QRT8tepO452Mz9KSm7uZ4QKQKl0lMfvrL 56Sg7gCkedmjPvVIQe02w7DCew== X-Google-Smtp-Source: AA6agR6j3CrMGk4TPMCPwBvaE51o8QHOWIUKsxAkxuonGlXOsZKabqIh/v6aYfhgn/tTEr+AwX2Jlw== X-Received: by 2002:a17:902:efca:b0:174:c901:aa8d with SMTP id ja10-20020a170902efca00b00174c901aa8dmr7736459plb.164.1661833628777; Mon, 29 Aug 2022 21:27:08 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id nm21-20020a17090b19d500b001eee8998f2esm7541792pjb.17.2022.08.29.21.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 21:27:08 -0700 (PDT) Date: Tue, 30 Aug 2022 04:27:04 +0000 From: Sean Christopherson To: Andrew Jones Cc: Paolo Bonzini , Marc Zyngier , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Nathan Chancellor , Nick Desaulniers , James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Atish Patra , David Hildenbrand , Tom Rix , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, Colton Lewis , Peter Gonda Subject: Re: [PATCH v5 7/7] KVM: selftests: Add ucall pool based implementation Message-ID: References: <20220825232522.3997340-1-seanjc@google.com> <20220825232522.3997340-8-seanjc@google.com> <20220829163627.qbafyl4qz5cxxue5@kamzik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220829163627.qbafyl4qz5cxxue5@kamzik> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220829_212710_089535_A1EE779E X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Aug 29, 2022, Andrew Jones wrote: > On Thu, Aug 25, 2022 at 11:25:22PM +0000, Sean Christopherson wrote: > > +static struct ucall *ucall_alloc(void) > > +{ > > + struct ucall *uc; > > + int i; > > + > > + GUEST_ASSERT(ucall_pool && ucall_pool->in_use); > > ucall_pool->in_use will never be null. > > > + > > + for (i = 0; i < KVM_MAX_VCPUS; ++i) { > > + if (!atomic_test_and_set_bit(i, ucall_pool->in_use)) { > > + uc = &ucall_pool->ucalls[i]; > > + memset(uc->args, 0, sizeof(uc->args)); > > + return uc; > > + } > > + } > > nit: blank line Got 'em. Thanks for the reviews, much appreciated! _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8630836A for ; Tue, 30 Aug 2022 04:27:09 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id n8-20020a17090a73c800b001fd832b54f6so8013988pjk.0 for ; Mon, 29 Aug 2022 21:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=tveQCNdrcl8zzZ90FYJSAQp/xoPHwNHO3f5B145IGDY=; b=jz5ryMUneNPtN7GgAbdob+y42sDrVxRuBlqA3QA9oeD1pieZtFXjP021CLo/r+B8bv MYbJ7ecSXA82j8N0LGSRSWGBEUhc3gl753fZP/eq9G6cgLilZiGUBe9U0WkOOEPuzjZF 1K3HPtO4P5guX5tEHivGDwt+5tsoSrBpSv2YMAohOLencXK9GT5KAEjxZPzgLhtXs8hu gQg912iU7/NlDTQXrg/CEmP/aR5c+40JbNsB0FzAY+4nR+pg565IYviyzm5c/PrLrHLt 42P316IO38WW173exoDa9F/uBYTC0uVc+zDhMVmIYiRyS2CFUFzmi4Iwz9ul83sq02Yi qJsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=tveQCNdrcl8zzZ90FYJSAQp/xoPHwNHO3f5B145IGDY=; b=IgSt3F6wF1SAoTn3C73Qi+W5PESkTzAPpuqTxGtlJNciiUijrFrbE2sY9PeHFryY6S QN7Fpsl75rAlKb4/asIr/zOxFJDEKx/N+tdz1f/kjXqZGVNGltLD+va4jkjYjQwwlIHY 0ZKk+jBTIDqNevKbFWunFfDk7F4IUEYIF7toWrmX9fXfUJyXC/LPzWdXLnurRKsZwBJF AbX5eMrbEzraqdB3XOUtv03jfAtlyCCyEEHNOy+9PBCUFD83W92uX5ZfwuED4NDJ0vQw rAafdUyYxuJmsE9MHn0w23E7MDP1a077voV7SXAcDEcEYVWjUdRDmLoG6nFjWygapJvE hAtQ== X-Gm-Message-State: ACgBeo0n/xYveYYJs4h5/f1FoTt5IL8ez8Db8zOXJ7YVutcHBs5QIsgO XYl15l7FW5rDhMHv5i+JRRSZyg== X-Google-Smtp-Source: AA6agR6j3CrMGk4TPMCPwBvaE51o8QHOWIUKsxAkxuonGlXOsZKabqIh/v6aYfhgn/tTEr+AwX2Jlw== X-Received: by 2002:a17:902:efca:b0:174:c901:aa8d with SMTP id ja10-20020a170902efca00b00174c901aa8dmr7736459plb.164.1661833628777; Mon, 29 Aug 2022 21:27:08 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id nm21-20020a17090b19d500b001eee8998f2esm7541792pjb.17.2022.08.29.21.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 21:27:08 -0700 (PDT) Date: Tue, 30 Aug 2022 04:27:04 +0000 From: Sean Christopherson To: Andrew Jones Cc: Paolo Bonzini , Marc Zyngier , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Nathan Chancellor , Nick Desaulniers , James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Atish Patra , David Hildenbrand , Tom Rix , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, Colton Lewis , Peter Gonda Subject: Re: [PATCH v5 7/7] KVM: selftests: Add ucall pool based implementation Message-ID: References: <20220825232522.3997340-1-seanjc@google.com> <20220825232522.3997340-8-seanjc@google.com> <20220829163627.qbafyl4qz5cxxue5@kamzik> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829163627.qbafyl4qz5cxxue5@kamzik> On Mon, Aug 29, 2022, Andrew Jones wrote: > On Thu, Aug 25, 2022 at 11:25:22PM +0000, Sean Christopherson wrote: > > +static struct ucall *ucall_alloc(void) > > +{ > > + struct ucall *uc; > > + int i; > > + > > + GUEST_ASSERT(ucall_pool && ucall_pool->in_use); > > ucall_pool->in_use will never be null. > > > + > > + for (i = 0; i < KVM_MAX_VCPUS; ++i) { > > + if (!atomic_test_and_set_bit(i, ucall_pool->in_use)) { > > + uc = &ucall_pool->ucalls[i]; > > + memset(uc->args, 0, sizeof(uc->args)); > > + return uc; > > + } > > + } > > nit: blank line Got 'em. Thanks for the reviews, much appreciated! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86F36ECAAD5 for ; Tue, 30 Aug 2022 04:28:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ymxsjFR7pigchA7e/s3gXzqHHcgAz39YK+RsKOLBw1k=; b=YTy5UYZ1lbK0Qn dUXkMQ0ZiUDwBJkWNIWkWA/j1D73RKDVhswC5WQpjFmgt60r8s2jHVzV3MD8WblvCV0enqkRonYEY WhNh1haj/C1SAOVJmzxedvfEq9RQP6XklEuFMxbTOarPF2/G9Nak7KV28NCvvg4J1p0o6ptO5yrpu 6kHwYILho0+jBEFOSWA0yUXzi6osVK2dEWG3uZoHI3+JKSnrtKEUrE1Eb2z78Eb2lKa2WM4gNtXOs h08p0EeH5dQmetifeHg+bCrAEkL+4npgav4cRo37ydGb4xKd47klgj4TuyN78gTCpWP3Dq652JZUk o5Zt13ijFZ+ORJTj+nCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSsqJ-00DzlO-65; Tue, 30 Aug 2022 04:27:15 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSsqF-00Dzie-CO for linux-arm-kernel@lists.infradead.org; Tue, 30 Aug 2022 04:27:12 +0000 Received: by mail-pj1-x102b.google.com with SMTP id w88-20020a17090a6be100b001fbb0f0b013so10630588pjj.5 for ; Mon, 29 Aug 2022 21:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=tveQCNdrcl8zzZ90FYJSAQp/xoPHwNHO3f5B145IGDY=; b=jz5ryMUneNPtN7GgAbdob+y42sDrVxRuBlqA3QA9oeD1pieZtFXjP021CLo/r+B8bv MYbJ7ecSXA82j8N0LGSRSWGBEUhc3gl753fZP/eq9G6cgLilZiGUBe9U0WkOOEPuzjZF 1K3HPtO4P5guX5tEHivGDwt+5tsoSrBpSv2YMAohOLencXK9GT5KAEjxZPzgLhtXs8hu gQg912iU7/NlDTQXrg/CEmP/aR5c+40JbNsB0FzAY+4nR+pg565IYviyzm5c/PrLrHLt 42P316IO38WW173exoDa9F/uBYTC0uVc+zDhMVmIYiRyS2CFUFzmi4Iwz9ul83sq02Yi qJsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=tveQCNdrcl8zzZ90FYJSAQp/xoPHwNHO3f5B145IGDY=; b=63tes5pA4xGJTtO39+JnroI0b935E9thAasu3ml6PijC0opT4BKSKzMNXXBE44vC5s bp5G8e6U8Jvh5Syk8J9ThinrvvIssE3tiueWtQmXX9O4LFd89oTtiV6x7/DCf8vQHbuu Wn/Ji24Qrw2l3WcJH68zUWlNPYpHQCSTGoYQucNAWSuEnJb3k9I1loVBYKfYr/OROvu3 8n3Gb1EZOoHGMBVVp1MjFVD6JRQBcVToKvQGkWknvINP4Die2fU+3vXEf7l6MVACuDLh tFYb/xwuuaUfWaAz6h0AlyKW+XRVa6dxC65eOPlqc9+W5DmE6n9jvplsShVoeSgoWGTL mwFg== X-Gm-Message-State: ACgBeo2V63k7BJWg5D2oGV7tGHyYgLaBqM+AvXyZ7lFOBI+0aCUrOBWt oHW5jg+0J4ex4FaL4z144hedhQ== X-Google-Smtp-Source: AA6agR6j3CrMGk4TPMCPwBvaE51o8QHOWIUKsxAkxuonGlXOsZKabqIh/v6aYfhgn/tTEr+AwX2Jlw== X-Received: by 2002:a17:902:efca:b0:174:c901:aa8d with SMTP id ja10-20020a170902efca00b00174c901aa8dmr7736459plb.164.1661833628777; Mon, 29 Aug 2022 21:27:08 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id nm21-20020a17090b19d500b001eee8998f2esm7541792pjb.17.2022.08.29.21.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 21:27:08 -0700 (PDT) Date: Tue, 30 Aug 2022 04:27:04 +0000 From: Sean Christopherson To: Andrew Jones Cc: Paolo Bonzini , Marc Zyngier , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Nathan Chancellor , Nick Desaulniers , James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Atish Patra , David Hildenbrand , Tom Rix , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, Colton Lewis , Peter Gonda Subject: Re: [PATCH v5 7/7] KVM: selftests: Add ucall pool based implementation Message-ID: References: <20220825232522.3997340-1-seanjc@google.com> <20220825232522.3997340-8-seanjc@google.com> <20220829163627.qbafyl4qz5cxxue5@kamzik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220829163627.qbafyl4qz5cxxue5@kamzik> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220829_212711_456628_4D553A4B X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 29, 2022, Andrew Jones wrote: > On Thu, Aug 25, 2022 at 11:25:22PM +0000, Sean Christopherson wrote: > > +static struct ucall *ucall_alloc(void) > > +{ > > + struct ucall *uc; > > + int i; > > + > > + GUEST_ASSERT(ucall_pool && ucall_pool->in_use); > > ucall_pool->in_use will never be null. > > > + > > + for (i = 0; i < KVM_MAX_VCPUS; ++i) { > > + if (!atomic_test_and_set_bit(i, ucall_pool->in_use)) { > > + uc = &ucall_pool->ucalls[i]; > > + memset(uc->args, 0, sizeof(uc->args)); > > + return uc; > > + } > > + } > > nit: blank line Got 'em. Thanks for the reviews, much appreciated! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel