From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4696ECAAD4 for ; Tue, 30 Aug 2022 11:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rlwLqeO+ZwYvzCfcHg+KJfwBOKTwUOVlL3PJWYZ6vCA=; b=Kcy1nVuRbrMIxl 7+UPoUvFC++RUAPRMubbXgFKn750i52ora37hOS18FsWmA/XhLvhjBiARRAIM8oMqE5bCHlzFqmTA ckCgTRE84eAqCNwJbaw4XOw99LVhjtH9BR3c5DpAi7uPvRGbXagulZHdR9BvTiZcV4Hx7wCrBCzj5 8Ws1pWqt+1Hbb5cey2ks8QP7wfJ4lrLiBg/qMXSmE4iihw0R50ru8fDqUJp9bsd/ECj6Ja74VeXvr vjHUevMYwFfz1M/aQHfOhJya81hpxUU0GFW84EpkeX/A//OMmyZWP0h5c9EosKsDXnY+nq/nTCccM H+HIkIBxoWYPGPAvOQZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSyoO-00GI4J-Hj; Tue, 30 Aug 2022 10:49:40 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSyTZ-00GA4R-Jk for linux-arm-kernel@lists.infradead.org; Tue, 30 Aug 2022 10:28:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iVRqb6pvYoEPCs3UsIknWmZQWN73wQEyaT6OK3Lynb4=; b=e36ywwCk/qloQi5u7GDXWcmGUm cv9tIADKqkkFFkA76US3eMzLIsceik6ifT5qlEDIOifT+yDDvf8CtKASL7gf1FkltxSnGxQYdmKPp Ujb8hjIhv39numbFGMz0InLFgq2eDuW7kWVf4h64MEO1dXFgMvGGKv2uvH5sJWG6DY7EWY683wbeJ NhPcod2oQeAw2o+PXtlxtVtrMMWqPEaAvw6cwcUNnLVgjx9m2+4niVbXukp9F6ElY0gELgxCFsiLb WUMNb025C2Sj37SC9a1JXuOBJKYZRvtup7SjZH/dLyUpUW3EpY62Lk470NhW/HjAmmVvdjyKFdvB/ c1GOmHgg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33996) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oSyTV-0002bP-89; Tue, 30 Aug 2022 11:28:05 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oSyTS-0001Qm-OW; Tue, 30 Aug 2022 11:28:02 +0100 Date: Tue, 30 Aug 2022 11:28:02 +0100 From: "Russell King (Oracle)" To: Zhen Lei Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@armlinux.org.uk, Saravana Kannan , Kefeng Wang , Linus Walleij Subject: Re: [PATCH v2] ARM: Add sanity check for dev->periphid in amba_probe() Message-ID: References: <20220830065413.638-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220830065413.638-1-thunder.leizhen@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220830_032810_048079_6C6F4B28 X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 30, 2022 at 02:54:13PM +0800, Zhen Lei wrote: > Commit f2d3b9a46e0e ("ARM: 9220/1: amba: Remove deferred device addition") > forcibly invokes device_add() even if dev->periphid is not ready. Although > it will be remedied in amba_match(): dev->periphid will be initialized > if everything is in place; Otherwise, return -EPROBE_DEFER to block > __driver_attach() from further execution. But not all drivers have .match > hook, such as pl031, the dev->bus->probe will be called directly in > __driver_attach(). Unfortunately, if dev->periphid is still not > initialized, the following exception will be triggered. Please check whether 9229/1 fixes this issue for you. http://www.armlinux.org.uk/developer/patches/download.php?id=9229/1 Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC8D3ECAAA1 for ; Tue, 30 Aug 2022 10:28:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229941AbiH3K2N (ORCPT ); Tue, 30 Aug 2022 06:28:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbiH3K2K (ORCPT ); Tue, 30 Aug 2022 06:28:10 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 537C79D645 for ; Tue, 30 Aug 2022 03:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iVRqb6pvYoEPCs3UsIknWmZQWN73wQEyaT6OK3Lynb4=; b=e36ywwCk/qloQi5u7GDXWcmGUm cv9tIADKqkkFFkA76US3eMzLIsceik6ifT5qlEDIOifT+yDDvf8CtKASL7gf1FkltxSnGxQYdmKPp Ujb8hjIhv39numbFGMz0InLFgq2eDuW7kWVf4h64MEO1dXFgMvGGKv2uvH5sJWG6DY7EWY683wbeJ NhPcod2oQeAw2o+PXtlxtVtrMMWqPEaAvw6cwcUNnLVgjx9m2+4niVbXukp9F6ElY0gELgxCFsiLb WUMNb025C2Sj37SC9a1JXuOBJKYZRvtup7SjZH/dLyUpUW3EpY62Lk470NhW/HjAmmVvdjyKFdvB/ c1GOmHgg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33996) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oSyTV-0002bP-89; Tue, 30 Aug 2022 11:28:05 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oSyTS-0001Qm-OW; Tue, 30 Aug 2022 11:28:02 +0100 Date: Tue, 30 Aug 2022 11:28:02 +0100 From: "Russell King (Oracle)" To: Zhen Lei Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@armlinux.org.uk, Saravana Kannan , Kefeng Wang , Linus Walleij Subject: Re: [PATCH v2] ARM: Add sanity check for dev->periphid in amba_probe() Message-ID: References: <20220830065413.638-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830065413.638-1-thunder.leizhen@huawei.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2022 at 02:54:13PM +0800, Zhen Lei wrote: > Commit f2d3b9a46e0e ("ARM: 9220/1: amba: Remove deferred device addition") > forcibly invokes device_add() even if dev->periphid is not ready. Although > it will be remedied in amba_match(): dev->periphid will be initialized > if everything is in place; Otherwise, return -EPROBE_DEFER to block > __driver_attach() from further execution. But not all drivers have .match > hook, such as pl031, the dev->bus->probe will be called directly in > __driver_attach(). Unfortunately, if dev->periphid is still not > initialized, the following exception will be triggered. Please check whether 9229/1 fixes this issue for you. http://www.armlinux.org.uk/developer/patches/download.php?id=9229/1 Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!