From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v1 1/2] ACPI: PMIC: Use sizeof() instead of hard coded value
Date: Tue, 30 Aug 2022 19:10:57 +0300 [thread overview]
Message-ID: <Yw42ka9czLbBmTtp@smile.fi.intel.com> (raw)
In-Reply-To: <Yw4zaBJu81SvkFMM@black.fi.intel.com>
On Tue, Aug 30, 2022 at 06:57:28PM +0300, Mika Westerberg wrote:
> On Tue, Aug 30, 2022 at 04:55:31PM +0300, Andy Shevchenko wrote:
> > It's better to use sizeof() of a given buffer than spreading
> > a hard coded value.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thanks! As I replied to this, I'm preparing a v2 which will cover more
conversions. I won't use your tag because it will cover just like a half of it.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-08-30 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 13:55 [PATCH v1 1/2] ACPI: PMIC: Use sizeof() instead of hard coded value Andy Shevchenko
2022-08-30 13:55 ` [PATCH v1 2/2] ACPI: PMIC: Replace open coded be16_to_cpu() Andy Shevchenko
2022-08-30 16:06 ` Mika Westerberg
2022-08-30 16:37 ` Andy Shevchenko
2022-08-30 16:10 ` kernel test robot
2022-08-30 15:14 ` [PATCH v1 1/2] ACPI: PMIC: Use sizeof() instead of hard coded value Andy Shevchenko
2022-08-30 15:57 ` Mika Westerberg
2022-08-30 16:10 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw42ka9czLbBmTtp@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.