From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 0/6] drm/i915/gmbus: stop using implicit dev_priv
Date: Tue, 30 Aug 2022 15:23:38 +0300 [thread overview]
Message-ID: <Yw4BStP1E4WLwoaR@intel.com> (raw)
In-Reply-To: <cover.1661855191.git.jani.nikula@intel.com>
On Tue, Aug 30, 2022 at 01:27:56PM +0300, Jani Nikula wrote:
> The register macros are the last holdout for implicit dev_priv local
> variable. Try out what it would mean to stop using it, and require
> passing i915 as parameter to the register macros. Use gmbus as a nicely
> isolated playing ground.
>
> Jani Nikula (6):
> drm/i915/gmbus: split out gmbus regs in a separate file
> drm/i915/gmbus: whitespace cleanup in reg definitions
> drm/i915/gmbus: add wrapper for gmbus mmio base
> drm/i915/gmbus: stop using implicit dev_priv in register definitions
> drm/i915/reg: stop using implicit dev_priv in DSPCLK_GATE_D
> drm/i915/gmbus: mass dev_priv -> i915 rename
Looks reasonable enough to me. Just wondering when I'll start
getting annoyed at not finding something in i915_reg.h :)
Series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> .../i915/display/intel_display_power_well.c | 4 +-
> drivers/gpu/drm/i915/display/intel_gmbus.c | 275 +++++++++---------
> .../gpu/drm/i915/display/intel_gmbus_regs.h | 81 ++++++
> drivers/gpu/drm/i915/display/intel_overlay.c | 4 +-
> drivers/gpu/drm/i915/display/vlv_dsi.c | 8 +-
> drivers/gpu/drm/i915/gvt/edid.c | 3 +-
> drivers/gpu/drm/i915/i915_reg.h | 65 +----
> drivers/gpu/drm/i915/intel_pm.c | 4 +-
> 8 files changed, 232 insertions(+), 212 deletions(-)
> create mode 100644 drivers/gpu/drm/i915/display/intel_gmbus_regs.h
>
> --
> 2.34.1
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2022-08-30 12:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 10:27 [Intel-gfx] [PATCH 0/6] drm/i915/gmbus: stop using implicit dev_priv Jani Nikula
2022-08-30 10:27 ` [Intel-gfx] [PATCH 1/6] drm/i915/gmbus: split out gmbus regs in a separate file Jani Nikula
2022-08-30 10:27 ` [Intel-gfx] [PATCH 2/6] drm/i915/gmbus: whitespace cleanup in reg definitions Jani Nikula
2022-08-30 10:27 ` [Intel-gfx] [PATCH 3/6] drm/i915/gmbus: add wrapper for gmbus mmio base Jani Nikula
2022-08-30 10:28 ` [Intel-gfx] [PATCH 4/6] drm/i915/gmbus: stop using implicit dev_priv in register definitions Jani Nikula
2022-08-30 10:28 ` [Intel-gfx] [PATCH 5/6] drm/i915/reg: stop using implicit dev_priv in DSPCLK_GATE_D Jani Nikula
2022-08-30 10:28 ` [Intel-gfx] [PATCH 6/6] drm/i915/gmbus: mass dev_priv -> i915 rename Jani Nikula
2022-08-30 10:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gmbus: stop using implicit dev_priv Patchwork
2022-08-30 10:46 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-08-30 10:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-30 12:23 ` Ville Syrjälä [this message]
2022-08-30 13:08 ` [Intel-gfx] [PATCH 0/6] " Jani Nikula
2022-08-31 15:42 ` Jani Nikula
2022-08-31 13:37 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw4BStP1E4WLwoaR@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.