From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: kernel test robot <lkp@intel.com>,
Ard Biesheuvel <ardb@kernel.org>,
kbuild-all@lists.01.org, linux-usb@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Subject: Re: [usb:usb-testing 29/47] drivers/usb/host/ehci-platform.c:56:19: warning: 'hcd_name' defined but not used
Date: Wed, 31 Aug 2022 08:00:33 +0200 [thread overview]
Message-ID: <Yw75Aa35sWOjKMN0@kroah.com> (raw)
In-Reply-To: <Yw5E7n+lNgz1ANEH@rowland.harvard.edu>
On Tue, Aug 30, 2022 at 01:12:14PM -0400, Alan Stern wrote:
> On Wed, Aug 31, 2022 at 12:10:36AM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> > head: 594b9411b4adceb59ca8a66997eec1eaa3756785
> > commit: 5cfdb45657c97315501316657e504298b381ceee [29/47] usb: reduce kernel log spam on driver registration
> > config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220831/202208310007.6yJMsSYz-lkp@intel.com/config)
> > compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
> > reproduce (this is a W=1 build):
> > # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?id=5cfdb45657c97315501316657e504298b381ceee
> > git remote add usb https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
> > git fetch --no-tags usb usb-testing
> > git checkout 5cfdb45657c97315501316657e504298b381ceee
> > # save the config file
> > mkdir build_dir && cp config build_dir/.config
> > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/usb/host/
> >
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> drivers/usb/host/ehci-platform.c:56:19: warning: 'hcd_name' defined but not used [-Wunused-const-variable=]
> > 56 | static const char hcd_name[] = "ehci-platform";
> > | ^~~~~~~~
> > --
> > >> drivers/usb/host/ohci-platform.c:44:19: warning: 'hcd_name' defined but not used [-Wunused-const-variable=]
> > 44 | static const char hcd_name[] = "ohci-platform";
> > | ^~~~~~~~
>
> This is a side effect from Ard's patch removing the pr_info lines from
> these drivers. It will show up in some of the other drivers too (the
> ones that don't initialize their own hc_driver structure). The solution
> is simply to remove the unused definitions.
>
> Ard, do you want to write a fixup patch to do this?
I'll go fix it up...
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: kbuild-all@lists.01.org
Subject: Re: [usb:usb-testing 29/47] drivers/usb/host/ehci-platform.c:56:19: warning: 'hcd_name' defined but not used
Date: Wed, 31 Aug 2022 08:00:33 +0200 [thread overview]
Message-ID: <Yw75Aa35sWOjKMN0@kroah.com> (raw)
In-Reply-To: <Yw5E7n+lNgz1ANEH@rowland.harvard.edu>
[-- Attachment #1: Type: text/plain, Size: 2136 bytes --]
On Tue, Aug 30, 2022 at 01:12:14PM -0400, Alan Stern wrote:
> On Wed, Aug 31, 2022 at 12:10:36AM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> > head: 594b9411b4adceb59ca8a66997eec1eaa3756785
> > commit: 5cfdb45657c97315501316657e504298b381ceee [29/47] usb: reduce kernel log spam on driver registration
> > config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220831/202208310007.6yJMsSYz-lkp(a)intel.com/config)
> > compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
> > reproduce (this is a W=1 build):
> > # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?id=5cfdb45657c97315501316657e504298b381ceee
> > git remote add usb https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
> > git fetch --no-tags usb usb-testing
> > git checkout 5cfdb45657c97315501316657e504298b381ceee
> > # save the config file
> > mkdir build_dir && cp config build_dir/.config
> > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/usb/host/
> >
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> drivers/usb/host/ehci-platform.c:56:19: warning: 'hcd_name' defined but not used [-Wunused-const-variable=]
> > 56 | static const char hcd_name[] = "ehci-platform";
> > | ^~~~~~~~
> > --
> > >> drivers/usb/host/ohci-platform.c:44:19: warning: 'hcd_name' defined but not used [-Wunused-const-variable=]
> > 44 | static const char hcd_name[] = "ohci-platform";
> > | ^~~~~~~~
>
> This is a side effect from Ard's patch removing the pr_info lines from
> these drivers. It will show up in some of the other drivers too (the
> ones that don't initialize their own hc_driver structure). The solution
> is simply to remove the unused definitions.
>
> Ard, do you want to write a fixup patch to do this?
I'll go fix it up...
thanks,
greg k-h
next prev parent reply other threads:[~2022-08-31 6:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 16:10 [usb:usb-testing 29/47] drivers/usb/host/ehci-platform.c:56:19: warning: 'hcd_name' defined but not used kernel test robot
2022-08-30 17:12 ` Alan Stern
2022-08-30 17:12 ` Alan Stern
2022-08-31 6:00 ` Greg Kroah-Hartman [this message]
2022-08-31 6:00 ` Greg Kroah-Hartman
2022-09-05 10:13 ` Ard Biesheuvel
2022-09-05 10:13 ` Ard Biesheuvel
2022-09-05 10:17 ` Greg Kroah-Hartman
2022-09-05 10:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw75Aa35sWOjKMN0@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alim.akhtar@samsung.com \
--cc=ardb@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=krzk@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=robh@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.