All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: jflf_kernel@gmx.com
Cc: Oliver Neukum <oneukum@suse.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: add quirks for Lenovo OneLink+ Dock
Date: Wed, 31 Aug 2022 09:31:31 +0200	[thread overview]
Message-ID: <Yw8OU8hYZuuBgrnj@kroah.com> (raw)
In-Reply-To: <edd97137-74a1-ee0b-d475-7c5b36197155@gmx.com>

On Tue, Aug 30, 2022 at 09:50:03PM +0200, jflf_kernel@gmx.com wrote:
> 
> On 30/08/2022 16.47, Oliver Neukum wrote:
> 
> > 1) force a reset after a resume and call reset_resume() instead of resume()
> > 2) block autosuspend if remote wakeup is required
> >
> > I suspect you are actually using the second effect. Have you
> > tested with "usbcore.autosuspend=-1" on the kernel command line.
> 
> After further testing, your suspicion is correct.
> 
> TL;DR: the two VL812 hubs don't behave well when suspended.
> 
> I'd like to prepare a better patch for that issue. What's the recommended strategy? The current patch works, even if only as a side effect and when there's a wakeup source downstream. It's currently in Greg KH's usb-linus branch, and will land in linux-next at some point. I'm tempted to let it be and undo it later in the better patch. Is that acceptable? Or should I ask Greg KH to pull it?

I can revert it if you want me to, just let me know.

thanks,

greg k-h

  reply	other threads:[~2022-08-31  7:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-24 16:09 [PATCH] usb: add quirks for Lenovo OneLink+ Dock JFLF
2022-08-24 16:19 ` Greg KH
2022-08-30 11:54 ` Oliver Neukum
2022-08-30 13:56   ` jflf_kernel
2022-08-30 14:47     ` Oliver Neukum
2022-08-30 19:50       ` jflf_kernel
2022-08-31  7:31         ` Greg KH [this message]
2022-08-31  7:43           ` jflf_kernel
2022-08-31  8:35             ` Greg KH
2022-08-31  9:16         ` Oliver Neukum
2022-09-04 21:38           ` jflf_kernel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yw8OU8hYZuuBgrnj@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jflf_kernel@gmx.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.