From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 526A8ECAAD1 for ; Wed, 31 Aug 2022 09:23:32 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 6AD2B3CA6D3 for ; Wed, 31 Aug 2022 11:23:30 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id F18673CA0B0 for ; Wed, 31 Aug 2022 11:23:20 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 24BD91A0090E for ; Wed, 31 Aug 2022 11:23:19 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7AB1D2224B; Wed, 31 Aug 2022 09:23:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661937799; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fiJSlqKbo1mqwqQx81aIewwCAoke3RSBmBwdcivBndk=; b=h3xCGS7Up+IZEV240JABSFgTzpUZ1hLYIGrUqnfbtrKyIIPMQbgKND4VwxsJMUebwphc1b v16cQG6PxCrTykrK9qt5DHavey9tVjvwACBwmVtyt9LcAFsDJmQwKNaYztLhi0IPGR7Zyz ek7Gz4e8Xfb3r6t5fo42LnS3tx6kHX8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661937799; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fiJSlqKbo1mqwqQx81aIewwCAoke3RSBmBwdcivBndk=; b=1l/s/UGqf45YJL5vQvhsp8NYmndW+jxrko5WjC60zQH6USuAPIOpZ1oudFr55MRfDpLkEr eCCyKW5fYYhtqdBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4D7F51332D; Wed, 31 Aug 2022 09:23:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id S80PEocoD2OuQwAAMHmgww (envelope-from ); Wed, 31 Aug 2022 09:23:19 +0000 Date: Wed, 31 Aug 2022 11:25:18 +0200 From: Cyril Hrubis To: Martin Doucha Message-ID: References: <20220830135007.16818-1-mdoucha@suse.cz> <20220830135007.16818-7-mdoucha@suse.cz> <256a2476-dff0-dfe0-8913-4cfdd38c8a6d@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <256a2476-dff0-dfe0-8913-4cfdd38c8a6d@suse.cz> X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 06/10] copy_file_range01: Add max_runtime X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > LGTM (test uses all_filesystems, but 20 for all possible filesystems should be OK). > Hmm, I've missed the .all_filesystems setting here. In that case the > test should take ~2 seconds per filesystems and the patch is not needed. > Feel free to discard it then. I would still vote for adding something as .max_runtime = 5 or something like this so that it's obvious that the test can run for a few seconds per run() call especially on slower disks. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp