From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Harsh Modi <harshmodi@google.com>,
netfilter-devel@vger.kernel.org, sdf@google.com,
kadlec@netfilter.org
Subject: Re: [PATCH bridge, v3] br_netfilter: Drop dst references before setting.
Date: Wed, 31 Aug 2022 11:46:41 +0200 [thread overview]
Message-ID: <Yw8uATAfEDeQ1f7X@salvia> (raw)
In-Reply-To: <20220831064447.GA1352@breakpoint.cc>
On Wed, Aug 31, 2022 at 08:44:47AM +0200, Florian Westphal wrote:
> Harsh Modi <harshmodi@google.com> wrote:
> > The IPv6 path already drops dst in the daddr changed case, but the IPv4
> > path does not. This change makes the two code paths consistent.
>
> Acked-by: Florian Westphal <fw@strlen.de>
Applied, thanks
> Probably best to add a
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>
> ... just to make sure this gets propagated to stable.
>
> Original code was likely fine because nothing ever did set a skb->dst
> entry earlier than bridge in those days.
I have appended this comment for the record.
prev parent reply other threads:[~2022-08-31 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 5:36 [PATCH bridge, v3] br_netfilter: Drop dst references before setting Harsh Modi
2022-08-31 6:44 ` Florian Westphal
2022-08-31 9:46 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw8uATAfEDeQ1f7X@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=harshmodi@google.com \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.