All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Lukas Wunner <lukas@wunner.de>,
	Chris Chiu <chris.chiu@canonical.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 3/6] PCI: Distribute available resources for root buses too
Date: Wed, 31 Aug 2022 17:18:38 +0300	[thread overview]
Message-ID: <Yw9tvs7KjZ4dMAlA@smile.fi.intel.com> (raw)
In-Reply-To: <20220816100740.68667-4-mika.westerberg@linux.intel.com>

On Tue, Aug 16, 2022 at 01:07:37PM +0300, Mika Westerberg wrote:
> Currently we distribute the spare resources only upon hot-add so if
> there are PCI devices connected already when the initial root bus scan
> is done, and they have not been fully configured by the BIOS, we may end
> up allocating resources just enough to cover only what is currently
> there. If some of those devices are hotplug bridges themselves we do not
> leave any additional resource space for future expansion.
> 
> For this reason distribute the available resources for root buses too to
> make this work the same way we do in the normal hotplug case.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216000
> Reported-by: Chris Chiu <chris.chiu@canonical.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> The diffstat is quite big here but this is due the fact that we move the
> pci_assign_unassigned_root_bus_resources() below
> pci_bridge_distribute_available_resources() so we can call it without
> adding forward declaration.

Perhaps you can split to move and actual update?

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2022-08-31 14:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16 10:07 [PATCH 0/6] PCI: Allow for future resource expansion on initial root bus scan Mika Westerberg
2022-08-16 10:07 ` [PATCH 1/6] PCI: Fix used_buses calculation in pci_scan_child_bus_extend() Mika Westerberg
2022-08-16 10:07 ` [PATCH 2/6] PCI: Pass available buses also when the bridge is already configured Mika Westerberg
2022-08-16 10:07 ` [PATCH 3/6] PCI: Distribute available resources for root buses too Mika Westerberg
2022-08-31 14:18   ` Andy Shevchenko [this message]
2022-08-16 10:07 ` [PATCH 4/6] PCI: Remove two unnecessary empty lines in pci_scan_child_bus_extend() Mika Westerberg
2022-08-16 10:07 ` [PATCH 5/6] PCI: Fix typo " Mika Westerberg
2022-08-16 10:07 ` [PATCH 6/6] PCI: Fix indentation in pci_bridge_distribute_available_resources() Mika Westerberg
2022-08-31 14:19   ` Andy Shevchenko
2022-08-17  1:51 ` [PATCH 0/6] PCI: Allow for future resource expansion on initial root bus scan Chris Chiu
2022-08-31 14:20 ` Andy Shevchenko
2022-09-01  5:31   ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yw9tvs7KjZ4dMAlA@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=chris.chiu@canonical.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.