From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-fsdevel@vger.kernel.org
Cc: Eric Biederman <ebiederm@xmission.com>
Subject: [PATCH 4/8] bprm_fill_uid(): don't open-code file_inode()
Date: Sat, 20 Aug 2022 21:16:59 +0100 [thread overview]
Message-ID: <YwFBO19tkIUm49Zs@ZenIV> (raw)
In-Reply-To: <YwFANLruaQpqmPKv@ZenIV>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
fs/exec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/exec.c b/fs/exec.c
index f793221f4eb6..c1867122204a 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1595,7 +1595,7 @@ static void bprm_fill_uid(struct linux_binprm *bprm, struct file *file)
{
/* Handle suid and sgid on files */
struct user_namespace *mnt_userns;
- struct inode *inode;
+ struct inode *inode = file_inode(file);
unsigned int mode;
kuid_t uid;
kgid_t gid;
@@ -1606,7 +1606,6 @@ static void bprm_fill_uid(struct linux_binprm *bprm, struct file *file)
if (task_no_new_privs(current))
return;
- inode = file->f_path.dentry->d_inode;
mode = READ_ONCE(inode->i_mode);
if (!(mode & (S_ISUID|S_ISGID)))
return;
--
2.30.2
next prev parent reply other threads:[~2022-08-20 20:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 20:12 [PATCHES] file_inode() and ->f_mapping cleanups Al Viro
2022-08-20 20:14 ` [PATCH 1/8] ibmvmc: don't open-code file_inode() Al Viro
2022-08-20 20:14 ` [PATCH 2/8] exfat_iterate(): don't open-code file_inode(file) Al Viro
2022-08-20 20:16 ` [PATCH 3/8] sgx: use ->f_mapping Al Viro
2022-08-25 4:22 ` Jarkko Sakkinen
2022-08-20 20:16 ` Al Viro [this message]
2022-08-20 20:17 ` [PATCH 5/8] nfs_finish_open(): don't open-code file_inode() Al Viro
2022-08-20 20:19 ` [PATCH 6/8] dma_buf: no need to bother with file_inode()->i_mapping Al Viro
2022-08-20 20:19 ` [PATCH 7/8] _nfs42_proc_copy(): use ->f_mapping instead of file_inode()->i_mapping Al Viro
2022-08-20 20:20 ` [PATCH 8/8] orangefs: use ->f_mapping Al Viro
2022-09-21 19:30 ` Mike Marshall
2022-08-26 8:03 ` [PATCHES] file_inode() and ->f_mapping cleanups Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwFBO19tkIUm49Zs@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.