From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B6B6C00140 for ; Sun, 21 Aug 2022 11:39:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id CCF72817BD; Sun, 21 Aug 2022 11:39:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org CCF72817BD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1661081956; bh=3E2ZZreFqyWHBQ5Zv5WGqAYyDcyCvPfaTQvFNC0DkXw=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=VZG4H9hJGnNYs4YYHRtKE535u1SKyoHpje8CLXebHeslu78FCPkoN+u5nId25Drhi s7dUnq4VKpUQuNsXvGIYT12KB3vUkehW5VcgQ5ijAL63cuI0ZiRDs2Qs9ryji+gqNu KNwg5TiqG1NXJ41bLKqwPDyTasP44qbueuNSRV7PD9gan4rGxLARbJVGnKd0RyM2OO Y4GKUVtyaICGqR1wagdsb5GbKuZ5x7ynTYbwchyTO14t0loFZPdKHpuPPP7FdE1/tj ZK7cluKv17eSTPlqO9DafYJ0Jxmp38I3b94o/a/aNWul7XSlIVWxk0ke2Ht+CU+pk/ AMR0URWKor23A== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3FZFhaHgxu5m; Sun, 21 Aug 2022 11:39:15 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id AB84181971; Sun, 21 Aug 2022 11:39:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org AB84181971 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 840391BF3A7 for ; Sun, 21 Aug 2022 11:39:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 698BB409E8 for ; Sun, 21 Aug 2022 11:39:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 698BB409E8 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bZ05tZWhA50G for ; Sun, 21 Aug 2022 11:39:10 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6BA4E409AC Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id 6BA4E409AC for ; Sun, 21 Aug 2022 11:39:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B806DB80CAD; Sun, 21 Aug 2022 11:39:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16F82C433C1; Sun, 21 Aug 2022 11:39:05 +0000 (UTC) Date: Sun, 21 Aug 2022 14:39:01 +0300 From: Leon Romanovsky To: Wolfram Sang Message-ID: References: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661081946; bh=XskdzOo4d6sQ470cDvLPNQUn3vWKINLbams0NyYkyHs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h2mT+V1f1lnbZkkGAhFAY/FsV+M1AF9PcfNeRDvNZKCJy57DaoMtr9s0psqD3Q1mO lbDhmNpKNvV/MR3fm6StN1mxNxpQJUC8tyMYcQcHpyiP/DrWCMjJuOVjw/fDkS+Jbx q48H/NylIMORBfw8L2CaoJxyCseFOceSz7e8e7zajZorpFMEhY5H7KErwdtQ0xCEA5 hvyLFOsrJINBQhAU2H/quZ7hJS+vJsR04M2CqzO5yYMTToisG1GuzCWaEmeBmvQMOw uIVl8tgoxsIPMIJR37nelEvAqkJqxypMLHMFaQaclZNgvWJYRb3CySjpqDkfgWXLC6 zNIdvXH7Xnd5w== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=h2mT+V1f Subject: Re: [Intel-wired-lan] [PATCH] net: move from strlcpy with unused retval to strscpy X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Shyam Sundar S K , Igor Russkikh , Kevin Brace , Somnath Kotur , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-stm32@st-md-mailman.stormreply.com, Andy Gospodarek , Wei Liu , Manish Chopra , Samuel Holland , Michael Ellerman , Madalin Bucur , Christian Lamparter , Michal Simek , Christophe Leroy , Jose Abreu , Radhey Shyam Pandey , Franky Lin , Mark Lee , Chris Lee , Nick Child , Jiri Pirko , Jay Vosburgh , Vinay Kumar Yadav , Arend van Spriel , Nicholas Piggin , Igor Mitsyanko , Krzysztof Halasa , Shay Agroskin , linux-omap@vger.kernel.org, Petr Machata , libertas-dev@lists.infradead.org, Rasesh Mody , Ilias Apalodimas , Douglas Miller , Joakim Zhang , Ralf Baechle , Vivien Didelot , Ion Badulescu , Hartley Sweeten , Stanislav Yakovlev , Jon Mason , Vladimir Oltean , Claudiu Beznea , Christian Benvenuti , Samuel Chessman , linux-usb@vger.kernel.org, Ronak Doshi , Kunihiko Hayashi , Chris Snook , Denis Kirjanov , Prashant Sreedharan , linux-kernel@vger.kernel.org, Daniele Venzano , Eric Dumazet , Zhu Yanjun , Pantelis Antoniou , Arthur Kiyanovski , "David S. Miller" , Sergey Matyukevich , Rain River , Veaceslav Falico , Martin Habets , Yisen Zhuang , Wolfgang Grandegger , Steve Glendinning , Tom Lendacky , Michael Hennerich , Ido Schimmel , Sean Wang , linuxppc-dev@lists.ozlabs.org, linux-can@vger.kernel.org, Siva Reddy Kallam , Claudiu Manoil , Doug Berger , Simon Kelley , Giuseppe Cavallaro , linux-arm-kernel@lists.infradead.org, Mirko Lindner , Sriharsha Basavapatna , Nicolas Pitre , David Arinzon , Rohit Maheshwari , Tariq Toukan , Sudarsana Kalluru , Taras Chornyi , Maxime Coquelin , linux-mediatek@lists.infradead.org, Heiner Kallweit , linux-wireless@vger.kernel.org, Ajit Khaparde , Petko Manolov , Andreas Larsson , Jason Wang , Kurt Kanzenbach , linux-hyperv@vger.kernel.org, oss-drivers@corigine.com, netdev@vger.kernel.org, Subbaraya Sundeep , Hin-Tak Leung , Jassi Brar , Noam Dagan , Stanislaw Gruszka , Ajay Singh , Florian Fainelli , Dave Jiang , linux-rdma@vger.kernel.org, Guo-Fu Tseng , Dexuan Cui , Jernej Skrabec , Chen-Yu Tsai , Broadcom internal kernel review list , b43-dev@lists.infradead.org, Simon Horman , Paolo Abeni , Allen Hubbe , Shahed Shaikh , Grygorii Strashko , Byungho An , Haiyang Zhang , Hante Meuleman , Vladimir Zapolskiy , Don Fry , John Crispin , Michael Chan , virtualization@lists.linux-foundation.org, Ishizaki Kou , Salil Mehta , GR-Linux-NIC-Dev@marvell.com, linux-parisc@vger.kernel.org, Geoff Levand , linux-sunxi@lists.linux.dev, Edward Cree , Bryan Whitehead , Saeed Bishara , Mark Einon , Geetha sowjanya , Oliver Neukum , "Michael S. Tsirkin" , VMware PV-Drivers Reviewers , Ioana Ciornei , Alexandre Torgue , Govindarajulu Varadarajan <_govind@gmx.com>, Thomas Petazzoni , Ayush Sawal , UNGLinuxDriver@microchip.com, linux-acenic@sunsite.dk, Herton Ronaldo Krzesinski , Rahul Verma , Russell King , SHA-cyfmac-dev-list@infineon.com, Lino Sanfilippo , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Steffen Klassert , Sunil Goutham , Sebastian Hesselbarth , Jes Sorensen , nic_swsd@realtek.com, Ariel Elior , Jouni Malinen , Kalle Valo , Marc Kleine-Budde , Matthias Brugger , Marcin Wojtas , brcm80211-dev-list.pdl@broadcom.com, David Ahern , linux-mips@vger.kernel.org, Li Yang , Stephen Hemminger , hariprasad , ntb@lists.linux.dev, Raju Rangoju , Larry Finger , Saeed Mahameed , Felix Fietkau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Aug 18, 2022 at 11:00:34PM +0200, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang > --- <...> > drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 6 +++--- > drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +- > .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 4 ++-- > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- > .../ethernet/mellanox/mlx5/core/ipoib/ethtool.c | 2 +- Thanks, Reviewed-by: Leon Romanovsky _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62B4EC32789 for ; Sun, 21 Aug 2022 11:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cs/tc4LRP05aft+lw1s0Hw9J5qiCtDypCAUcIFCUKxA=; b=zbWV/si40QrDEpwkwAnwkR3NkU 7sCRu3SMnxxRvVQCFuNPPhkRGwjabsYOqiCd5frxKe0TG4OgiJohJKtpaWe4ZNt0mcMumJG5BHA1y KzQo9+O3zgU0Kc51h7HJmNYEQjxMoPotd929FtiFr8PKGB9vEoKaGJWkDn0XVAJAfcGrbxyOXzKUs 4KNG1JdR89l9dUCc96faQGCgxAZIJb0HUtYAmyGXoseQFOf2ASrGxgCRkU85MpFhcRAPGn4/axT/9 FqfSovf55mD2NAAF+eiRx4SoLV8pxxTp7H/o8fg4gLZVGXPFS6+xugt8x7pzPrZulfKDHxN4LPW4N GMcDTGhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oPjIe-009ozy-DN; Sun, 21 Aug 2022 11:39:30 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oPjIO-009osu-Hf; Sun, 21 Aug 2022 11:39:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B806DB80CAD; Sun, 21 Aug 2022 11:39:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16F82C433C1; Sun, 21 Aug 2022 11:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661081946; bh=XskdzOo4d6sQ470cDvLPNQUn3vWKINLbams0NyYkyHs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h2mT+V1f1lnbZkkGAhFAY/FsV+M1AF9PcfNeRDvNZKCJy57DaoMtr9s0psqD3Q1mO lbDhmNpKNvV/MR3fm6StN1mxNxpQJUC8tyMYcQcHpyiP/DrWCMjJuOVjw/fDkS+Jbx q48H/NylIMORBfw8L2CaoJxyCseFOceSz7e8e7zajZorpFMEhY5H7KErwdtQ0xCEA5 hvyLFOsrJINBQhAU2H/quZ7hJS+vJsR04M2CqzO5yYMTToisG1GuzCWaEmeBmvQMOw uIVl8tgoxsIPMIJR37nelEvAqkJqxypMLHMFaQaclZNgvWJYRb3CySjpqDkfgWXLC6 zNIdvXH7Xnd5w== Date: Sun, 21 Aug 2022 14:39:01 +0300 From: Leon Romanovsky To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , Wolfgang Grandegger , Marc Kleine-Budde , Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Kurt Kanzenbach , Steffen Klassert , David Dillow , Russell King , Ion Badulescu , Andreas Larsson , Mark Einon , Lino Sanfilippo , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jes Sorensen , Shay Agroskin , Arthur Kiyanovski , David Arinzon , Noam Dagan , Saeed Bishara , Don Fry , Tom Lendacky , Shyam Sundar S K , Igor Russkikh , Chris Snook , Michael Chan , Broadcom internal kernel review list , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Ariel Elior , Sudarsana Kalluru , Manish Chopra , Doug Berger , Siva Reddy Kallam , Prashant Sreedharan , Sunil Goutham , Raju Rangoju , Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , Hartley Sweeten , Christian Benvenuti , Govindarajulu Varadarajan <_govind@gmx.com>, Denis Kirjanov , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , Madalin Bucur , Ioana Ciornei , Claudiu Manoil , Joakim Zhang , Pantelis Antoniou , Li Yang , Yisen Zhuang , Salil Mehta , Douglas Miller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nick Child , Jesse Brandeburg , Tony Nguyen , Guo-Fu Tseng , Sebastian Hesselbarth , Thomas Petazzoni , Marcin Wojtas , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Taras Chornyi , Mirko Lindner , Stephen Hemminger , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Matthias Brugger , Tariq Toukan , Saeed Mahameed , Ido Schimmel , Petr Machata , Bryan Whitehead , UNGLinuxDriver@microchip.com, Chris Lee , Jon Mason , Simon Horman , Rain River , Zhu Yanjun , Vladimir Zapolskiy , Rahul Verma , Shahed Shaikh , Heiner Kallweit , nic_swsd@realtek.com, Jiri Pirko , Byungho An , Edward Cree , Martin Habets , Ralf Baechle , Francois Romieu , Daniele Venzano , Nicolas Pitre , Steve Glendinning , Jassi Brar , Ilias Apalodimas , Kunihiko Hayashi , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Grygorii Strashko , Samuel Chessman , Geoff Levand , Ishizaki Kou , Kevin Brace , Radhey Shyam Pandey , Michal Simek , Krzysztof Halasa , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Sridhar Samudrala , Dave Jiang , Allen Hubbe , Michael Hennerich , Petko Manolov , Oliver Neukum , "Michael S. Tsirkin" , Jason Wang , Ronak Doshi , VMware PV-Drivers Reviewers , David Ahern , Kalle Valo , Christian Lamparter , Simon Kelley , Larry Finger , Arend van Spriel , Franky Lin , Hante Meuleman , Stanislav Yakovlev , Stanislaw Gruszka , Jouni Malinen , Ajay Singh , Claudiu Beznea , Igor Mitsyanko , Sergey Matyukevich , Herton Ronaldo Krzesinski , Hin-Tak Leung , netdev@vger.kernel.org, linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-acenic@sunsite.dk, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, intel-wired-lan@lists.osuosl.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com, linux-mips@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-omap@vger.kernel.org, linux-hyperv@vger.kernel.org, ntb@lists.linux.dev, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, libertas-dev@lists.infradead.org Subject: Re: [PATCH] net: move from strlcpy with unused retval to strscpy Message-ID: References: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220821_043912_929052_25E1739B X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Aug 18, 2022 at 11:00:34PM +0200, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang > --- <...> > drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 6 +++--- > drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +- > .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 4 ++-- > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- > .../ethernet/mellanox/mlx5/core/ipoib/ethtool.c | 2 +- Thanks, Reviewed-by: Leon Romanovsky From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64995C00140 for ; Sun, 21 Aug 2022 12:40:56 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4M9Zpt4ZvXz3c6S for ; Sun, 21 Aug 2022 22:40:54 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=h2mT+V1f; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.68.75; helo=ams.source.kernel.org; envelope-from=leon@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=h2mT+V1f; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4M9YRh2zrRz3bVt for ; Sun, 21 Aug 2022 21:39:12 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B806DB80CAD; Sun, 21 Aug 2022 11:39:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16F82C433C1; Sun, 21 Aug 2022 11:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661081946; bh=XskdzOo4d6sQ470cDvLPNQUn3vWKINLbams0NyYkyHs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h2mT+V1f1lnbZkkGAhFAY/FsV+M1AF9PcfNeRDvNZKCJy57DaoMtr9s0psqD3Q1mO lbDhmNpKNvV/MR3fm6StN1mxNxpQJUC8tyMYcQcHpyiP/DrWCMjJuOVjw/fDkS+Jbx q48H/NylIMORBfw8L2CaoJxyCseFOceSz7e8e7zajZorpFMEhY5H7KErwdtQ0xCEA5 hvyLFOsrJINBQhAU2H/quZ7hJS+vJsR04M2CqzO5yYMTToisG1GuzCWaEmeBmvQMOw uIVl8tgoxsIPMIJR37nelEvAqkJqxypMLHMFaQaclZNgvWJYRb3CySjpqDkfgWXLC6 zNIdvXH7Xnd5w== Date: Sun, 21 Aug 2022 14:39:01 +0300 From: Leon Romanovsky To: Wolfram Sang Subject: Re: [PATCH] net: move from strlcpy with unused retval to strscpy Message-ID: References: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> X-Mailman-Approved-At: Sun, 21 Aug 2022 22:40:22 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Shyam Sundar S K , Igor Russkikh , Kevin Brace , David Dillow , Somnath Kotur , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , "K. Y. Srinivasan" , linux-stm32@st-md-mailman.stormreply.com, Andy Gospodarek , Wei Liu , Manish Chopra , Samuel Holland , Madalin Bucur , Christian Lamparter , Michal Simek , Jose Abreu , Radhey Shyam Pandey , Franky Lin , Mark Lee , Chris Lee , Nick Child , Jiri Pirko , Jay Vosburgh , Vinay Kumar Yadav , Arend van Spriel , Nicholas Piggin , Igor Mitsyanko , Krzysztof Halasa , Shay Agroskin , linux-omap@vger.kernel.org, Petr Machata , libertas-dev@lists.infradead.org, Rasesh Mody , Ilias Apalodimas , Douglas Miller , Joakim Zhang , Ralf Baechle , Vivien Didelot , Ion Badulescu , Hartley Sweeten , Stanislav Yakovlev , Jon Mason , Vladimir Oltean , Claudiu Beznea , Christian Benvenuti , Samuel Chessman , linux-usb@vger.kernel.org, Ronak Doshi , Kunihiko Hayashi , Chris Snook , Deni s Kirjanov , Prashant Sreedharan , linux-kernel@vger.kernel.org, Daniele Venzano , Eric Dumazet , Zhu Yanjun , Tony Nguyen , Arthur Kiyanovski , "David S. Miller" , Sergey Matyukevich , Jesse Brandeburg , Rain River , Veaceslav Falico , Martin Habets , Yisen Zhuang , Wolfgang Grandegger , Steve Glendinning , Tom Lendacky , Michael Hennerich , Ido Schimmel , Sean Wang , linuxppc-dev@lists.ozlabs.org, linux-can@vger.kernel.org, Siva Reddy Kallam , Claudiu Manoil , Doug Berg er , Simon Kelley , Giuseppe Cavallaro , linux-arm-kernel@lists.infradead.org, Mirko Lindner , Sriharsha Basavapatna , Nicolas Pitre , David Arinzon , Rohit Maheshwari , Tariq Toukan , Sudarsana Kalluru , Taras Chornyi , Maxime Coquelin , linux-mediatek@lists.infradead.org, Heiner Kallweit , linux-wireless@vger.kernel.org, Ajit Khaparde , Petko Manolov , Andreas Larsson , Jason Wang , Kurt Kanzenbach , linux-hyperv@vger.kernel.org, oss-drivers@corigine.com, netdev@vger.kernel.org, Subbaraya Sundeep , Hin-Tak Leung , Jassi Brar , Noam Dagan , Stanislaw Gruszka , Ajay Singh , Florian Fainelli , Dave Jiang , linux-rdma@vger.kernel.org, Guo-Fu Tseng , Dexuan Cui , Jernej Skrabec , Chen-Yu Tsai , Broadcom internal kernel review list , b43-dev@lists.infradead.org, Simon Horman , Paolo Abeni , Allen Hubbe , Shahed Shaikh , Grygorii Strashko , Byungho An , Haiyang Zhang , Francois Romieu , Hante Meuleman , Vladimir Zapolskiy , Don Fry , John Crispin , Michael Chan , virtualization @lists.linux-foundation.org, Salil Mehta , GR-Linux-NIC-Dev@marvell.com, linux-parisc@vger.kernel.org, Geoff Levand , linux-sunxi@lists.linux.dev, Edward Cree , Bryan Whitehead , Saeed Bishara , Mark Einon , Geetha sowjanya , Oliver Neukum , "Michael S. Tsirkin" , VMware PV-Drivers Reviewers , Ioana Ciornei , Alexandre Torgue , Govindarajulu Varadarajan <_govind@gmx.com>, Thomas Petazzoni , Ayush Sawal , UNGLinuxDriver@microchip.com, linux-acenic@sunsite.dk, Herton Ronaldo Krzesinski , Rahul Verma , Russell King , SHA-cyfmac-dev-list@infineon.com, Lino Sanfilippo , intel-wired -lan@lists.osuosl.org, Jakub Kicinski , Steffen Klassert , Sunil Goutham , Sebastian Hesselbarth , Jes Sorensen , nic_swsd@realtek.com, Ariel Elior , Jouni Malinen , Kalle Valo , Marc Kleine-Budde , Matthias Brugger , Marcin Wojtas , brcm80211-dev-list.pdl@broadcom.com, Sridhar Samudrala , David Ahern , linux-mips@vger.kernel.org, Li Yang , Stephen Hemminger , hariprasad , ntb@lists.linux.dev, Raju Rangoju , Larry Finger , Saeed Mahameed , Felix Fietkau Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Aug 18, 2022 at 11:00:34PM +0200, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang > --- <...> > drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 6 +++--- > drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +- > .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 4 ++-- > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- > .../ethernet/mellanox/mlx5/core/ipoib/ethtool.c | 2 +- Thanks, Reviewed-by: Leon Romanovsky From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 799DEC32772 for ; Sun, 21 Aug 2022 11:39:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E07CC409FE; Sun, 21 Aug 2022 11:39:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E07CC409FE Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=h2mT+V1f X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pajZXIM4vvwG; Sun, 21 Aug 2022 11:39:15 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id ED92E409AC; Sun, 21 Aug 2022 11:39:14 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org ED92E409AC Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C4CC6C0033; Sun, 21 Aug 2022 11:39:14 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id C4493C002D for ; Sun, 21 Aug 2022 11:39:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5446360BBE for ; Sun, 21 Aug 2022 11:39:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5446360BBE Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=h2mT+V1f X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kM2YG-hWgMSA for ; Sun, 21 Aug 2022 11:39:11 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8695B60BAB Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp3.osuosl.org (Postfix) with ESMTPS id 8695B60BAB for ; Sun, 21 Aug 2022 11:39:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B806DB80CAD; Sun, 21 Aug 2022 11:39:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16F82C433C1; Sun, 21 Aug 2022 11:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661081946; bh=XskdzOo4d6sQ470cDvLPNQUn3vWKINLbams0NyYkyHs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h2mT+V1f1lnbZkkGAhFAY/FsV+M1AF9PcfNeRDvNZKCJy57DaoMtr9s0psqD3Q1mO lbDhmNpKNvV/MR3fm6StN1mxNxpQJUC8tyMYcQcHpyiP/DrWCMjJuOVjw/fDkS+Jbx q48H/NylIMORBfw8L2CaoJxyCseFOceSz7e8e7zajZorpFMEhY5H7KErwdtQ0xCEA5 hvyLFOsrJINBQhAU2H/quZ7hJS+vJsR04M2CqzO5yYMTToisG1GuzCWaEmeBmvQMOw uIVl8tgoxsIPMIJR37nelEvAqkJqxypMLHMFaQaclZNgvWJYRb3CySjpqDkfgWXLC6 zNIdvXH7Xnd5w== Date: Sun, 21 Aug 2022 14:39:01 +0300 From: Leon Romanovsky To: Wolfram Sang Subject: Re: [PATCH] net: move from strlcpy with unused retval to strscpy Message-ID: References: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> Cc: Andrew Lunn , Shyam Sundar S K , Kevin Brace , David Dillow , Somnath Kotur , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-stm32@st-md-mailman.stormreply.com, Andy Gospodarek , Wei Liu , Manish Chopra , Samuel Holland , Michael Ellerman , Madalin Bucur , Christian Lamparter , Michal Simek , Christophe Leroy , Jose Abreu , Radhey Shyam Pandey , Franky Lin , Mark Lee , Chris Lee , Nick Child , Jiri Pirko , Jay Vosburgh , Vinay Kumar Yadav , Arend van Spriel , Nicholas Piggin , Igor Mitsyanko , Krzysztof Halasa , Shay Agroskin , linux-omap@vger.kernel.org, Petr Machata , libertas-dev@lists.infradead.org, Rasesh Mody , Ilias Apalodimas , Douglas Miller , Joakim Zhang , Ralf Baechle , Vivien Didelot , Ion Badulescu , Hartley Sweeten , Stanislav Yakovlev , Jon Mason , Vladimir Oltean , Claudiu Beznea , Christian Benvenuti , Samuel Chessman , linux-usb@vger.kernel.org, Ronak Doshi , Kunihiko Hayashi , Chris Snook , Denis Kirjanov , Prashant Sreedharan , linux-kernel@vger.kernel.org, Daniele Venzano , Eric Dumazet , Zhu Yanjun , Tony Nguyen , Pantelis Antoniou , Arthur Kiyanovski , "David S. Miller" , Sergey Matyukevich , Jesse Brandeburg , Rain River , Veaceslav Falico , Martin Habets , Yisen Zhuang , Wolfgang Grandegger , Steve Glendinning , Tom Lendacky , Michael Hennerich , Ido Schimmel , Sean Wang , linuxppc-dev@lists.ozlabs.org, linux-can@vger.kernel.org, Siva Reddy Kallam , Claudiu Manoil , Doug Berger , Simon Kelley , Giuseppe Cavallaro , linux-arm-kernel@lists.infradead.org, Mirko Lindner , Sriharsha Basavapatna , Nicolas Pitre , David Arinzon , Rohit Maheshwari , Tariq Toukan , Sudarsana Kalluru , Taras Chornyi , Maxime Coquelin , linux-mediatek@lists.infradead.org, Heiner Kallweit , linux-wireless@vger.kernel.org, Ajit Khaparde , Petko Manolov , Andreas Larsson , Kurt Kanzenbach , linux-hyperv@vger.kernel.org, oss-drivers@corigine.com, netdev@vger.kernel.org, Subbaraya Sundeep , Hin-Tak Leung , Jassi Brar , Noam Dagan , Stanislaw Gruszka , Ajay Singh , Florian Fainelli , Dave Jiang , linux-rdma@vger.kernel.org, Guo-Fu Tseng , Dexuan Cui , Jernej Skrabec , Chen-Yu Tsai , Broadcom internal kernel review list , b43-dev@lists.infradead.org, Simon Horman , Paolo Abeni , Allen Hubbe , Shahed Shaikh , Grygorii Strashko , Byungho An , Haiyang Zhang , Francois Romieu , Hante Meuleman , Vladimir Zapolskiy , Don Fry , John Crispin , Michael Chan , virtualization@lists.linux-foundation.org, Ishizaki Kou , Salil Mehta , GR-Linux-NIC-Dev@marvell.com, linux-parisc@vger.kernel.org, Geoff Levand , linux-sunxi@lists.linux.dev, Edward Cree , Bryan Whitehead , Saeed Bishara , Mark Einon , Geetha sowjanya , Oliver Neukum , "Michael S. Tsirkin" , VMware PV-Drivers Reviewers , Ioana Ciornei , Alexandre Torgue , Govindarajulu Varadarajan <_govind@gmx.com>, Thomas Petazzoni , Ayush Sawal , UNGLinuxDriver@microchip.com, linux-acenic@sunsite.dk, Herton Ronaldo Krzesinski , Rahul Verma , Russell King , SHA-cyfmac-dev-list@infineon.com, Lino Sanfilippo , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Steffen Klassert , Sunil Goutham , Sebastian Hesselbarth , Jes Sorensen , nic_swsd@realtek.com, Ariel Elior , Jouni Malinen , Kalle Valo , Marc Kleine-Budde , Matthias Brugger , Marcin Wojtas , brcm80211-dev-list.pdl@broadcom.com, Sridhar Samudrala , David Ahern , linux-mips@vger.kernel.org, Li Yang , Stephen Hemminger , hariprasad , ntb@lists.linux.dev, Raju Rangoju , Larry Finger , Saeed Mahameed , Felix Fietkau X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Thu, Aug 18, 2022 at 11:00:34PM +0200, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang > --- <...> > drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 6 +++--- > drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +- > .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 4 ++-- > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- > .../ethernet/mellanox/mlx5/core/ipoib/ethtool.c | 2 +- Thanks, Reviewed-by: Leon Romanovsky _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization