From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Stefan Haberland <sth@linux.ibm.com>,
Jan Hoeppner <hoeppner@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Alexandra Winter <wintera@linux.ibm.com>,
Wenjia Zhang <wenjia@linux.ibm.com>,
Steffen Maier <maier@linux.ibm.com>,
Benjamin Block <bblock@linux.ibm.com>,
linux-s390@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] s390: move from strlcpy with unused retval to strscpy
Date: Mon, 22 Aug 2022 10:37:47 +0200 [thread overview]
Message-ID: <YwNAW2Zp6o7Z//Y2@shikoro> (raw)
In-Reply-To: <YwM4y78boN4s1VNo@li-4a3a4a4c-28e5-11b2-a85c-a8d192c6f089.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
Hi Alexander,
> Could you please explain why you skipped strlcpy() usage in
> drivers/s390/char/diag_ftp.c and drivers/s390/char/sclp_ftp.c?
Sure. It is a bit hidden in $subject, but the key is to convert strlcpy
instances for now which do not check the return value. This is the
low-hanging fruit.
Converting the other uses checking the return value needs to be done
manually and much more carfully. I wanted to this as a second step, but
if you prefer to have everything converted in one go, I can give your
subsystem a priority boost. Would you prefer that?
Thanks and happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-08-22 8:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 21:01 [PATCH] s390: move from strlcpy with unused retval to strscpy Wolfram Sang
2022-08-19 8:09 ` Alexandra Winter
2022-08-19 10:38 ` Benjamin Block
2022-08-22 8:05 ` Alexander Gordeev
2022-08-22 8:37 ` Wolfram Sang [this message]
2022-08-22 11:48 ` Alexander Gordeev
2022-08-23 9:52 ` Alexander Gordeev
2022-08-23 1:02 ` Jakub Kicinski
2022-08-23 12:45 ` Vasily Gorbik
2022-08-23 12:43 ` Vasily Gorbik
-- strict thread matches above, loose matches on Subject: below --
2022-08-18 20:59 Wolfram Sang
2022-08-22 11:49 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwNAW2Zp6o7Z//Y2@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=agordeev@linux.ibm.com \
--cc=bblock@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maier@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=sth@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.