From: John Keeping <john@metanate.com>
To: qianfanguijin@163.com
Cc: u-boot@lists.denx.de, Lukasz Majewski <lukma@denx.de>,
Marek Vasut <marex@denx.de>
Subject: Re: [PATCH] drivers: usb: fastboot: Fix full-speed usb descriptor
Date: Mon, 22 Aug 2022 11:01:21 +0100 [thread overview]
Message-ID: <YwNT8fhFAA/TaA7x@donbot> (raw)
In-Reply-To: <20220822011831.18961-1-qianfanguijin@163.com>
On Mon, Aug 22, 2022 at 09:18:31AM +0800, qianfanguijin@163.com wrote:
> From: qianfan Zhao <qianfanguijin@163.com>
>
> The host will report such error message if the fastboot device work in
> full-speed mode: "Duplicate descriptor for config 1 interface 0
> altsetting 0, skipping"
>
> Fastboot device ack both full and high speed interface descriptors when
> work in full-speed mode, that's will cause this issue.
>
> Fix it.
>
> Signed-off-by: qianfan Zhao <qianfanguijin@163.com>
Reviewed-by: John Keeping <john@metanate.com>
> ---
> drivers/usb/gadget/f_fastboot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c
> index 8ba55aab9f..d0e92c7a07 100644
> --- a/drivers/usb/gadget/f_fastboot.c
> +++ b/drivers/usb/gadget/f_fastboot.c
> @@ -119,6 +119,7 @@ static struct usb_descriptor_header *fb_fs_function[] = {
> (struct usb_descriptor_header *)&interface_desc,
> (struct usb_descriptor_header *)&fs_ep_in,
> (struct usb_descriptor_header *)&fs_ep_out,
> + NULL,
> };
>
> static struct usb_descriptor_header *fb_hs_function[] = {
> --
> 2.25.1
>
prev parent reply other threads:[~2022-08-22 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 1:18 [PATCH] drivers: usb: fastboot: Fix full-speed usb descriptor qianfanguijin
2022-08-22 10:01 ` John Keeping [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwNT8fhFAA/TaA7x@donbot \
--to=john@metanate.com \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=qianfanguijin@163.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.