Re: [PATCH 2/3] arm64: dts: renesas: r8a779f0: Add TMU nodes

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

Hi Geert,

> > +                       interrupts = <GIC_SPI 477 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 478 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 479 IRQ_TYPE_LEVEL_HIGH>;
> 
> We really should update the DT bindings so we can describe the fourth
> interrupt on TMU instances that support input capture.

Yes, but I also think this should be a separate series then.

> I don't think we need a new compatible value, as we can just look at
> the presence of the fourth (actually renesas-channels + 1) interrupt
> to enable the feature (if the driver ever gains support).

Good approach. But then, we should also switch to interrupt names to be
future proof, or? Who knows what other interrupts might be added later.

> As the above matches how TMU is handled on other SoCs:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v6.1.

Thanks!

Happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]