All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Mikko.Rapeli@bmw.de>
To: <marex@denx.de>
Cc: <alex.kanavin@gmail.com>, <Martin.Jansa@gmail.com>,
	<bitbake-devel@lists.openembedded.org>,
	<peter.kjellerstedt@axis.com>,
	<richard.purdie@linuxfoundation.org>
Subject: Re: [bitbake-devel] [PATCH] [RFC] fetch2/git: Prevent git fetcher from fetching gitlab repository metadata
Date: Mon, 22 Aug 2022 10:51:49 +0000	[thread overview]
Message-ID: <YwNfxKxUohc4TYSw@korppu> (raw)
In-Reply-To: <438756a1-efb1-cd7e-2c80-af60f8b2fcdc@denx.de>

On Mon, Aug 22, 2022 at 12:35:08PM +0200, Marek Vasut wrote:
> On 8/22/22 10:41, Alexander Kanavin wrote:
> > On Mon, 22 Aug 2022 at 10:37, Marek Vasut <marex@denx.de> wrote:
> > 
> > > > So maybe the easy way out is, if nobranch=1 then fetch everything, else
> > > > just heads and tags ?
> > > 
> > > No, this won't do, nobranch expects the commit to be in a tag.
> > 
> > I don't think it expects that.
> 
> Documentation says it does:
> 
> https://git.openembedded.org/bitbake/tree/lib/bb/fetch2/git.py#n45
> "
> - nobranch
>    Don't check the SHA validation for branch. set this option for the recipe
>    referring to commit which is valid in tag instead of branch.
>    The default is "0", set nobranch=1 if needed.
> "

Only the first sentence is enforced. The change can still be in a branch, in
a tag, in random other namespace as long as the commit is found at checkout
time.

Cheers,

-Mikko

  reply	other threads:[~2022-08-22 10:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19 16:54 [PATCH] [RFC] fetch2/git: Prevent git fetcher from fetching gitlab repository metadata Marek Vasut
2022-08-20 12:06 ` Peter Kjellerstedt
2022-08-22  5:19   ` [bitbake-devel] " Mikko.Rapeli
2022-08-22  6:57     ` Alexander Kanavin
2022-08-22  7:38       ` Mikko.Rapeli
2022-08-22  8:29         ` Marek Vasut
2022-08-22  8:37           ` Marek Vasut
2022-08-22  8:41             ` Marek Vasut
2022-08-22  9:09               ` Mikko.Rapeli
2022-08-22  8:41             ` Alexander Kanavin
2022-08-22 10:35               ` Marek Vasut
2022-08-22 10:51                 ` Mikko.Rapeli [this message]
2022-08-22 10:57                 ` Quentin Schulz
2022-08-22 11:55                   ` Marek Vasut
2022-08-22 14:17                     ` Richard Purdie
2022-08-22 15:21                       ` Peter Kjellerstedt
2022-08-22 16:39                         ` Marek Vasut
2022-09-01 17:50                           ` Marek Vasut
2022-09-02 15:54                             ` Richard Purdie
2022-08-22 16:02 ` Luca Ceresoli
2022-08-22 16:06   ` Peter Kjellerstedt
2022-08-22 16:07   ` Richard Purdie
2022-08-23 14:34     ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwNfxKxUohc4TYSw@korppu \
    --to=mikko.rapeli@bmw.de \
    --cc=Martin.Jansa@gmail.com \
    --cc=alex.kanavin@gmail.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=marex@denx.de \
    --cc=peter.kjellerstedt@axis.com \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.