From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>
Cc: Yang Jihong <yangjihong1@huawei.com>,
bp@suse.de, ndesaulniers@google.com, nathan@kernel.org,
alexandre.belloni@bootlin.com, namhyung@kernel.org,
jolsa@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fix compile error for x86
Date: Mon, 22 Aug 2022 10:14:19 -0300 [thread overview]
Message-ID: <YwOBKwPmW/FX6hSS@kernel.org> (raw)
In-Reply-To: <YwNcgdk/p18Cr+uv@gmail.com>
Em Mon, Aug 22, 2022 at 12:37:53PM +0200, Ingo Molnar escreveu:
>
> * Yang Jihong <yangjihong1@huawei.com> wrote:
>
> > Commit a0a12c3ed057 ("asm goto: eradicate CC_HAS_ASM_GOTO") eradicates
> > CC_HAS_ASM_GOTO, perf on x86 call asm_volatile_goto when compiling __GEN_RMWcc.
> > However, asm_volatile_goto is not declared, which causes compilation error:
> >
> > In file included from /home/linux/tools/include/asm/../../arch/x86/include/asm/atomic.h:7,
> > from /home/linux/tools/include/asm/atomic.h:6,
> > from /home/linux/tools/include/linux/atomic.h:5,
> > from /home/linux/tools/include/linux/refcount.h:41,
> > from /home/linux/tools/lib/perf/include/internal/cpumap.h:5,
> > from /home/linux/tools/perf/util/cpumap.h:7,
> > from /home/linux/tools/perf/util/env.h:7,
> > from /home/linux/tools/perf/util/header.h:12,
> > from pmu-events/pmu-events.c:9:
> > /home/linux/tools/include/asm/../../arch/x86/include/asm/atomic.h: In function ‘atomic_dec_and_test’:
> > /home/linux/tools/include/asm/../../arch/x86/include/asm/rmwcc.h:7:2: error: implicit declaration of function ‘asm_volatile_goto’ [-Werror=implicit-function-declaration]
> > asm_volatile_goto (fullop "; j" cc " %l[cc_label]" \
> > ^~~~~~~~~~~~~~~~~
> >
> > Solution:
> > Define asm_volatile_goto in compiler_types.h if not declared.
> >
> > Currently, only x86 architecture uses asm_volatile_goto.
> > Theoretically, this patch affects only the x86 architecture.
> >
> > Fixes: a0a12c3ed057 ("asm goto: eradicate CC_HAS_ASM_GOTO")
> > Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
> > ---
> > tools/include/linux/compiler_types.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/tools/include/linux/compiler_types.h b/tools/include/linux/compiler_types.h
> > index 24ae3054f304..1bdd834bdd57 100644
> > --- a/tools/include/linux/compiler_types.h
> > +++ b/tools/include/linux/compiler_types.h
> > @@ -36,4 +36,8 @@
> > #include <linux/compiler-gcc.h>
> > #endif
> >
> > +#ifndef asm_volatile_goto
> > +#define asm_volatile_goto(x...) asm goto(x)
> > +#endif
>
> Tested-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Linus, I'll prep a pull req later today or you can apply this so that we
can reduce the window where tools/perf/ isn't building.
- Arnaldo
next prev parent reply other threads:[~2022-08-22 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 9:25 [PATCH] perf tools: Fix compile error for x86 Yang Jihong
2022-08-22 10:37 ` Ingo Molnar
2022-08-22 13:14 ` Arnaldo Carvalho de Melo [this message]
2022-08-22 16:45 ` Linus Torvalds
2022-08-22 19:37 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwOBKwPmW/FX6hSS@kernel.org \
--to=acme@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=bp@suse.de \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=torvalds@linux-foundation.org \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.