All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Romain Naour <romain.naour@smile.fr>
Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	bcousson@baylibre.com, Romain Naour <romain.naour@skf.com>,
	Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH] ARM: dts: am5748: keep usb4_tm disabled
Date: Tue, 23 Aug 2022 08:53:24 +0300	[thread overview]
Message-ID: <YwRrVI0asWtyyorZ@atomide.com> (raw)
In-Reply-To: <20220822154625.52160-1-romain.naour@smile.fr>

Hi,

* Romain Naour <romain.naour@smile.fr> [220822 15:39]:
> From: Romain Naour <romain.naour@skf.com>
> 
> From [1]
> AM5 and DRA7 SoC families have different set of modules in them so the
> SoC sepecific dtsi files need to be separated.
> 
> e.g. Some of the major differences between AM576 and DRA76
> 
> 		DRA76x	AM576x
> 
> USB3		x
> USB4		x
> ATL		x
> VCP		x
> MLB		x
> ISS		x
> PRU-ICSS1		x
> PRU-ICSS2		x
> 
> But commit [2] removed usb4_tm part from am5748.dtsi and introcuded new
> ti-sysc errors in dmesg.

OK makes sense to me. Can you please update your patch to use proper
Fixes tags and commit descriptions? This way the patch will get
automatically picked up for stable kernels as a fix.

So something like this instead of listing URLs to commits:

Commit bcbb63b80284 ("ARM: dts: dra7: Separate AM57 dtsi files") blah
blah, then commit 176f26bcd41a ("ARM: dts: Add support for dra762 abz
package") blah blah...

Fixes: 176f26bcd41a ("ARM: dts: Add support for dra762 abz package")

Regards,

Tony

  reply	other threads:[~2022-08-23  5:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22 15:46 [PATCH] ARM: dts: am5748: keep usb4_tm disabled Romain Naour
2022-08-23  5:53 ` Tony Lindgren [this message]
2022-08-23  7:30   ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwRrVI0asWtyyorZ@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rogerq@ti.com \
    --cc=romain.naour@skf.com \
    --cc=romain.naour@smile.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.