From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1 1/2] Add SAFE_SETHOSTNAME macro
Date: Tue, 23 Aug 2022 12:13:13 +0200 [thread overview]
Message-ID: <YwSoOTCv1WGIxW5O@pevik> (raw)
In-Reply-To: <20220818110117.16754-2-andrea.cervesato@suse.com>
Hi Andrea,
you forget to add safe_sethostname() into include/safe_net_fn.h
That's why there are warnings when compiled with second patch.
utsname02.c:27:2: warning: implicit declaration of function 'safe_sethostname' is invalid in C99 [-Wimplicit-function-declaration]
utsname03.c:35:2: warning: implicit declaration of function 'safe_sethostname' is invalid in C99 [-Wimplicit-function-declaration]
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-08-23 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 11:01 [LTP] [PATCH v1 0/2] Rewrite utstest testing suite Andrea Cervesato via ltp
2022-08-18 11:01 ` [LTP] [PATCH v1 1/2] Add SAFE_SETHOSTNAME macro Andrea Cervesato via ltp
2022-08-23 10:13 ` Petr Vorel [this message]
2022-08-18 11:01 ` [LTP] [PATCH v1 2/2] Rewrite utsname testing suite Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwSoOTCv1WGIxW5O@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.