From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: simatic-ipc-leds-gpio: make sure we have the GPIO providing driver
Date: Tue, 23 Aug 2022 17:15:15 +0300 [thread overview]
Message-ID: <YwTg86pKFtT0gax0@smile.fi.intel.com> (raw)
In-Reply-To: <20220805120343.5027-1-henning.schild@siemens.com>
On Fri, Aug 05, 2022 at 02:03:43PM +0200, Henning Schild wrote:
> If we register a "leds-gpio" platform device for GPIO pins that do not
> exist we get a -EPROBE_DEFER and the probe will be tried again later.
> If there is not driver to provide that pin we will poll forever and also
> create a lot of log messages.
>
> So check if that GPIO driver is configured, if so it will come up
> eventually. If not we exit our probe function early and do not even
> bother registering the "leds-gpio". This method was chosen over "Kconfig
> depends" since this way we can add support for more devices and GPIO
> backends more easily without "depends"ing on all GPIO backends.
Not sure what we should do with this patch due to your self-reply on it.
So, if it's still needed, I would expect a new version / resend.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-08-23 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 12:03 [PATCH] leds: simatic-ipc-leds-gpio: make sure we have the GPIO providing driver Henning Schild
2022-08-05 12:19 ` Henning Schild
2022-08-23 14:13 ` Andy Shevchenko
2022-08-23 14:15 ` Andy Shevchenko [this message]
2022-08-23 14:42 ` Henning Schild
2022-08-23 14:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwTg86pKFtT0gax0@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=henning.schild@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.