From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Michal Prívozník" <mprivozn@redhat.com>
Cc: Chenyi Qiang <chenyi.qiang@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
Xiaoyao Li <xiaoyao.li@intel.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH v5 1/3] Update linux headers to 6.0-rc1
Date: Tue, 23 Aug 2022 15:44:18 +0100 [thread overview]
Message-ID: <YwTnwhcy7rPM+99W@redhat.com> (raw)
In-Reply-To: <f3bc61c8-d491-f79c-15d7-191208c57224@redhat.com>
On Mon, Aug 22, 2022 at 05:00:03PM +0200, Michal Prívozník wrote:
> On 8/17/22 04:08, Chenyi Qiang wrote:
> > commit 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
> >
> > Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
> > ---
> > include/standard-headers/asm-x86/bootparam.h | 7 +-
> > include/standard-headers/drm/drm_fourcc.h | 73 +++++++-
> > include/standard-headers/linux/ethtool.h | 29 +--
> > include/standard-headers/linux/input.h | 12 +-
> > include/standard-headers/linux/pci_regs.h | 30 ++-
> > include/standard-headers/linux/vhost_types.h | 17 +-
> > include/standard-headers/linux/virtio_9p.h | 2 +-
> > .../standard-headers/linux/virtio_config.h | 7 +-
> > include/standard-headers/linux/virtio_ids.h | 14 +-
> > include/standard-headers/linux/virtio_net.h | 34 +++-
> > include/standard-headers/linux/virtio_pci.h | 2 +
> > linux-headers/asm-arm64/kvm.h | 27 +++
> > linux-headers/asm-generic/unistd.h | 4 +-
> > linux-headers/asm-riscv/kvm.h | 22 +++
> > linux-headers/asm-riscv/unistd.h | 3 +-
> > linux-headers/asm-s390/kvm.h | 1 +
> > linux-headers/asm-x86/kvm.h | 33 ++--
> > linux-headers/asm-x86/mman.h | 14 --
> > linux-headers/linux/kvm.h | 172 +++++++++++++++++-
> > linux-headers/linux/userfaultfd.h | 10 +-
> > linux-headers/linux/vduse.h | 47 +++++
> > linux-headers/linux/vfio.h | 4 +-
> > linux-headers/linux/vfio_zdev.h | 7 +
> > linux-headers/linux/vhost.h | 35 +++-
> > 24 files changed, 523 insertions(+), 83 deletions(-)
> >
>
>
> > diff --git a/linux-headers/asm-x86/kvm.h b/linux-headers/asm-x86/kvm.h
> > index bf6e96011d..46de10a809 100644
> > --- a/linux-headers/asm-x86/kvm.h
> > +++ b/linux-headers/asm-x86/kvm.h
> > @@ -198,13 +198,13 @@ struct kvm_msrs {
> > __u32 nmsrs; /* number of msrs in entries */
> > __u32 pad;
> >
> > - struct kvm_msr_entry entries[0];
> > + struct kvm_msr_entry entries[];
> > };
> >
>
> I don't think it's this simple. I think this needs to go hand in hand with kvm_arch_get_supported_msr_feature().
>
> Also, this breaks clang build:
>
> clang -m64 -mcx16 -Ilibqemu-x86_64-softmmu.fa.p -I. -I.. -Itarget/i386 -I../target/i386 -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/pixman-1 -I/usr/include/spice-server -I/usr/include/spice-1 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -fcolor-diagnostics -Wall -Winvalid-pch -Werror -std=gnu11 -O0 -g -isystem /home/zippy/work/qemu/qemu.git/linux-headers -isystem linux-headers -iquote . -iquote /home/zippy/work/qemu/qemu.git -iquote /home/zippy/work/qemu/qemu.git/include -iquote /home/zippy/work/qemu/qemu.git/tcg/i386 -pthread -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined -Wno-initializer-overrides -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-string-plus-int -Wno-typedef-redefinition -Wno-tautological-type-limit-compare -Wno-psabi -fstack-protector-strong -O0 -ggdb -fPIE -isystem../linux-headers -isystemlinux-headers -DNEED_CPU_H '-DCONFIG_TARGET="x86_64-softmmu-config-target.h"' '-DCONFIG_DEVICES="x86_64-softmmu-config-devices.h"' -MD -MQ libqemu-x86_64-softmmu.fa.p/target_i386_kvm_kvm.c.o -MF libqemu-x86_64-softmmu.fa.p/target_i386_kvm_kvm.c.o.d -o libqemu-x86_64-softmmu.fa.p/target_i386_kvm_kvm.c.o -c ../target/i386/kvm/kvm.c
> ../target/i386/kvm/kvm.c:470:25: error: field 'info' with variable sized type 'struct kvm_msrs' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
> struct kvm_msrs info;
> ^
> ../target/i386/kvm/kvm.c:1701:27: error: field 'cpuid' with variable sized type 'struct kvm_cpuid2' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
> struct kvm_cpuid2 cpuid;
> ^
> ../target/i386/kvm/kvm.c:2868:25: error: field 'info' with variable sized type 'struct kvm_msrs' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
> struct kvm_msrs info;
> ^
> 3 errors generated.
We're perfectly OK with using GNU extensions in QEMU (eg the g_auto stuff),
so IMHO just set -Wno-gnu-variable-sized-type-not-at-end to turn off this
warning that's only relevant to people striving for fully portable C
code.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-08-23 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 2:08 [PATCH v5 0/3] Enable notify VM exit Chenyi Qiang
2022-08-17 2:08 ` [PATCH v5 1/3] Update linux headers to 6.0-rc1 Chenyi Qiang
2022-08-22 15:00 ` Michal Prívozník
2022-08-23 10:09 ` Chenyi Qiang
2022-08-23 14:44 ` Daniel P. Berrangé [this message]
2022-08-17 2:08 ` [PATCH v5 2/3] i386: kvm: extend kvm_{get, put}_vcpu_events to support pending triple fault Chenyi Qiang
2022-09-09 16:11 ` Peter Xu
2022-08-17 2:08 ` [PATCH v5 3/3] i386: Add notify VM exit support Chenyi Qiang
2022-09-05 1:05 ` Chenyi Qiang
2022-09-09 16:25 ` Peter Xu
2022-09-13 1:13 ` Chenyi Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwTnwhcy7rPM+99W@redhat.com \
--to=berrange@redhat.com \
--cc=chenyi.qiang@intel.com \
--cc=eduardo@habkost.net \
--cc=kvm@vger.kernel.org \
--cc=mprivozn@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.