From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CCEFC3F6B0 for ; Tue, 23 Aug 2022 19:47:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233648AbiHWTrc (ORCPT ); Tue, 23 Aug 2022 15:47:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232471AbiHWTqy (ORCPT ); Tue, 23 Aug 2022 15:46:54 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECC2B5E66F for ; Tue, 23 Aug 2022 11:50:36 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id 20so13592199plo.10 for ; Tue, 23 Aug 2022 11:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc; bh=/6MgYQynlKjVO5yQ/ZXe7vd/aFxPZ1CaapAzvUa4a4g=; b=ikM7qhdIpjbLzfr7suns0qY6EZit4upFDcclekoxK6tByYgIRc1jLEEPVb6RPqT83i WoY7jYIligukD49jBrzQfVu2P37v2fwqfdnI/N4YOU0eaHNqobPJp/FngkZXXxZ0w/Ui ScXFhPgIIHD/ZyfVsUanwCt3unLFIIDB8UGSo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=/6MgYQynlKjVO5yQ/ZXe7vd/aFxPZ1CaapAzvUa4a4g=; b=XIeFui8VWNM08xLV2ldJPmW8GMmNUuPDFUo0EcNru+3UWOhq/kPZR0dH5IbkHsBo11 Q1l/ykNKM2H02lSjOQp0jnUVYn0DJ0KDgIYWirisHFoss1gS70iCanTyhPtI/XnPslOe ziWtl+xmK6mjQzHEO6z/XMDiW+zIwtVcD7UHo4LtCSmHwtWPZ/DLqhu8hWu+x1XpaSZk hUPJ5XtnrF0sETzFuSiDAeQ4//RiYz8ZFy/wP0690KB/K6KKRsnbNu5Q11EyrAbWBhOK QaEMxvx9Kp45M0qnnJ4KfLd9cTTOlknZnQGiHBLWFeb1CSaxQ/DpADgcY/rFwGfcOPl3 iLqA== X-Gm-Message-State: ACgBeo1C2oYcHpp993s3fb/kUMyFWt0cqqqkW1FrygkmNSa6snYdKrLo kUat/0v90P17uwJ6mfayHS2i/ehg4NpgoA== X-Google-Smtp-Source: AA6agR4PhBa4xTP/Cmb3RzX7gXe2wQgYBokWSWZsPSyAv0+QXeCgAXxsHtiwuqEXuxSK4dvlVmwU/g== X-Received: by 2002:a17:90b:3b4f:b0:1fb:5b03:6822 with SMTP id ot15-20020a17090b3b4f00b001fb5b036822mr4539924pjb.87.1661280636070; Tue, 23 Aug 2022 11:50:36 -0700 (PDT) Received: from google.com ([2620:15c:202:201:34e2:c40e:42d3:27e0]) by smtp.gmail.com with ESMTPSA id e10-20020a17090301ca00b0016e8178aa9csm10928202plh.210.2022.08.23.11.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Aug 2022 11:50:35 -0700 (PDT) Date: Tue, 23 Aug 2022 11:50:32 -0700 From: Brian Norris To: Chen Jeffy Cc: Doug Anderson , Heiko Stuebner , "open list:ARM/Rockchip SoC..." , Bartosz Golaszewski , Linus Walleij , LKML , "open list:GPIO SUBSYSTEM" , Linux ARM Subject: Re: [PATCH 2/2] gpio/rockchip: Toggle edge trigger mode after acking Message-ID: References: <20220820095933.20234-1-jeffy.chen@rock-chips.com> <20220820095933.20234-2-jeffy.chen@rock-chips.com> <5cb0a457-b667-76e5-d383-6e93457d5d12@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5cb0a457-b667-76e5-d383-6e93457d5d12@rock-chips.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi, On Tue, Aug 23, 2022 at 10:50:16AM +0800, Jeffy Chen wrote: > On 8/23 星期二 1:08, Doug Anderson wrote: > > I'm happy to let others say for sure, but from my point of view I'm > > not convinced. It feels like with your new code you could lose edges. I won't claim to know for sure either, but I'm trying to follow along, because we've dealt with various sorts of nasty logical errors in the gpio and/or irqchip areas here :) > > ...in other words an edge happened _after_ the IRQ handler ran but we > > didn't call the IRQ handler again. I don't think this is right. I believe Doug has identified one problem correctly -- that we can't handle the both-edge toggling entirely after the ack+dispatch. (out-of-order quote:) > So if an edge come in between, that new IRQ status would be acked(cleared) > in the following GPIO irq handler as well as the old one, without triggering > another IRQ demux() to toggle the trigger mode. I believe Jeffy has identified another -- that we can't handle the both-edge toggling entirely before the ack+dispatch. > Right, so guessing we could somehow move the IRQ ack into the toggling flow > to make sure that it would not clear the new IRQ? This sounds like we need the toggling to happen within the .irq_ack() callback, in between the ACK and the chain dispatch. I'm not sure I've fully walked through this yet, but would it suffice to move the 'toggle_edge_mode' loop into irq_ack(), right after writing the EOI register? That way we're in one of these cases within irq_ack(): (1) no further edges occurred after the ACK/EIO write: the toggle-loop will toggle correctly, and then we dispatch the chained handler. (2) one or more additional edges occurred after the ACK/EIO write (possibly during the toggle-loop): the loop only exits when we're sure things have quiesced, so future edges will toggle correctly (i.e., polarity is correct). We continue to dispatch the chained handler (which "handles" all these edge(s)). We may still have leave an IRQ pending (if many edges happen, racing with the toggle loop) and fire again shortly, but that's OK. Does this make sense to anyone else? > And it looks like there are quite a few drivers having this kind of need, > would it make sense to handle it in the framework? I suppose it would be possible to implement the above as a general irq_gc_ack*() helper, instead of open-coding it, although it might need the irqchip framework to gain a better understanding of a chip's polarity register. Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AA28C32772 for ; Tue, 23 Aug 2022 18:51:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zituz/hNfpAyhz6kB23tnSI06le+wy6U1r4VS9Z1m9Q=; b=kr1p1pIcEHO2IO EeODM6KLwV7RP1wWKI+R7h8LBzLg7m/KC99wNmWcB/BluX4qUGA096bIGAvvfeTBU7hZRQNyMCZUv zoYNrviA5RNATShrdZj6J1PtYJQl5UJDrKMvOe95B31E3cJ+rwjpLdEBTDJpLB1L8jQ61Z+i/NPjW UUHosC91/NGCWSuD0XHGGf8KVRsNWsU68sxWC3RRp/UQCuVPVuOd93+EybCC395S+MU93aAnrhsaV r9QjDt9dwj2tPK/JF2ZUfniowSrkQglFdQE2HFETW2KQ4UtgGHRcaNfOtzaageKY+ydF8aUucK3wT IxGMusyoB7c5ViDFIN/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQYzs-008JIL-Hf; Tue, 23 Aug 2022 18:51:32 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQYyz-008Hw8-Av for linux-rockchip@lists.infradead.org; Tue, 23 Aug 2022 18:50:39 +0000 Received: by mail-pl1-x62b.google.com with SMTP id x19so13599407plc.5 for ; Tue, 23 Aug 2022 11:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc; bh=/6MgYQynlKjVO5yQ/ZXe7vd/aFxPZ1CaapAzvUa4a4g=; b=ikM7qhdIpjbLzfr7suns0qY6EZit4upFDcclekoxK6tByYgIRc1jLEEPVb6RPqT83i WoY7jYIligukD49jBrzQfVu2P37v2fwqfdnI/N4YOU0eaHNqobPJp/FngkZXXxZ0w/Ui ScXFhPgIIHD/ZyfVsUanwCt3unLFIIDB8UGSo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=/6MgYQynlKjVO5yQ/ZXe7vd/aFxPZ1CaapAzvUa4a4g=; b=HSVMcivxrGdSQfwN9SEq9477tTjXipF/OmWdc81G9TJ8y9CCqG+fAlK2I2+HFmDZ3C Um+CZUsDhpROc0F9f3RmD9Up1DogZcCrkY8htXljvSPMczRq7P2uA4xyRu28mp5Q7niv 99gSRAoPEVbUPfvuuvdJvYJI27Alcz8xDe/Z4hXnXfy1QwNicOjFHHvPMvuu2fS6fAVd YI7B7PgjZ7eWB0ADKYcUPXPuaCxoYQbrTUn3fv1MX4/tm+KSpndwx9aQSjSgqvFe5yYz Vzx5KgIUtPd9N0oIyeXwsSVzjEIjF74LhEAKRX2rwOOXcSuzyHnfXuQWIS4DuZRzPzeR Du5A== X-Gm-Message-State: ACgBeo0PoLd3wCFypa3xAfa/8zySuMzsBMmen5E/phXPr8r0QN7ZuhHF 6RfYoqcR2j2QYRVeQoa+RiH9pg== X-Google-Smtp-Source: AA6agR4PhBa4xTP/Cmb3RzX7gXe2wQgYBokWSWZsPSyAv0+QXeCgAXxsHtiwuqEXuxSK4dvlVmwU/g== X-Received: by 2002:a17:90b:3b4f:b0:1fb:5b03:6822 with SMTP id ot15-20020a17090b3b4f00b001fb5b036822mr4539924pjb.87.1661280636070; Tue, 23 Aug 2022 11:50:36 -0700 (PDT) Received: from google.com ([2620:15c:202:201:34e2:c40e:42d3:27e0]) by smtp.gmail.com with ESMTPSA id e10-20020a17090301ca00b0016e8178aa9csm10928202plh.210.2022.08.23.11.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Aug 2022 11:50:35 -0700 (PDT) Date: Tue, 23 Aug 2022 11:50:32 -0700 From: Brian Norris To: Chen Jeffy Cc: Doug Anderson , Heiko Stuebner , "open list:ARM/Rockchip SoC..." , Bartosz Golaszewski , Linus Walleij , LKML , "open list:GPIO SUBSYSTEM" , Linux ARM Subject: Re: [PATCH 2/2] gpio/rockchip: Toggle edge trigger mode after acking Message-ID: References: <20220820095933.20234-1-jeffy.chen@rock-chips.com> <20220820095933.20234-2-jeffy.chen@rock-chips.com> <5cb0a457-b667-76e5-d383-6e93457d5d12@rock-chips.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5cb0a457-b667-76e5-d383-6e93457d5d12@rock-chips.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220823_115037_471394_05981725 X-CRM114-Status: GOOD ( 24.00 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGksCgpPbiBUdWUsIEF1ZyAyMywgMjAyMiBhdCAxMDo1MDoxNkFNICswODAwLCBKZWZmeSBDaGVu IHdyb3RlOgo+IE9uIDgvMjMg5pif5pyf5LqMIDE6MDgsIERvdWcgQW5kZXJzb24gd3JvdGU6Cj4g PiBJJ20gaGFwcHkgdG8gbGV0IG90aGVycyBzYXkgZm9yIHN1cmUsIGJ1dCBmcm9tIG15IHBvaW50 IG9mIHZpZXcgSSdtCj4gPiBub3QgY29udmluY2VkLiBJdCBmZWVscyBsaWtlIHdpdGggeW91ciBu ZXcgY29kZSB5b3UgY291bGQgbG9zZSBlZGdlcy4KCkkgd29uJ3QgY2xhaW0gdG8ga25vdyBmb3Ig c3VyZSBlaXRoZXIsIGJ1dCBJJ20gdHJ5aW5nIHRvIGZvbGxvdyBhbG9uZywKYmVjYXVzZSB3ZSd2 ZSBkZWFsdCB3aXRoIHZhcmlvdXMgc29ydHMgb2YgbmFzdHkgbG9naWNhbCBlcnJvcnMgaW4gdGhl CmdwaW8gYW5kL29yIGlycWNoaXAgYXJlYXMgaGVyZSA6KQoKPiA+IC4uLmluIG90aGVyIHdvcmRz IGFuIGVkZ2UgaGFwcGVuZWQgX2FmdGVyXyB0aGUgSVJRIGhhbmRsZXIgcmFuIGJ1dCB3ZQo+ID4g ZGlkbid0IGNhbGwgdGhlIElSUSBoYW5kbGVyIGFnYWluLiBJIGRvbid0IHRoaW5rIHRoaXMgaXMg cmlnaHQuCgpJIGJlbGlldmUgRG91ZyBoYXMgaWRlbnRpZmllZCBvbmUgcHJvYmxlbSBjb3JyZWN0 bHkgLS0gdGhhdCB3ZSBjYW4ndApoYW5kbGUgdGhlIGJvdGgtZWRnZSB0b2dnbGluZyBlbnRpcmVs eSBhZnRlciB0aGUgYWNrK2Rpc3BhdGNoLgoKKG91dC1vZi1vcmRlciBxdW90ZTopCj4gU28gaWYg YW4gZWRnZSBjb21lIGluIGJldHdlZW4sIHRoYXQgbmV3IElSUSBzdGF0dXMgd291bGQgYmUgYWNr ZWQoY2xlYXJlZCkKPiBpbiB0aGUgZm9sbG93aW5nIEdQSU8gaXJxIGhhbmRsZXIgYXMgd2VsbCBh cyB0aGUgb2xkIG9uZSwgd2l0aG91dCB0cmlnZ2VyaW5nCj4gYW5vdGhlciBJUlEgZGVtdXgoKSB0 byB0b2dnbGUgdGhlIHRyaWdnZXIgbW9kZS4KCkkgYmVsaWV2ZSBKZWZmeSBoYXMgaWRlbnRpZmll ZCBhbm90aGVyIC0tIHRoYXQgd2UgY2FuJ3QgaGFuZGxlIHRoZQpib3RoLWVkZ2UgdG9nZ2xpbmcg ZW50aXJlbHkgYmVmb3JlIHRoZSBhY2srZGlzcGF0Y2guCgo+IFJpZ2h0LCBzbyBndWVzc2luZyB3 ZSBjb3VsZCBzb21laG93IG1vdmUgdGhlIElSUSBhY2sgaW50byB0aGUgdG9nZ2xpbmcgZmxvdwo+ IHRvIG1ha2Ugc3VyZSB0aGF0IGl0IHdvdWxkIG5vdCBjbGVhciB0aGUgbmV3IElSUT8KClRoaXMg c291bmRzIGxpa2Ugd2UgbmVlZCB0aGUgdG9nZ2xpbmcgdG8gaGFwcGVuIHdpdGhpbiB0aGUgLmly cV9hY2soKQpjYWxsYmFjaywgaW4gYmV0d2VlbiB0aGUgQUNLIGFuZCB0aGUgY2hhaW4gZGlzcGF0 Y2guCgpJJ20gbm90IHN1cmUgSSd2ZSBmdWxseSB3YWxrZWQgdGhyb3VnaCB0aGlzIHlldCwgYnV0 IHdvdWxkIGl0IHN1ZmZpY2UgdG8KbW92ZSB0aGUgJ3RvZ2dsZV9lZGdlX21vZGUnIGxvb3AgaW50 byBpcnFfYWNrKCksIHJpZ2h0IGFmdGVyIHdyaXRpbmcgdGhlCkVPSSByZWdpc3Rlcj8gVGhhdCB3 YXkgd2UncmUgaW4gb25lIG9mIHRoZXNlIGNhc2VzIHdpdGhpbiBpcnFfYWNrKCk6CgooMSkgbm8g ZnVydGhlciBlZGdlcyBvY2N1cnJlZCBhZnRlciB0aGUgQUNLL0VJTyB3cml0ZTogdGhlIHRvZ2ds ZS1sb29wCndpbGwgdG9nZ2xlIGNvcnJlY3RseSwgYW5kIHRoZW4gd2UgZGlzcGF0Y2ggdGhlIGNo YWluZWQgaGFuZGxlci4KCigyKSBvbmUgb3IgbW9yZSBhZGRpdGlvbmFsIGVkZ2VzIG9jY3VycmVk IGFmdGVyIHRoZSBBQ0svRUlPIHdyaXRlCihwb3NzaWJseSBkdXJpbmcgdGhlIHRvZ2dsZS1sb29w KTogdGhlIGxvb3Agb25seSBleGl0cyB3aGVuIHdlJ3JlIHN1cmUKdGhpbmdzIGhhdmUgcXVpZXNj ZWQsIHNvIGZ1dHVyZSBlZGdlcyB3aWxsIHRvZ2dsZSBjb3JyZWN0bHkgKGkuZS4sCnBvbGFyaXR5 IGlzIGNvcnJlY3QpLiBXZSBjb250aW51ZSB0byBkaXNwYXRjaCB0aGUgY2hhaW5lZCBoYW5kbGVy ICh3aGljaAoiaGFuZGxlcyIgYWxsIHRoZXNlIGVkZ2UocykpLiBXZSBtYXkgc3RpbGwgaGF2ZSBs ZWF2ZSBhbiBJUlEgcGVuZGluZyAoaWYKbWFueSBlZGdlcyBoYXBwZW4sIHJhY2luZyB3aXRoIHRo ZSB0b2dnbGUgbG9vcCkgYW5kIGZpcmUgYWdhaW4gc2hvcnRseSwKYnV0IHRoYXQncyBPSy4KCkRv ZXMgdGhpcyBtYWtlIHNlbnNlIHRvIGFueW9uZSBlbHNlPwoKPiBBbmQgaXQgbG9va3MgbGlrZSB0 aGVyZSBhcmUgcXVpdGUgYSBmZXcgZHJpdmVycyBoYXZpbmcgdGhpcyBraW5kIG9mIG5lZWQsCj4g d291bGQgaXQgbWFrZSBzZW5zZSB0byBoYW5kbGUgaXQgaW4gdGhlIGZyYW1ld29yaz8KCkkgc3Vw cG9zZSBpdCB3b3VsZCBiZSBwb3NzaWJsZSB0byBpbXBsZW1lbnQgdGhlIGFib3ZlIGFzIGEgZ2Vu ZXJhbAppcnFfZ2NfYWNrKigpIGhlbHBlciwgaW5zdGVhZCBvZiBvcGVuLWNvZGluZyBpdCwgYWx0 aG91Z2ggaXQgbWlnaHQgbmVlZAp0aGUgaXJxY2hpcCBmcmFtZXdvcmsgdG8gZ2FpbiBhIGJldHRl ciB1bmRlcnN0YW5kaW5nIG9mIGEgY2hpcCdzCnBvbGFyaXR5IHJlZ2lzdGVyLgoKQnJpYW4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tj aGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 900B7C3F6B0 for ; Tue, 23 Aug 2022 18:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dh/q1sPusZhJtBHxavxZyPeyGN4DwpFTi3pdFVhSajI=; b=z2RYLDvp0zW0ya zEgIr74kp9DApLZAtw7Azl33sMKbur0/5beIrri/R95gXmdS+CQaYCeRo2EdOIjv7FZvry+0j/DcZ RCzIUAhNZZF8uWqdmHDaLlrIQ5ZkQYUXHvgLUIdSBvetBpdYCg2kNsdlskHMHQcdEUVgq+Ic7JZjj rmFIpjU1O1PKFuSxYEmLCjH/pvVc5HPMrGnFSHLy34VkJkkv2aJxFUAcEELbpwLIG1O11l/39hu+/ YivfycxZlwhEWVPyyiUItEKF9381BNL9fmwXn6MnBFDwZqQMcmvAR4gJWBdZ8+cZmbCetWxK2UoUx gTCmyjKaXChz9rDKCoXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQYzw-008JKK-54; Tue, 23 Aug 2022 18:51:36 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQYyz-008HwA-JM for linux-arm-kernel@lists.infradead.org; Tue, 23 Aug 2022 18:50:40 +0000 Received: by mail-pj1-x102b.google.com with SMTP id f21so14812700pjt.2 for ; Tue, 23 Aug 2022 11:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc; bh=/6MgYQynlKjVO5yQ/ZXe7vd/aFxPZ1CaapAzvUa4a4g=; b=ikM7qhdIpjbLzfr7suns0qY6EZit4upFDcclekoxK6tByYgIRc1jLEEPVb6RPqT83i WoY7jYIligukD49jBrzQfVu2P37v2fwqfdnI/N4YOU0eaHNqobPJp/FngkZXXxZ0w/Ui ScXFhPgIIHD/ZyfVsUanwCt3unLFIIDB8UGSo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=/6MgYQynlKjVO5yQ/ZXe7vd/aFxPZ1CaapAzvUa4a4g=; b=Vwd+oF4/SRWSCWvVFAwTKEf0o3NW0TslNML4K3M6oM92VjDzB0mBQxXgW08++sucMS sLurh1SEMoIYFwkoB4Jk+vFt3St/yMVHlEnGBKtBPVDwEcwZuZbArdmJy9TZcYi7tyZs vOPd6fadVyJ0AOe2eOuDaYN7Xsg5+zS/2QJMnoWczQr80AQ6WF+0vZGzrdgDBMZ574Zi MrDPknmBMh+jCMexoN7uDKsZUb5kD6QxqqTxt+QJ7mMaIIh9wduqj3mpjfOgJ4OuA/1J oXxnqdrFI7hWLy5w4t1ivNjjiD9a6pS8VplqS3K6KQvikAgqNS9eINSmmD/nIj1nY6zt iKDA== X-Gm-Message-State: ACgBeo34K4NEic7cg8Ph/8QT5KWQpyAq4CniBDbrLoejzWjY8X/pHk3z oxj94Ah5p6zl8ShKL5jnYUcivw== X-Google-Smtp-Source: AA6agR4PhBa4xTP/Cmb3RzX7gXe2wQgYBokWSWZsPSyAv0+QXeCgAXxsHtiwuqEXuxSK4dvlVmwU/g== X-Received: by 2002:a17:90b:3b4f:b0:1fb:5b03:6822 with SMTP id ot15-20020a17090b3b4f00b001fb5b036822mr4539924pjb.87.1661280636070; Tue, 23 Aug 2022 11:50:36 -0700 (PDT) Received: from google.com ([2620:15c:202:201:34e2:c40e:42d3:27e0]) by smtp.gmail.com with ESMTPSA id e10-20020a17090301ca00b0016e8178aa9csm10928202plh.210.2022.08.23.11.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Aug 2022 11:50:35 -0700 (PDT) Date: Tue, 23 Aug 2022 11:50:32 -0700 From: Brian Norris To: Chen Jeffy Cc: Doug Anderson , Heiko Stuebner , "open list:ARM/Rockchip SoC..." , Bartosz Golaszewski , Linus Walleij , LKML , "open list:GPIO SUBSYSTEM" , Linux ARM Subject: Re: [PATCH 2/2] gpio/rockchip: Toggle edge trigger mode after acking Message-ID: References: <20220820095933.20234-1-jeffy.chen@rock-chips.com> <20220820095933.20234-2-jeffy.chen@rock-chips.com> <5cb0a457-b667-76e5-d383-6e93457d5d12@rock-chips.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5cb0a457-b667-76e5-d383-6e93457d5d12@rock-chips.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220823_115037_677202_DCD2BE39 X-CRM114-Status: GOOD ( 25.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiBUdWUsIEF1ZyAyMywgMjAyMiBhdCAxMDo1MDoxNkFNICswODAwLCBKZWZmeSBDaGVu IHdyb3RlOgo+IE9uIDgvMjMg5pif5pyf5LqMIDE6MDgsIERvdWcgQW5kZXJzb24gd3JvdGU6Cj4g PiBJJ20gaGFwcHkgdG8gbGV0IG90aGVycyBzYXkgZm9yIHN1cmUsIGJ1dCBmcm9tIG15IHBvaW50 IG9mIHZpZXcgSSdtCj4gPiBub3QgY29udmluY2VkLiBJdCBmZWVscyBsaWtlIHdpdGggeW91ciBu ZXcgY29kZSB5b3UgY291bGQgbG9zZSBlZGdlcy4KCkkgd29uJ3QgY2xhaW0gdG8ga25vdyBmb3Ig c3VyZSBlaXRoZXIsIGJ1dCBJJ20gdHJ5aW5nIHRvIGZvbGxvdyBhbG9uZywKYmVjYXVzZSB3ZSd2 ZSBkZWFsdCB3aXRoIHZhcmlvdXMgc29ydHMgb2YgbmFzdHkgbG9naWNhbCBlcnJvcnMgaW4gdGhl CmdwaW8gYW5kL29yIGlycWNoaXAgYXJlYXMgaGVyZSA6KQoKPiA+IC4uLmluIG90aGVyIHdvcmRz IGFuIGVkZ2UgaGFwcGVuZWQgX2FmdGVyXyB0aGUgSVJRIGhhbmRsZXIgcmFuIGJ1dCB3ZQo+ID4g ZGlkbid0IGNhbGwgdGhlIElSUSBoYW5kbGVyIGFnYWluLiBJIGRvbid0IHRoaW5rIHRoaXMgaXMg cmlnaHQuCgpJIGJlbGlldmUgRG91ZyBoYXMgaWRlbnRpZmllZCBvbmUgcHJvYmxlbSBjb3JyZWN0 bHkgLS0gdGhhdCB3ZSBjYW4ndApoYW5kbGUgdGhlIGJvdGgtZWRnZSB0b2dnbGluZyBlbnRpcmVs eSBhZnRlciB0aGUgYWNrK2Rpc3BhdGNoLgoKKG91dC1vZi1vcmRlciBxdW90ZTopCj4gU28gaWYg YW4gZWRnZSBjb21lIGluIGJldHdlZW4sIHRoYXQgbmV3IElSUSBzdGF0dXMgd291bGQgYmUgYWNr ZWQoY2xlYXJlZCkKPiBpbiB0aGUgZm9sbG93aW5nIEdQSU8gaXJxIGhhbmRsZXIgYXMgd2VsbCBh cyB0aGUgb2xkIG9uZSwgd2l0aG91dCB0cmlnZ2VyaW5nCj4gYW5vdGhlciBJUlEgZGVtdXgoKSB0 byB0b2dnbGUgdGhlIHRyaWdnZXIgbW9kZS4KCkkgYmVsaWV2ZSBKZWZmeSBoYXMgaWRlbnRpZmll ZCBhbm90aGVyIC0tIHRoYXQgd2UgY2FuJ3QgaGFuZGxlIHRoZQpib3RoLWVkZ2UgdG9nZ2xpbmcg ZW50aXJlbHkgYmVmb3JlIHRoZSBhY2srZGlzcGF0Y2guCgo+IFJpZ2h0LCBzbyBndWVzc2luZyB3 ZSBjb3VsZCBzb21laG93IG1vdmUgdGhlIElSUSBhY2sgaW50byB0aGUgdG9nZ2xpbmcgZmxvdwo+ IHRvIG1ha2Ugc3VyZSB0aGF0IGl0IHdvdWxkIG5vdCBjbGVhciB0aGUgbmV3IElSUT8KClRoaXMg c291bmRzIGxpa2Ugd2UgbmVlZCB0aGUgdG9nZ2xpbmcgdG8gaGFwcGVuIHdpdGhpbiB0aGUgLmly cV9hY2soKQpjYWxsYmFjaywgaW4gYmV0d2VlbiB0aGUgQUNLIGFuZCB0aGUgY2hhaW4gZGlzcGF0 Y2guCgpJJ20gbm90IHN1cmUgSSd2ZSBmdWxseSB3YWxrZWQgdGhyb3VnaCB0aGlzIHlldCwgYnV0 IHdvdWxkIGl0IHN1ZmZpY2UgdG8KbW92ZSB0aGUgJ3RvZ2dsZV9lZGdlX21vZGUnIGxvb3AgaW50 byBpcnFfYWNrKCksIHJpZ2h0IGFmdGVyIHdyaXRpbmcgdGhlCkVPSSByZWdpc3Rlcj8gVGhhdCB3 YXkgd2UncmUgaW4gb25lIG9mIHRoZXNlIGNhc2VzIHdpdGhpbiBpcnFfYWNrKCk6CgooMSkgbm8g ZnVydGhlciBlZGdlcyBvY2N1cnJlZCBhZnRlciB0aGUgQUNLL0VJTyB3cml0ZTogdGhlIHRvZ2ds ZS1sb29wCndpbGwgdG9nZ2xlIGNvcnJlY3RseSwgYW5kIHRoZW4gd2UgZGlzcGF0Y2ggdGhlIGNo YWluZWQgaGFuZGxlci4KCigyKSBvbmUgb3IgbW9yZSBhZGRpdGlvbmFsIGVkZ2VzIG9jY3VycmVk IGFmdGVyIHRoZSBBQ0svRUlPIHdyaXRlCihwb3NzaWJseSBkdXJpbmcgdGhlIHRvZ2dsZS1sb29w KTogdGhlIGxvb3Agb25seSBleGl0cyB3aGVuIHdlJ3JlIHN1cmUKdGhpbmdzIGhhdmUgcXVpZXNj ZWQsIHNvIGZ1dHVyZSBlZGdlcyB3aWxsIHRvZ2dsZSBjb3JyZWN0bHkgKGkuZS4sCnBvbGFyaXR5 IGlzIGNvcnJlY3QpLiBXZSBjb250aW51ZSB0byBkaXNwYXRjaCB0aGUgY2hhaW5lZCBoYW5kbGVy ICh3aGljaAoiaGFuZGxlcyIgYWxsIHRoZXNlIGVkZ2UocykpLiBXZSBtYXkgc3RpbGwgaGF2ZSBs ZWF2ZSBhbiBJUlEgcGVuZGluZyAoaWYKbWFueSBlZGdlcyBoYXBwZW4sIHJhY2luZyB3aXRoIHRo ZSB0b2dnbGUgbG9vcCkgYW5kIGZpcmUgYWdhaW4gc2hvcnRseSwKYnV0IHRoYXQncyBPSy4KCkRv ZXMgdGhpcyBtYWtlIHNlbnNlIHRvIGFueW9uZSBlbHNlPwoKPiBBbmQgaXQgbG9va3MgbGlrZSB0 aGVyZSBhcmUgcXVpdGUgYSBmZXcgZHJpdmVycyBoYXZpbmcgdGhpcyBraW5kIG9mIG5lZWQsCj4g d291bGQgaXQgbWFrZSBzZW5zZSB0byBoYW5kbGUgaXQgaW4gdGhlIGZyYW1ld29yaz8KCkkgc3Vw cG9zZSBpdCB3b3VsZCBiZSBwb3NzaWJsZSB0byBpbXBsZW1lbnQgdGhlIGFib3ZlIGFzIGEgZ2Vu ZXJhbAppcnFfZ2NfYWNrKigpIGhlbHBlciwgaW5zdGVhZCBvZiBvcGVuLWNvZGluZyBpdCwgYWx0 aG91Z2ggaXQgbWlnaHQgbmVlZAp0aGUgaXJxY2hpcCBmcmFtZXdvcmsgdG8gZ2FpbiBhIGJldHRl ciB1bmRlcnN0YW5kaW5nIG9mIGEgY2hpcCdzCnBvbGFyaXR5IHJlZ2lzdGVyLgoKQnJpYW4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK