From: Al Viro <viro@zeniv.linux.org.uk>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
James Smart <james.smart@broadcom.com>,
Ira Weiny <ira.weiny@intel.com>,
"Venkataramanan, Anirudh" <anirudh.venkataramanan@intel.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH v3 1/1] nvmet-tcp: Don't kmap() pages which can't come from HIGHMEM
Date: Wed, 24 Aug 2022 00:32:53 +0100 [thread overview]
Message-ID: <YwVjpTW6vWvdVQTK@ZenIV> (raw)
In-Reply-To: <20220822142438.5954-2-fmdefrancesco@gmail.com>
On Mon, Aug 22, 2022 at 04:24:38PM +0200, Fabio M. De Francesco wrote:
> Therefore, replace the kmap() of sg_page(sg) with a page_address() and
> delete the "nr_mapped" field from "nvmet_tcp_cmd" and instead pass a
> local variable to iov_iter_kvec() from the call site in
> nvmet_tcp_map_pdu_iovec().
I'd suggest looking into switching to ITER_BVEC...
next prev parent reply other threads:[~2022-08-23 23:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 14:24 [PATCH v3 0/1] Don't kmap() pages which can't come from HIGHMEM Fabio M. De Francesco
2022-08-22 14:24 ` [PATCH v3 1/1] nvmet-tcp: " Fabio M. De Francesco
2022-08-23 23:32 ` Al Viro [this message]
2022-08-26 18:16 ` Fabio M. De Francesco
2022-08-26 18:35 ` Keith Busch
2022-08-26 19:35 ` Al Viro
2022-08-26 19:32 ` Al Viro
2022-08-28 14:31 ` Sagi Grimberg
2022-08-30 20:06 ` Fabio M. De Francesco
2022-08-31 23:48 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwVjpTW6vWvdVQTK@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=anirudh.venkataramanan@intel.com \
--cc=chaitanyak@nvidia.com \
--cc=fmdefrancesco@gmail.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.