From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Bart Van Assche <bvanassche@acm.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [for-linus][PATCH 01/10] tracing: Suppress sparse warnings triggered by is_signed_type()
Date: Wed, 24 Aug 2022 04:20:04 +0100 [thread overview]
Message-ID: <YwWY5KrhY0RGpC4l@ZenIV> (raw)
In-Reply-To: <YwWWoQXmVc8uasBh@ZenIV>
On Wed, Aug 24, 2022 at 04:10:25AM +0100, Al Viro wrote:
> *IF* you want to go that way, I would suggest a new return value for
> restricted_binop() ("comparison with magical value"), with
> something like
> switch (restricted_binop(op, ctype)) {
> case 1:
> ....
>
> default:
> break;
> case 4:
> // comparison with magic value:
> // quietly go for underlying type, if not fouled
> // if fouled, just return NULL and let the caller
> // deal with that - loudly.
> if (!(lclass & rclass & TYPE_FOULED))
if (!((lclass | rclass) & TYPE_FOULED))
that is - we don't need both of them being fouled to trigger a warning;
either one should suffice.
next prev parent reply other threads:[~2022-08-24 3:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 0:07 [for-linus][PATCH 00/10] tracing: Fixes for 6.0 Steven Rostedt
2022-08-21 0:07 ` [for-linus][PATCH 01/10] tracing: Suppress sparse warnings triggered by is_signed_type() Steven Rostedt
2022-08-21 18:35 ` Linus Torvalds
2022-08-21 19:55 ` Steven Rostedt
2022-08-22 18:20 ` Bart Van Assche
2022-08-22 18:45 ` Linus Torvalds
2022-08-22 20:19 ` Bart Van Assche
2022-08-23 7:06 ` Rasmus Villemoes
2022-08-23 22:05 ` Bart Van Assche
2022-08-23 23:18 ` Linus Torvalds
2022-08-23 23:57 ` Linus Torvalds
2022-08-24 2:09 ` Al Viro
2022-08-24 2:16 ` Linus Torvalds
2022-08-24 3:10 ` Al Viro
2022-08-24 3:20 ` Al Viro [this message]
2022-08-24 5:56 ` Linus Torvalds
2022-08-24 0:09 ` Bart Van Assche
2022-08-24 1:49 ` Linus Torvalds
2022-08-24 2:11 ` Linus Torvalds
2022-08-24 3:47 ` Bart Van Assche
2022-08-24 3:46 ` Bart Van Assche
2022-08-24 23:28 ` Bart Van Assche
2022-08-25 0:30 ` Linus Torvalds
2022-08-25 0:40 ` Linus Torvalds
2022-08-25 7:57 ` Rasmus Villemoes
2022-08-25 8:07 ` Linus Torvalds
2022-08-25 17:39 ` Bart Van Assche
2022-08-25 18:17 ` Kees Cook
2022-08-21 0:07 ` [for-linus][PATCH 02/10] tracing: React to error return from traceprobe_parse_event_name() Steven Rostedt
2022-08-21 0:07 ` [for-linus][PATCH 03/10] tracing/perf: Fix double put of trace event when init fails Steven Rostedt
2022-08-21 0:07 ` [for-linus][PATCH 04/10] ftrace: Fix NULL pointer dereference in is_ftrace_trampoline when ftrace is dead Steven Rostedt
2022-08-21 0:07 ` [for-linus][PATCH 05/10] tracing/eprobes: Do not allow eprobes to use $stack, or % for regs Steven Rostedt
2022-08-21 0:07 ` [for-linus][PATCH 06/10] tracing/eprobes: Do not hardcode $comm as a string Steven Rostedt
2022-08-21 0:07 ` [for-linus][PATCH 07/10] tracing/eprobes: Fix reading of string fields Steven Rostedt
2022-08-21 0:07 ` [for-linus][PATCH 08/10] tracing/eprobes: Have event probes be consistent with kprobes and uprobes Steven Rostedt
2022-08-21 0:07 ` [for-linus][PATCH 09/10] tracing/probes: Have kprobes and uprobes use $COMM too Steven Rostedt
2022-08-21 0:07 ` [for-linus][PATCH 10/10] tracing: Have filter accept "common_cpu" to be consistent Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwWY5KrhY0RGpC4l@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luc.vanoostenryck@gmail.com \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.