From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80F56C00140 for ; Wed, 24 Aug 2022 10:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HRIDm1cxENKcoQJH0Wd7hWE03BReYEtKK+awOe/krPk=; b=gXW8q9WqKczhDB qVqewhWCzIk0c6qqquLHzxMD3EkWDQ7HY10zTJ0k/PKIZ1GAILfM4tEjfcDA9tlJDN/LR9PlwuTbQ LsAwBDmnqX7csXW2adVXaysYT5ccox0WfhWp2ucR05t6c2VODl+0Waau8dc1cPyS6cxln6e9Z5uRm 6N6oML7Aok3Qa8oEPFTdewlPwoXbMdoxZPIPCWzvQLxHcxtlrbFdXbRnENqB0udoOILA8lmuBW94N rIUXLRkfkPQ5VhIG47wGDxVxJhMN2nyaSqShClu0dJXKrXRhHR2YeRJmituvGkn0F29Vu8ZdkYBIC 2YnVCKBi1XakZ+Skzr1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQnue-00CByu-Hy; Wed, 24 Aug 2022 10:47:08 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQnt7-00CB01-5r for linux-arm-kernel@lists.infradead.org; Wed, 24 Aug 2022 10:45:34 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 727FE80CF; Wed, 24 Aug 2022 10:38:19 +0000 (UTC) Date: Wed, 24 Aug 2022 13:45:27 +0300 From: Tony Lindgren To: Nishanth Menon Cc: Vignesh Raghavendra , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Keerthy Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am65: Add general purpose timers for am65 Message-ID: References: <20220407104725.41755-1-tony@atomide.com> <20220407104725.41755-2-tony@atomide.com> <20220706232157.thvbsr6emvyy6i5o@resend> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220824_034533_294946_5B2C0360 X-CRM114-Status: GOOD ( 16.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Tony Lindgren [220815 16:03]: > Hi, > > * Nishanth Menon [220706 23:16]: > > On 13:47-20220407, Tony Lindgren wrote: > > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > > > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > > > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > > > @@ -271,6 +271,114 @@ main_spi4: spi@2140000 { > > > #size-cells = <0>; > > > }; > > > > > > + main_timer0: timer@2400000 { > > > + compatible = "ti,am6-timer"; > > > + reg = <0x00 0x2400000 0x00 0x400>; > > > + interrupts = ; > > > + clocks = <&k3_clks 23 12>; > > > + clock-names = "fck"; > > > + ti,timer-pwm; > > > + }; > > > > Tony, > > Lets hold this back one more window.. ti,am6-timer should come > > in the next rc1, but I still dont see this yet in next-20220706, So, i am > > going to have to skip this window at least. > > I'm seeing the clock being too fast although debugfs reports the timer > source clock at 32k. Not quite sure what is wrong, maybe the clock index > should be 1 instead of 12 here. Best to wait with the dts patches until > the clock issue has bee sorted out. FYI the issue was caused by a wrong clock configuration. To use the 32k source as the default clock for main_timer0: clocks = <&k3_clks 23 0>; clock-names = "fck"; assigned-clocks = <&k3_clks 23 0>; assigned-clock-parents = <&k3_clks 23 12>; Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26A96C32796 for ; Wed, 24 Aug 2022 10:46:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236160AbiHXKqm (ORCPT ); Wed, 24 Aug 2022 06:46:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236437AbiHXKq0 (ORCPT ); Wed, 24 Aug 2022 06:46:26 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8C2C4832E4 for ; Wed, 24 Aug 2022 03:45:44 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 727FE80CF; Wed, 24 Aug 2022 10:38:19 +0000 (UTC) Date: Wed, 24 Aug 2022 13:45:27 +0300 From: Tony Lindgren To: Nishanth Menon Cc: Vignesh Raghavendra , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Keerthy Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am65: Add general purpose timers for am65 Message-ID: References: <20220407104725.41755-1-tony@atomide.com> <20220407104725.41755-2-tony@atomide.com> <20220706232157.thvbsr6emvyy6i5o@resend> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * Tony Lindgren [220815 16:03]: > Hi, > > * Nishanth Menon [220706 23:16]: > > On 13:47-20220407, Tony Lindgren wrote: > > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > > > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > > > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > > > @@ -271,6 +271,114 @@ main_spi4: spi@2140000 { > > > #size-cells = <0>; > > > }; > > > > > > + main_timer0: timer@2400000 { > > > + compatible = "ti,am6-timer"; > > > + reg = <0x00 0x2400000 0x00 0x400>; > > > + interrupts = ; > > > + clocks = <&k3_clks 23 12>; > > > + clock-names = "fck"; > > > + ti,timer-pwm; > > > + }; > > > > Tony, > > Lets hold this back one more window.. ti,am6-timer should come > > in the next rc1, but I still dont see this yet in next-20220706, So, i am > > going to have to skip this window at least. > > I'm seeing the clock being too fast although debugfs reports the timer > source clock at 32k. Not quite sure what is wrong, maybe the clock index > should be 1 instead of 12 here. Best to wait with the dts patches until > the clock issue has bee sorted out. FYI the issue was caused by a wrong clock configuration. To use the 32k source as the default clock for main_timer0: clocks = <&k3_clks 23 0>; clock-names = "fck"; assigned-clocks = <&k3_clks 23 0>; assigned-clock-parents = <&k3_clks 23 12>; Regards, Tony