From: Andrew Lunn <andrew@lunn.ch>
To: Sergei Antonov <saproj@gmail.com>
Cc: netdev@vger.kernel.org, olteanv@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
tangbin@cmss.chinamobile.com, caizhichao@yulong.com
Subject: Re: [PATCH net-next] net: ftmac100: add an opportunity to get ethaddr from the platform
Date: Wed, 24 Aug 2022 17:32:42 +0200 [thread overview]
Message-ID: <YwZEmo9sVds8CJdD@lunn.ch> (raw)
In-Reply-To: <20220824151724.2698107-1-saproj@gmail.com>
On Wed, Aug 24, 2022 at 06:17:24PM +0300, Sergei Antonov wrote:
> This driver always generated a random ethernet address. Leave it as a
> fallback solution, but add a call to platform_get_ethdev_address().
> Handle EPROBE_DEFER returned from platform_get_ethdev_address() to
> retry when EEPROM is ready.
Hi Sergei
This is version 2 correct, you added -EPROBE_DEFER handling?
Please add a v2 into the Subject "[PATCH v2 net-next]" so we can keep
track of the different versions.
Also, list briefly under the --- what you changed with each version.
It is worth reading:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
and
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2022-08-24 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 15:17 [PATCH net-next] net: ftmac100: add an opportunity to get ethaddr from the platform Sergei Antonov
2022-08-24 15:32 ` Andrew Lunn [this message]
2022-08-24 15:40 ` Sergei Antonov
2022-08-24 16:14 ` Andrew Lunn
2022-08-27 2:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwZEmo9sVds8CJdD@lunn.ch \
--to=andrew@lunn.ch \
--cc=caizhichao@yulong.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=saproj@gmail.com \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.