All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Daniil Tatianin <d-tatianin@yandex-team.ru>
Cc: qemu-devel@nongnu.org, mst@redhat.com,
	raphael.norwitz@nutanix.com, kwolf@redhat.com, hreitz@redhat.com,
	qemu-block@nongnu.org, yc-core@yandex-team.ru
Subject: Re: [PATCH v1 4/5] vhost-user-blk: make 'config_wce' part of 'host_features'
Date: Wed, 24 Aug 2022 14:01:32 -0400	[thread overview]
Message-ID: <YwZnfM9MzHgTPFSt@fedora> (raw)
In-Reply-To: <20220824091837.301708-5-d-tatianin@yandex-team.ru>

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

On Wed, Aug 24, 2022 at 12:18:36PM +0300, Daniil Tatianin wrote:
> @@ -591,7 +588,8 @@ static Property vhost_user_blk_properties[] = {
>      DEFINE_PROP_UINT16("num-queues", VHostUserBlk, num_queues,
>                         VHOST_USER_BLK_AUTO_NUM_QUEUES),
>      DEFINE_PROP_UINT32("queue-size", VHostUserBlk, queue_size, 128),
> -    DEFINE_PROP_BIT("config-wce", VHostUserBlk, config_wce, 0, true),
> +    DEFINE_PROP_BIT64("config-wce", VHostUserBlk, host_features,
> +                      VIRTIO_BLK_F_CONFIG_WCE, true),

Please use parent_obj.host_features instead of a VHostUserBlk
host_features field.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-08-24 18:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-24  9:18 [PATCH v1 0/5] vhost-user-blk: dynamically resize config space based on features Daniil Tatianin
2022-08-24  9:18 ` [PATCH v1 1/5] virtio-blk: decouple config size determination code from VirtIOBlock Daniil Tatianin
2022-08-24  9:18 ` [PATCH v1 2/5] virtio-blk: move config space sizing code to virtio-blk-common Daniil Tatianin
2022-08-24 18:13   ` Stefan Hajnoczi
2022-08-24 21:11     ` Daniil Tatianin
2022-08-25 13:45       ` Stefan Hajnoczi
2022-08-24  9:18 ` [PATCH v1 3/5] vhost-user-blk: make it possible to disable write-zeroes/discard Daniil Tatianin
2022-08-24 18:00   ` Stefan Hajnoczi
2022-08-24 20:24     ` Daniil Tatianin
2022-08-25 13:34       ` Stefan Hajnoczi
2022-08-24  9:18 ` [PATCH v1 4/5] vhost-user-blk: make 'config_wce' part of 'host_features' Daniil Tatianin
2022-08-24 18:01   ` Stefan Hajnoczi [this message]
2022-08-24  9:18 ` [PATCH v1 5/5] vhost-user-blk: dynamically resize config space based on features Daniil Tatianin
2022-08-24 18:28   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwZnfM9MzHgTPFSt@fedora \
    --to=stefanha@redhat.com \
    --cc=d-tatianin@yandex-team.ru \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=raphael.norwitz@nutanix.com \
    --cc=yc-core@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.