From: Chris Carbone <chris.m.carbone@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: split multiple assignments to lines
Date: Wed, 24 Aug 2022 20:16:14 -0400 [thread overview]
Message-ID: <Ywa/TiT46IH4vDw0@valhalla> (raw)
In-Reply-To: <YwRzJN5yORAtq8md@kroah.com>
On Tue, Aug 23, 2022 at 08:26:44AM +0200, Greg KH wrote:
> On Mon, Aug 22, 2022 at 06:42:48PM -0400, Christopher Carbone wrote:
> >
> > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> > index dbd1159a2ef0..6f4c31635cc4 100644
> > --- a/drivers/staging/sm750fb/sm750.c
> > +++ b/drivers/staging/sm750fb/sm750.c
> > @@ -386,7 +386,8 @@ static int lynxfb_ops_set_par(struct fb_info *info)
> >
> > ret = lynxfb_set_color_offsets(info);
> >
> > - var->height = var->width = -1;
> > + var->height = -1;
>
> Odd spacing on this new line. Did you run your change through
> checkpatch?
Yes; checkpatch didn't report any problems with it.
Thank you for your time,
Chris Carbone
prev parent reply other threads:[~2022-08-25 0:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 22:42 [PATCH] staging: sm750fb: split multiple assignments to lines Christopher Carbone
2022-08-23 6:26 ` Greg KH
2022-08-25 0:16 ` Chris Carbone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywa/TiT46IH4vDw0@valhalla \
--to=chris.m.carbone@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.