From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>, Pavel Machek <pavel@ucw.cz>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>, Lee Jones <lee@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
Sheng-Yuan Huang <syhuang3@nuvoton.com>,
Tasanakorn Phaipool <tasanakorn@gmail.com>,
simon.guinot@sequanux.org
Subject: Re: [PATCH v6 2/7] gpio-f7188x: add a prefix to macros to keep gpio namespace clean
Date: Thu, 25 Aug 2022 14:20:31 +0300 [thread overview]
Message-ID: <Ywda/0DQIpAjPa8f@smile.fi.intel.com> (raw)
In-Reply-To: <20220825104422.14156-3-henning.schild@siemens.com>
On Thu, Aug 25, 2022 at 12:44:17PM +0200, Henning Schild wrote:
> Subsequent patches will touch that file, apply some nice to have style
> changes before actually adding functional changes.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
> drivers/gpio/gpio-f7188x.c | 36 ++++++++++++++++++------------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
> index fef539bbc03a..878458249833 100644
> --- a/drivers/gpio/gpio-f7188x.c
> +++ b/drivers/gpio/gpio-f7188x.c
> @@ -165,11 +165,11 @@ static int f7188x_gpio_set_config(struct gpio_chip *chip, unsigned offset,
> .regbase = _regbase, \
> }
>
> -#define gpio_dir(base) (base + 0)
> -#define gpio_data_out(base) (base + 1)
> -#define gpio_data_in(base) (base + 2)
> +#define f7188x_gpio_dir(base) ((base) + 0)
> +#define f7188x_gpio_data_out(base) ((base) + 1)
> +#define f7188x_gpio_data_in(base) ((base) + 2)
> /* Output mode register (0:open drain 1:push-pull). */
> -#define gpio_out_mode(base) (base + 3)
> +#define f7188x_gpio_out_mode(base) ((base) + 3)
>
> static struct f7188x_gpio_bank f71869_gpio_bank[] = {
> F7188X_GPIO_BANK(0, 6, 0xF0),
> @@ -267,7 +267,7 @@ static int f7188x_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
> return err;
> superio_select(sio->addr, SIO_LD_GPIO);
>
> - dir = superio_inb(sio->addr, gpio_dir(bank->regbase));
> + dir = superio_inb(sio->addr, f7188x_gpio_dir(bank->regbase));
>
> superio_exit(sio->addr);
>
> @@ -289,9 +289,9 @@ static int f7188x_gpio_direction_in(struct gpio_chip *chip, unsigned offset)
> return err;
> superio_select(sio->addr, SIO_LD_GPIO);
>
> - dir = superio_inb(sio->addr, gpio_dir(bank->regbase));
> + dir = superio_inb(sio->addr, f7188x_gpio_dir(bank->regbase));
> dir &= ~BIT(offset);
> - superio_outb(sio->addr, gpio_dir(bank->regbase), dir);
> + superio_outb(sio->addr, f7188x_gpio_dir(bank->regbase), dir);
>
> superio_exit(sio->addr);
>
> @@ -310,12 +310,12 @@ static int f7188x_gpio_get(struct gpio_chip *chip, unsigned offset)
> return err;
> superio_select(sio->addr, SIO_LD_GPIO);
>
> - dir = superio_inb(sio->addr, gpio_dir(bank->regbase));
> + dir = superio_inb(sio->addr, f7188x_gpio_dir(bank->regbase));
> dir = !!(dir & BIT(offset));
> if (dir)
> - data = superio_inb(sio->addr, gpio_data_out(bank->regbase));
> + data = superio_inb(sio->addr, f7188x_gpio_data_out(bank->regbase));
> else
> - data = superio_inb(sio->addr, gpio_data_in(bank->regbase));
> + data = superio_inb(sio->addr, f7188x_gpio_data_in(bank->regbase));
>
> superio_exit(sio->addr);
>
> @@ -335,16 +335,16 @@ static int f7188x_gpio_direction_out(struct gpio_chip *chip,
> return err;
> superio_select(sio->addr, SIO_LD_GPIO);
>
> - data_out = superio_inb(sio->addr, gpio_data_out(bank->regbase));
> + data_out = superio_inb(sio->addr, f7188x_gpio_data_out(bank->regbase));
> if (value)
> data_out |= BIT(offset);
> else
> data_out &= ~BIT(offset);
> - superio_outb(sio->addr, gpio_data_out(bank->regbase), data_out);
> + superio_outb(sio->addr, f7188x_gpio_data_out(bank->regbase), data_out);
>
> - dir = superio_inb(sio->addr, gpio_dir(bank->regbase));
> + dir = superio_inb(sio->addr, f7188x_gpio_dir(bank->regbase));
> dir |= BIT(offset);
> - superio_outb(sio->addr, gpio_dir(bank->regbase), dir);
> + superio_outb(sio->addr, f7188x_gpio_dir(bank->regbase), dir);
>
> superio_exit(sio->addr);
>
> @@ -363,12 +363,12 @@ static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
> return;
> superio_select(sio->addr, SIO_LD_GPIO);
>
> - data_out = superio_inb(sio->addr, gpio_data_out(bank->regbase));
> + data_out = superio_inb(sio->addr, f7188x_gpio_data_out(bank->regbase));
> if (value)
> data_out |= BIT(offset);
> else
> data_out &= ~BIT(offset);
> - superio_outb(sio->addr, gpio_data_out(bank->regbase), data_out);
> + superio_outb(sio->addr, f7188x_gpio_data_out(bank->regbase), data_out);
>
> superio_exit(sio->addr);
> }
> @@ -391,12 +391,12 @@ static int f7188x_gpio_set_config(struct gpio_chip *chip, unsigned offset,
> return err;
> superio_select(sio->addr, SIO_LD_GPIO);
>
> - data = superio_inb(sio->addr, gpio_out_mode(bank->regbase));
> + data = superio_inb(sio->addr, f7188x_gpio_out_mode(bank->regbase));
> if (param == PIN_CONFIG_DRIVE_OPEN_DRAIN)
> data &= ~BIT(offset);
> else
> data |= BIT(offset);
> - superio_outb(sio->addr, gpio_out_mode(bank->regbase), data);
> + superio_outb(sio->addr, f7188x_gpio_out_mode(bank->regbase), data);
>
> superio_exit(sio->addr);
> return 0;
> --
> 2.35.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-08-25 11:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 10:44 [PATCH v6 0/7] add support for another simatic board Henning Schild
2022-08-25 10:44 ` [PATCH v6 1/7] gpio-f7188x: switch over to using pr_fmt Henning Schild
2022-08-25 11:19 ` Andy Shevchenko
2022-08-25 12:02 ` simon.guinot
2022-08-26 21:42 ` Linus Walleij
2022-08-25 10:44 ` [PATCH v6 2/7] gpio-f7188x: add a prefix to macros to keep gpio namespace clean Henning Schild
2022-08-25 11:20 ` Andy Shevchenko [this message]
2022-08-25 10:44 ` [PATCH v6 3/7] gpio-f7188x: Add GPIO support for Nuvoton NCT6116 Henning Schild
2022-08-25 10:44 ` [PATCH v6 4/7] gpio-f7188x: use unique labels for banks/chips Henning Schild
2022-08-25 10:44 ` [PATCH v6 5/7] leds: simatic-ipc-leds-gpio: add new model 227G Henning Schild
2022-08-25 17:33 ` Henning Schild
2022-08-25 18:03 ` Andy Shevchenko
2022-08-25 18:27 ` Henning Schild
2022-08-25 10:44 ` [PATCH v6 6/7] platform/x86: simatic-ipc: enable watchdog for 227G Henning Schild
2022-08-25 10:44 ` [PATCH v6 7/7] platform/x86: simatic-ipc: add new model 427G Henning Schild
2022-08-25 14:25 ` [PATCH v6 0/7] add support for another simatic board Hans de Goede
2022-08-25 14:29 ` Henning Schild
2022-08-25 14:31 ` Hans de Goede
2022-08-28 13:36 ` Bartosz Golaszewski
2022-09-01 14:24 ` Hans de Goede
2022-09-01 14:53 ` [GIT PULL] Immutable branch with 6.0-rc1 + "[PATCH v6 0/7] add support for another simatic board" series Hans de Goede
2022-09-01 15:19 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywda/0DQIpAjPa8f@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=hdegoede@redhat.com \
--cc=henning.schild@siemens.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=simon.guinot@sequanux.org \
--cc=syhuang3@nuvoton.com \
--cc=tasanakorn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.