From: Greg KH <gregkh@linuxfoundation.org>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: stable@vger.kernel.org, raajeshdasari@gmail.com,
ovidiu.panait@windriver.com
Subject: Re: [PATCH 5.4 0/2] Revert BPF selftest fixes in 5.4.y
Date: Thu, 25 Aug 2022 13:57:37 +0200 [thread overview]
Message-ID: <YwdjsTYdkS69AFvt@kroah.com> (raw)
In-Reply-To: <20220824144327.277365-1-jean-philippe@linaro.org>
On Wed, Aug 24, 2022 at 03:43:26PM +0100, Jean-Philippe Brucker wrote:
> Rajesh reports [1] that the test_align BPF selftest is broken in
> 5.4.210. Three patches were added since 5.4.209:
>
> (A) 7c1134c7da99 ("bpf: Verifer, adjust_scalar_min_max_vals to always call update_reg_bounds()")
> (B) 6a9b3f0f3bad ("selftests/bpf: Fix test_align verifier log patterns")
> (C) 6098562ed9df ("selftests/bpf: Fix "dubious pointer arithmetic" test")
>
> (A) fixes an issue in the BPF verifier, which changes the verifier trace
> output. (B) fixes those trace changes in the selftests.
>
> Unfortunately (B) also address changes to the verifier output from other
> patches that weren't backported to v5.4, so the test now fails.
> (C) also addresses a different verifier change that is not in v5.4.
>
> Therefore revert (C), and partially revert (B).
>
> [1] https://lore.kernel.org/all/CAPXMrf-C5XEUfOJd3GCtgtHOkc8DxDGbLxE5=GFmr+Py0zKxJA@mail.gmail.com/
>
> Jean-Philippe Brucker (2):
> Revert "selftests/bpf: Fix "dubious pointer arithmetic" test"
> Revert "selftests/bpf: Fix test_align verifier log patterns"
>
> tools/testing/selftests/bpf/test_align.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> --
> 2.37.1
>
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2022-08-25 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 14:43 [PATCH 5.4 0/2] Revert BPF selftest fixes in 5.4.y Jean-Philippe Brucker
2022-08-24 14:43 ` [PATCH 5.4 1/2] Revert "selftests/bpf: Fix "dubious pointer arithmetic" test" Jean-Philippe Brucker
2022-08-24 14:43 ` [PATCH 5.4 2/2] Revert "selftests/bpf: Fix test_align verifier log patterns" Jean-Philippe Brucker
2022-08-25 11:57 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwdjsTYdkS69AFvt@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jean-philippe@linaro.org \
--cc=ovidiu.panait@windriver.com \
--cc=raajeshdasari@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.